resource/aws_amplify_branch: fix forces replacement

[naruse666]

Description

Unnecessary ForceNew are included at enable_performance_mode.

Relations

Closes #34130

References

ForceNew isn't written in document.
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/amplify_branch#enable_performance_mode

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccAmplify_serial/Branch/OptionalArguments' PKG=amplify
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amplify/... -v -count 1 -parallel 20  -run=TestAccAmplify_serial/Branch/OptionalArguments -timeout 360m
=== RUN   TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT  TestAccAmplify_serial
=== RUN   TestAccAmplify_serial/Branch
=== RUN   TestAccAmplify_serial/Branch/OptionalArguments
--- PASS: TestAccAmplify_serial (338.48s)
    --- PASS: TestAccAmplify_serial/Branch (338.48s)
        --- PASS: TestAccAmplify_serial/Branch/OptionalArguments (338.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amplify	343.023s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[naruse666]

I found another bug.
had specified EnablePullRequestPreview on enable_performance_mode Update.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAmplify_serial/Branch' PKG=amplify
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amplify/... -v -count 1 -parallel 20  -run=TestAccAmplify_serial/Branch -timeout 360m
=== RUN   TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT  TestAccAmplify_serial
=== RUN   TestAccAmplify_serial/Branch
=== RUN   TestAccAmplify_serial/Branch/disappears
=== RUN   TestAccAmplify_serial/Branch/tags
=== RUN   TestAccAmplify_serial/Branch/BasicAuthCredentials
    branch_test.go:150: Step 1/4 error: Check failed: Check 2/3 error: aws_amplify_branch.test: Attribute 'basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOk5nUmI0VW5IVytqQjkwZ2I4djJKUEE9PXx8MXRlRXByY1NBTmhMN1VQbGZ0QjZxMmduVmd5U0lXT3pldm1xR1hJZTBFND0="
=== RUN   TestAccAmplify_serial/Branch/EnvironmentVariables
=== RUN   TestAccAmplify_serial/Branch/OptionalArguments
=== RUN   TestAccAmplify_serial/Branch/basic
--- FAIL: TestAccAmplify_serial (252.41s)
    --- FAIL: TestAccAmplify_serial/Branch (252.41s)
        --- PASS: TestAccAmplify_serial/Branch/disappears (27.82s)
        --- PASS: TestAccAmplify_serial/Branch/tags (70.99s)
        --- FAIL: TestAccAmplify_serial/Branch/BasicAuthCredentials (13.54s)
        --- PASS: TestAccAmplify_serial/Branch/EnvironmentVariables (64.57s)
        --- PASS: TestAccAmplify_serial/Branch/OptionalArguments (46.95s)
        --- PASS: TestAccAmplify_serial/Branch/basic (28.54s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/amplify	258.431s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

[ewbankkit]

@naruse666 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.