r/redshift_resource_policy - new resource #34149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!--- See what makes a good Pull Request at: https://hashicorp.github.io/terraform-provider-aws/raising-a-pull-request/ ---> ### Description <!--- Please provide a helpful description of what change this pull request will introduce. ---> ### Relations <!--- If your pull request fully resolves and should automatically close the linked issue, use Closes. Otherwise, use Relates. For Example: Relates #0000 or Closes #0000 ---> Closes hashicorp#34138 ### References <!--- Optionally, provide any helpful references that may help the reviewer(s). ---> ### Output from Acceptance Testing <!-- Replace TestAccXXX with a pattern that matches the tests affected by this PR. Replace ec2 with the service package corresponding to your tests. For more information on the `-run` flag, see the `go test` documentation at https://tip.golang.org/cmd/go/#hdr-Testing_flags. --> ```console % make testacc TESTS=TestAccRedshiftResourcePolicy_ PKG=redshift ... ```
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
needs-triage
DrFaust92
added
new-resource
ewbankkit
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftResourcePolicy_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2 -run=TestAccRedshiftResourcePolicy_ -timeout 360m
=== RUN TestAccRedshiftResourcePolicy_basic
=== PAUSE TestAccRedshiftResourcePolicy_basic
=== RUN TestAccRedshiftResourcePolicy_disappears
=== PAUSE TestAccRedshiftResourcePolicy_disappears
=== CONT TestAccRedshiftResourcePolicy_basic
=== CONT TestAccRedshiftResourcePolicy_disappears
--- PASS: TestAccRedshiftResourcePolicy_disappears (249.44s)
--- PASS: TestAccRedshiftResourcePolicy_basic (286.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 291.459s
|
@DrFaust92 Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Closes #34138
References
Output from Acceptance Testing