Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support to csv_classifier #34251

Merged
merged 4 commits into from Dec 28, 2023
Merged

Add serde support to csv_classifier #34251

merged 4 commits into from Dec 28, 2023

Conversation

PatrickRice-KSC
Copy link
Contributor

Description

This PR adds support for defining the serde attribute when creating a aws_glue_classifier with a csv_classifier block, allowing users to define the exact serde they want to use for a classifier instead of relying on Glue's inferrence.

Relations

Closes #33787

References

Output from Acceptance Testing

Pending

Copy link

github-actions bot commented Nov 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Nov 3, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@PatrickRice-KSC
Copy link
Contributor Author

Acceptance test now passes:

image

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2023
@PatrickRice-KSC
Copy link
Contributor Author

To ensure that this PR had good hygiene for merge, I rebased (since it's been open for a while), and squashed the commits into one. Let me know if there's anything else I can do to help facilitate review and merge!

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccGlueClassifier_' PKG=glue

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueClassifier_ -timeout 360m
--- PASS: TestAccGlueClassifier_disappears (52.46s)
--- PASS: TestAccGlueClassifier_GrokClassifier_customPatterns (83.48s)
--- PASS: TestAccGlueClassifier_grokClassifier (84.00s)
--- PASS: TestAccGlueClassifier_jsonClassifier (84.00s)
--- PASS: TestAccGlueClassifier_xmlClassifier (84.43s)
--- PASS: TestAccGlueClassifier_CSVClassifier_custom (84.44s)
--- PASS: TestAccGlueClassifier_csvClassifier (84.47s)
--- PASS: TestAccGlueClassifier_CSVClassifier_quoteSymbol (84.61s)
--- PASS: TestAccGlueClassifier_csvClassifierCustomSerde (86.25s)
--- PASS: TestAccGlueClassifier_typeChange (113.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	117.490s

@johnsonaj
Copy link
Contributor

@PatrickRice-KSC thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 8690dbe into hashicorp:main Dec 28, 2023
36 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 28, 2023
ewbankkit added a commit that referenced this pull request Jan 2, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Serde property missing in aws_glue_classifier of type CsvClassifier
3 participants