Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_domain/user_profile - add additional canvas app args #34265

Merged
merged 8 commits into from
Nov 8, 2023
Merged

r/sagemaker_domain/user_profile - add additional canvas app args #34265

merged 8 commits into from
Nov 8, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 4, 2023 •
edited
Loading

Description

Relations

Closes #34004
Closes #33034

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMaker_serial/Domain/identityProviderOauthSettings PKG=sagemaker

--- PASS: TestAccSageMaker_serial/Domain/identityProviderOauthSettings (439.49s)
--- PASS: TestAccSageMaker_serial/Domain/rStudioServerProAppSettings (652.62s)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. and removed size/XL Managed by automation to categorize the size of a PR. labels Nov 4, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Nov 4, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review November 4, 2023 21:47
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Nov 4, 2023
@DrFaust92 DrFaust92 marked this pull request as draft November 4, 2023 22:49
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Nov 4, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review November 5, 2023 09:26
ewbankkit
ewbankkit approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

 make testacc TESTARGS='-run=TestAccSageMaker_serial/Domain\|TestAccSageMaker_serial/UserProfile\|TestAccSageMaker_serial/Space' PKG=sagemaker 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/Domain\|TestAccSageMaker_serial/UserProfile\|TestAccSageMaker_serial/Space -timeout 360m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Domain
=== RUN   TestAccSageMaker_serial/Domain/workspaceSettings
=== RUN   TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/code
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage
    domain_test.go:700: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/canvas
=== RUN   TestAccSageMaker_serial/Domain/directDeploySettings
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Domain/securityGroup
=== RUN   TestAccSageMaker_serial/Domain/modelRegisterSettings
=== RUN   TestAccSageMaker_serial/Domain/kendraSettings
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Domain/kms
=== RUN   TestAccSageMaker_serial/Domain/sharingSettings
=== RUN   TestAccSageMaker_serial/Domain/rSessionAppSettings
=== RUN   TestAccSageMaker_serial/Domain/rStudioServerProAppSettings
=== RUN   TestAccSageMaker_serial/Domain/basic
=== RUN   TestAccSageMaker_serial/Domain/disappears
=== RUN   TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage
    domain_test.go:661: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Domain/identityProviderOauthSettings
=== RUN   TestAccSageMaker_serial/Domain/domainSettings
=== RUN   TestAccSageMaker_serial/Domain/tags
=== RUN   TestAccSageMaker_serial/Domain/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated
=== RUN   TestAccSageMaker_serial/Space
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig
    space_test.go:170: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Space/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Space/basic
=== RUN   TestAccSageMaker_serial/Space/disappears
=== RUN   TestAccSageMaker_serial/Space/tags
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile
=== RUN   TestAccSageMaker_serial/UserProfile/basic
=== RUN   TestAccSageMaker_serial/UserProfile/tags
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/UserProfile/disappears
=== RUN   TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig
    user_profile_test.go:244: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings
--- PASS: TestAccSageMaker_serial (10021.43s)
    --- PASS: TestAccSageMaker_serial/Domain (6248.46s)
        --- PASS: TestAccSageMaker_serial/Domain/workspaceSettings (422.19s)
        --- PASS: TestAccSageMaker_serial/Domain/spaceSettingsKernelGatewayAppSettings (282.85s)
        --- PASS: TestAccSageMaker_serial/Domain/code (258.98s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_defaultResourceAndCustomImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/canvas (258.65s)
        --- PASS: TestAccSageMaker_serial/Domain/directDeploySettings (258.75s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_lifecycleConfig (258.29s)
        --- PASS: TestAccSageMaker_serial/Domain/securityGroup (271.66s)
        --- PASS: TestAccSageMaker_serial/Domain/modelRegisterSettings (248.13s)
        --- PASS: TestAccSageMaker_serial/Domain/kendraSettings (248.58s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettings (249.36s)
        --- PASS: TestAccSageMaker_serial/Domain/tensorboardAppSettingsWithImage (316.91s)
        --- PASS: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings (248.66s)
        --- PASS: TestAccSageMaker_serial/Domain/kms (248.97s)
        --- PASS: TestAccSageMaker_serial/Domain/sharingSettings (249.51s)
        --- PASS: TestAccSageMaker_serial/Domain/rSessionAppSettings (249.29s)
        --- PASS: TestAccSageMaker_serial/Domain/rStudioServerProAppSettings (293.49s)
        --- PASS: TestAccSageMaker_serial/Domain/basic (258.87s)
        --- PASS: TestAccSageMaker_serial/Domain/disappears (289.64s)
        --- SKIP: TestAccSageMaker_serial/Domain/kernelGatewayAppSettings_customImage (0.00s)
        --- PASS: TestAccSageMaker_serial/Domain/identityProviderOauthSettings (260.36s)
        --- PASS: TestAccSageMaker_serial/Domain/domainSettings (281.98s)
        --- PASS: TestAccSageMaker_serial/Domain/tags (255.22s)
        --- PASS: TestAccSageMaker_serial/Domain/jupyterServerAppSettings (248.86s)
        --- PASS: TestAccSageMaker_serial/Domain/defaultUserSettingsUpdated (289.27s)
    --- PASS: TestAccSageMaker_serial/Space (1621.14s)
        --- SKIP: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterServerAppSettings (267.85s)
        --- PASS: TestAccSageMaker_serial/Space/basic (272.29s)
        --- PASS: TestAccSageMaker_serial/Space/disappears (292.50s)
        --- PASS: TestAccSageMaker_serial/Space/tags (261.27s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings (264.16s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig (263.07s)
    --- PASS: TestAccSageMaker_serial/UserProfile (2151.83s)
        --- PASS: TestAccSageMaker_serial/UserProfile/basic (264.17s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tags (261.02s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettings (265.04s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_lifecycleConfig (265.74s)
        --- PASS: TestAccSageMaker_serial/UserProfile/disappears (293.63s)
        --- PASS: TestAccSageMaker_serial/UserProfile/tensorboardAppSettingsWithImage (272.91s)
        --- PASS: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings (264.56s)
        --- SKIP: TestAccSageMaker_serial/UserProfile/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/UserProfile/jupyterServerAppSettings (264.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	10026.638s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ecd18a0 into hashicorp:main Nov 8, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 8, 2023
@damianslee
Copy link

Is there a way I can test this from tf cloud with our dev sagemaker implementation before 5.25 is released?

@github-actions GitHub Actions
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

damianslee
damianslee reviewed Nov 13, 2023
View reviewed changes
Copy link

@damianslee damianslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing 5.25 and getting this crash stack or expandCanvasAppSettings

Stack trace from the terraform-provider-aws_v5.25.0_x5 plugin:

panic: interface conversion: interface {} is *schema.Set, not []interface {}

goroutine 378 [running]:
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker.expandCanvasAppSettings({0xc002ac0ad0?, 0xc00463b0b0?, 0xe27c8ce?})
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker/domain.go:1211 +0x533
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker.expandDomainDefaultUserSettings({0xc002ac0a40?, 0xe239a6d?, 0xc0044dfe30?})
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker/domain.go:1009 +0xbf
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker.resourceUserProfileUpdate({0xf5fc220, 0xc0044dfe30}, 0xc002cb8000, {0xe1a8680?, 0xc0002c8b40})
github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker/user_profile.go:577 +0x1fc
github.com/hashicorp/terraform-provider-aws/internal/provider.interceptedHandler[...].func1(0x0?, {0xe1a8680?, 0xc0002c8b40?})
github.com/hashicorp/terraform-provider-aws/internal/provider/intercept.go:111 +0x32d
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).update(0xf5fc220?, {0xf5fc220?, 0xc004362c90?}, 0xd?, {0xe1a8680?, 0xc0002c8b40?})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/resource.go:807 +0x87
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc001b4d340, {0xf5fc220, 0xc004362c90}, 0xc00436c410, 0xc0042e3400, {0xe1a8680, 0xc0002c8b40})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/resource.go:919 +0x845
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0xc001c0dc20, {0xf5fc220?, 0xc004362b70?}, 0xc0042cd590)
github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/grpc_provider.go:1060 +0xe8d
github.com/hashicorp/terraform-plugin-mux/tf5muxserver.(*muxServer).ApplyResourceChange(0xf5fc178?, {0xf5fc220?, 0xc004362840?}, 0xc0042cd590)
github.com/hashicorp/terraform-plugin-mux@v0.12.0/tf5muxserver/mux_server_ApplyResourceChange.go:36 +0x1b5
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ApplyResourceChange(0xc00095b9a0, {0xf5fc220?, 0xc004362030?}, 0xc004356a80)
github.com/hashicorp/terraform-plugin-go@v0.19.0/tfprotov5/tf5server/server.go:859 +0x574
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0xdf2bb60?, 0xc00095b9a0}, {0xf5fc220, 0xc004362030}, 0xc004356a10, 0x0)
github.com/hashicorp/terraform-plugin-go@v0.19.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:467 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc000114d20, {0xf60a9a0, 0xc0034464e0}, 0xc004346d80, 0xc004030870, 0x15c32db8, 0x0)
google.golang.org/grpc@v1.58.2/server.go:1376 +0xdd2
google.golang.org/grpc.(*Server).handleStream(0xc000114d20, {0xf60a9a0, 0xc0034464e0}, 0xc004346d80, 0x0)
google.golang.org/grpc@v1.58.2/server.go:1753 +0xa36
google.golang.org/grpc.(*Server).serveStreams.func1.1()
google.golang.org/grpc@v1.58.2/server.go:998 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
google.golang.org/grpc@v1.58.2/server.go:996 +0x18c

Error: The terraform-provider-aws_v5.25.0_x5 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

Operation failed: failed running terraform apply (exit 1)�

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damianslee damianslee damianslee left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.25.0
3 participants
@DrFaust92 @ewbankkit @damianslee