Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_bedrock_model_invocation_logging_configuration resource #34303

Conversation

skyscrapr
Copy link
Contributor

@skyscrapr skyscrapr commented Nov 8, 2023

Description

Adding new Amazon Bedrock resource: "aws_bedrock_model_invocation_logging_configuration"

Relations

closes #33737

References

https://docs.aws.amazon.com/bedrock/latest/APIReference/API_PutModelInvocationLoggingConfiguration.html

Output from Acceptance Testing

% make testacc TESTS=TestAccBedrockModelInvocationLoggingConfiguration_ PKG=bedrock
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockModelInvocationLoggingConfiguration_'  -timeout 360m
=== RUN   TestAccBedrockModelInvocationLoggingConfiguration_basic
=== PAUSE TestAccBedrockModelInvocationLoggingConfiguration_basic
=== CONT  TestAccBedrockModelInvocationLoggingConfiguration_basic
--- PASS: TestAccBedrockModelInvocationLoggingConfiguration_basic (59.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    62.723s
...

Copy link

github-actions bot commented Nov 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrock Issues and PRs that pertain to the bedrock service. labels Nov 8, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 8, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 8, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Nov 8, 2023
@jar-b jar-b self-assigned this Nov 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 10, 2023
…t, refactor flex functions

autoflex does not currently support SingleNestedBlock types, but once support is added this
is potentially a candidate to be migrated
@skyscrapr
Copy link
Contributor Author

@jar-b

Thanks for the tidy up. That use of flex is useful to understand.

@jar-b
Copy link
Member

jar-b commented Nov 10, 2023

No problem! Working on a couple more testing additions which might not be wrapped today, but should have this merged by Monday at the latest and ready for next weeks release.

@skyscrapr
Copy link
Contributor Author

I might need to update my newer PR for the custom_model resource with these fixes. Will take a look once you're done with this. Thanks for the effort.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=bedrock TESTS=TestAccBedrock_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrock_serial'  -timeout 360m
=== RUN   TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT  TestAccBedrock_serial
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears
--- PASS: TestAccBedrock_serial (428.06s)
    --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration (428.06s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic (218.23s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears (209.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    431.392s

@jar-b jar-b merged commit 7a78d45 into hashicorp:main Nov 13, 2023
44 checks passed
@jar-b
Copy link
Member

jar-b commented Nov 13, 2023

Thanks for your contribution, @skyscrapr! 👍

@github-actions github-actions bot added this to the v5.26.0 milestone Nov 13, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/bedrock Issues and PRs that pertain to the bedrock service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Amazon Bedrock - Model invocation logging
2 participants