aws_lb_target_group: Add lb_arns attribute #34364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
needs-triage
github-actions
bot
added
the
size/XS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @dongho-jung 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
github-actions
bot
added
size/S
justinretzolk
added
enhancement
terraform-aws-provider
bot
added
the
prioritized
johnsonaj
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccELBV2TargetGroup' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2TargetGroup -timeout 360m
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_matcherOutOfRange (10.63s)
--- PASS: TestAccELBV2TargetGroup_Lambda_defaults (22.87s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_basic (23.19s)
--- PASS: TestAccELBV2TargetGroup_Lambda_port (23.90s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocolVersion (24.10s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_InvalidAnomalyMitigation (26.80s)
--- PASS: TestAccELBV2TargetGroup_Lambda_vpc (32.03s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_InvalidSlowStart (15.76s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (51.37s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (52.45s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (29.14s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (46.32s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (31.98s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (31.37s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled (69.96s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAnomalyMitigation (70.03s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (55.14s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (78.69s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (30.40s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (32.26s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (53.10s)
--- PASS: TestAccELBV2TargetGroup_Lambda_vpc_MigrateV0 (92.45s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_basic_MigrateV0 (96.20s)
--- PASS: TestAccELBV2TargetGroupAttachment_basic (96.39s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (72.60s)
--- PASS: TestAccELBV2TargetGroup_targetHealthStateUnhealthyConnectionTermination (99.76s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (100.06s)
--- PASS: TestAccELBV2TargetGroup_udp (31.07s)
--- PASS: TestAccELBV2TargetGroup_Lambda_port_MigrateV0 (101.90s)
--- PASS: TestAccELBV2TargetGroup_Lambda_defaults_MigrateV0 (103.28s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (55.45s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocolVersion_MigrateV0 (109.30s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (57.06s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (59.79s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (28.65s)
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (35.56s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (47.23s)
--- PASS: TestAccELBV2TargetGroup_Defaults_application (26.80s)
--- PASS: TestAccELBV2TargetGroup_Defaults_network (28.72s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (75.86s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (50.75s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateStickinessType (70.35s)
--- PASS: TestAccELBV2TargetGroup_Geneve_Sticky (49.16s)
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (48.75s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (48.20s)
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (50.37s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (42.32s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated (47.62s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (80.57s)
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (57.26s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (70.10s)
--- PASS: TestAccELBV2TargetGroup_Geneve_targetFailover (69.85s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (45.42s)
--- PASS: TestAccELBV2TargetGroup_tls (29.97s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (78.12s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (93.88s)
--- PASS: TestAccELBV2TargetGroup_nameGenerated (34.29s)
--- PASS: TestAccELBV2TargetGroup_ipAddressType (33.49s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (30.35s)
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (29.30s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (48.00s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (47.35s)
--- PASS: TestAccELBV2TargetGroup_namePrefix (28.05s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (50.75s)
--- PASS: TestAccELBV2TargetGroup_duplicateName (33.61s)
--- PASS: TestAccELBV2TargetGroup_disappears (29.25s)
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (56.27s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (61.53s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (50.22s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (51.33s)
--- PASS: TestAccELBV2TargetGroupAttachment_lambda (30.39s)
--- PASS: TestAccELBV2TargetGroup_basic (43.23s)
--- PASS: TestAccELBV2TargetGroup_tags (69.34s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol (0.00s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/TCP_UDP (16.90s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/GENEVE (17.24s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/UDP (16.68s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/HTTP (23.22s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/TLS (17.99s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/TCP (20.40s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol/HTTPS (15.54s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol (0.00s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol/TCP (2.17s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol/HTTPS (15.41s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol/HTTP (20.88s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults/HTTP (24.81s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults/HTTPS (23.77s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults/TCP (25.33s)
--- PASS: TestAccELBV2TargetGroupDataSource_tags (70.84s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0 (0.00s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0/TCP (34.38s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0/HTTP (54.12s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0/HTTPS (59.48s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/HTTP (21.35s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/TLS (19.26s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/TCP_UDP (18.16s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/TCP (20.05s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/UDP (18.95s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/HTTPS (19.39s)
--- PASS: TestAccELBV2TargetGroupAttachment_port (90.89s)
--- PASS: TestAccELBV2TargetGroupAttachment_backwardsCompatibility (87.92s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missing (0.00s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missing/Port (1.94s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missing/VPC (1.87s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missing/Protocol (2.05s)
--- PASS: TestAccELBV2TargetGroupAttachment_ipAddress (89.97s)
--- PASS: TestAccELBV2TargetGroupAttachment_disappears (89.32s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP/TCP (1.47s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP/HTTPS (21.79s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP/HTTP (25.80s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS/TCP (2.37s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS/HTTP (20.40s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS/HTTPS (20.53s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP/TCP (2.13s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP/HTTP (10.49s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP/HTTPS (10.84s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP/TCP (1.52s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP/HTTP (11.66s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP/HTTPS (10.29s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS/TCP (2.35s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS/HTTP (11.09s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS/HTTPS (8.76s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP/TCP (2.38s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP/HTTP (10.13s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP/HTTPS (10.51s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS/TCP (1.87s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS/HTTP (10.76s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS/HTTPS (9.63s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP/TCP (1.54s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP/HTTP (10.74s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP/HTTPS (11.71s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP/TCP (2.27s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP/HTTP (11.74s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP/HTTPS (11.42s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS/HTTP (10.34s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS/TCP (2.55s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS/HTTPS (11.38s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP/TCP (1.79s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP/HTTP (17.69s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP/HTTPS (20.60s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS/TCP (2.92s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS/HTTP (21.80s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS/HTTPS (22.86s)
--- PASS: TestAccELBV2TargetGroupDataSource_basic (202.40s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0 (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/HTTP (84.91s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/TLS (105.55s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/TCP_UDP (116.85s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/TCP (125.12s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/HTTPS (128.52s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/UDP (139.69s)
--- PASS: TestAccELBV2TargetGroupDataSource_backwardsCompatibility (215.93s)
--- PASS: TestAccELBV2TargetGroupDataSource_appCookie (222.60s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP/TCP (2.94s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP/HTTP (23.90s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP/HTTPS (24.21s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS/TCP (3.99s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS/HTTP (23.71s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS/HTTPS (29.06s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP/TCP (3.09s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP/HTTP (25.29s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP/HTTPS (28.56s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS/TCP (3.22s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS/HTTP (27.90s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS/HTTPS (30.23s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP/TCP (3.48s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP/HTTPS (29.86s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP/HTTP (31.29s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP/TCP (4.21s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP/HTTPS (30.17s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP/HTTP (39.72s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0 (0.00s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/HTTP (117.62s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/GENEVE (119.18s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/TCP_UDP (121.80s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/TLS (127.07s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/HTTPS (130.48s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/UDP (137.93s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/TCP (143.98s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP/TCP (4.32s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP/HTTP (30.29s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP/HTTPS (29.84s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS/HTTP (32.57s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS/HTTPS (31.17s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS/TCP (33.07s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP/TCP (29.01s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP/HTTP (29.52s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP/HTTPS (28.25s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP/HTTP (30.86s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP/HTTPS (30.95s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP/TCP (31.12s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS/TCP (4.51s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS/HTTPS (29.16s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS/HTTP (30.12s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP/HTTP (28.95s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP/TCP (29.05s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP/HTTPS (30.15s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP/TCP (4.14s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP/HTTP (28.15s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP/HTTPS (28.35s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS/TCP (3.99s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS/HTTP (27.93s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS/HTTPS (25.74s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP/TCP (2.92s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP/HTTP (25.17s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP/HTTPS (23.56s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP/TCP (2.91s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP/HTTP (22.85s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP/HTTPS (22.90s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP/TCP (4.04s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP/HTTPS (22.43s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP/HTTP (22.76s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS (0.00s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS/TCP (3.46s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS/HTTP (22.20s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS/HTTPS (17.79s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 441.438s
|
@dongho-jung thank you for the contribution! 🎉 |
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this attribute to aws_lb_target_group would allow us to dynamically generate CloudWatch alarms for HealthyHostCount. Since the HealthyHostCount metric requires the LoadBalancer dimension, we need to find the LB ARN of the TG. I tried using null_resource, external, and terraform_data, but they aren't evaluated during the plan phase. Therefore, I believe this PR is the neatest way to achieve my goal of generating alarms.
(If necessary, I can share an example in Terraform code that dynamically creates alarms for monitoring the HealthyHostCount of Target Groups tagged with 'Environment=production', by utilizing the newly added lb_arns attribute along with aws_resourcegroupstaggingapi_resources.)
I attempted to create more meaningful tests, but ended up with simpler ones instead, as I'm unsure how to obtain the LB ARN generated during testing. If more sophisticated tests are necessary, are there any helper functions or practices for referencing a resource's attributes that are generated during testing? If not, I'll try to develop a solution.
Output from Acceptance Testing