Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elasticache_user: Add acceptance test for tagging during out-of-band modification #34396

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 14, 2023

Description

Fix UserNotFound: ... is not available for tagging errors on resource Read when there is a concurrent update to the user by waiting for the resource to be in active state.

As many stray ElastiCache users were created during testing, sweeper for aws_elasticache_user and aws_elasticache_user_group have been added.

Relations

Closes #34002.

Acceptance Test Output

% make testacc TESTARGS='-run=TestAccElastiCacheUser_' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheUser_ -timeout 360m
=== RUN   TestAccElastiCacheUser_basic
=== PAUSE TestAccElastiCacheUser_basic
=== RUN   TestAccElastiCacheUser_password_auth_mode
=== PAUSE TestAccElastiCacheUser_password_auth_mode
=== RUN   TestAccElastiCacheUser_iam_auth_mode
=== PAUSE TestAccElastiCacheUser_iam_auth_mode
=== RUN   TestAccElastiCacheUser_update
=== PAUSE TestAccElastiCacheUser_update
=== RUN   TestAccElastiCacheUser_update_password_auth_mode
=== PAUSE TestAccElastiCacheUser_update_password_auth_mode
=== RUN   TestAccElastiCacheUser_tags
=== PAUSE TestAccElastiCacheUser_tags
=== RUN   TestAccElastiCacheUser_disappears
=== PAUSE TestAccElastiCacheUser_disappears
=== RUN   TestAccElastiCacheUser_oobModify
=== PAUSE TestAccElastiCacheUser_oobModify
=== CONT  TestAccElastiCacheUser_basic
=== CONT  TestAccElastiCacheUser_update_password_auth_mode
--- PASS: TestAccElastiCacheUser_basic (55.65s)
=== CONT  TestAccElastiCacheUser_oobModify
--- PASS: TestAccElastiCacheUser_update_password_auth_mode (181.44s)
=== CONT  TestAccElastiCacheUser_disappears
--- PASS: TestAccElastiCacheUser_oobModify (179.98s)
=== CONT  TestAccElastiCacheUser_tags
--- PASS: TestAccElastiCacheUser_tags (60.51s)
=== CONT  TestAccElastiCacheUser_iam_auth_mode
--- PASS: TestAccElastiCacheUser_iam_auth_mode (68.67s)
=== CONT  TestAccElastiCacheUser_update
--- PASS: TestAccElastiCacheUser_disappears (223.14s)
=== CONT  TestAccElastiCacheUser_password_auth_mode
--- PASS: TestAccElastiCacheUser_password_auth_mode (80.51s)
--- PASS: TestAccElastiCacheUser_update (121.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	492.314s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Nov 14, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 14, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. sweeper Pertains to changes to or issues with the sweeper. labels Nov 14, 2023
…agging` errors on resource Read when there is a concurrent update to the user.
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 15, 2023
@ewbankkit ewbankkit merged commit 51b83a7 into main Nov 15, 2023
53 checks passed
@ewbankkit ewbankkit deleted the t-aws_elasticache_user-tagging-modify branch November 15, 2023 15:58
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Nov 15, 2023
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 15, 2023
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 16, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error with aws_elasticache_user Resource: UserNotFound during tagging operation
1 participant