Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClientToken to ECS Task Execution Data Source #34402

Merged

Conversation

jtyrus
Copy link
Contributor

@jtyrus jtyrus commented Nov 15, 2023

Description

Added client_token optional field to data.aws_ecs_task_execution and updated associated docs. This field allows fir idempotency (multiple runs with the same client_token aren't allowed).

Relations

Closes #34394

References

RunTask Docs

Output from Acceptance Testing

% make testacc TESTS=TestAccECSTaskExecutionDataSource PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskExecutionDataSource'  -timeout 360m
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN   TestAccECSTaskExecutionDataSource_overrides
=== PAUSE TestAccECSTaskExecutionDataSource_overrides
=== RUN   TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== CONT  TestAccECSTaskExecutionDataSource_basic
=== CONT  TestAccECSTaskExecutionDataSource_tags
=== CONT  TestAccECSTaskExecutionDataSource_overrides
--- PASS: TestAccECSTaskExecutionDataSource_basic (278.91s)
--- PASS: TestAccECSTaskExecutionDataSource_overrides (290.11s)
--- PASS: TestAccECSTaskExecutionDataSource_tags (290.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        290.455s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 15, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2023
@jtyrus jtyrus marked this pull request as ready for review November 15, 2023 00:44
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. size/XS Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSTaskExecutionDataSource_basic' PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSTaskExecutionDataSource_basic -timeout 360m
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== CONT  TestAccECSTaskExecutionDataSource_basic
--- PASS: TestAccECSTaskExecutionDataSource_basic (277.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	289.129s

@ewbankkit
Copy link
Contributor

@jtyrus Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c6de339 into hashicorp:main Feb 12, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 12, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add client_token argument to aws_ecs_task_execution
3 participants