Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elasticache_replication_group: Remove auth_token_update_strategy default #34496

Open
jar-b opened this issue Nov 21, 2023 · 4 comments
Open
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Nov 21, 2023

Description

The auth_token_update_strategy argument was added in #34460 with a default value of ROTATE to retain backward compatibility with previous provider versions where this was hardcoded into update operations. In v6.0.0, the default value should be removed and this argument should be required when auth_token is set to ensure practitioners are aware of the rotation strategy being used when credentials are added or modified. This will be a breaking change.

References

Relates #34460
Relates #33439

Would you like to implement a fix?

None

@jar-b jar-b added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/elasticache Issues and PRs that pertain to the elasticache service. labels Nov 21, 2023
@jar-b jar-b added this to the v6.0.0 milestone Nov 21, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@CbaSage
Copy link

CbaSage commented Nov 28, 2023

Can confirm. It broke out deployment pipeline:

Error: changing auth_token for ElastiCache Replication Group (<rep-group-name>): InvalidParameterCombination: Auth tokens can't be enabled with a user group already associated. Pass RemoveUserGroups to proceed.
│ 	status code: 400, request id: <request-id>
│ 
│   with aws_elasticache_replication_group.this,
│   on elasticache.tf line 7, in resource "aws_elasticache_replication_group" "this":
│    7: resource "aws_elasticache_replication_group" "this" {

@jar-b
Copy link
Member Author

jar-b commented Nov 29, 2023

Hey @CbaSage - this regression should have been fixed with #34600, released in v5.28.0 last night.

This issue is focused on future breaking changes for the next major release (v6.0.0). For the v5.X series, the default value will remain to keep backwards compatibility. This comment contains a more detailed explanation for this, if interested.

@priyanshur-curefit
Copy link

hi @jar-b ,
This issue is still not fixed. When i am trying to import aws_elasticache_replication_group, it automatically adds auth_token_strategy in terraform plan . I had t use lifecycle policies to ignore the change. Can we relook at this once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

No branches or pull requests

3 participants