Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lexv2models_bot: support explicit type argument on create and update #34524

Merged
merged 2 commits into from Nov 22, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 22, 2023

Description

Previously, explicitly configured values for the type argument were not sent during create or update operations, resulting in the default Bot type in all cases. These operations will now send the type value when set.

Note: An acceptance test using the BotNetwork bot type could not be written at this time, as it is dependent on the aws_lexv2models_bot_alias resource which is not yet available.

Relations

Relates #33475

References

Output from Acceptance Testing

% make testacc PKG=lexv2models TESTS=TestAccLexV2ModelsBot_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBot_'  -timeout 360m

--- PASS: TestAccLexV2ModelsBot_disappears (103.22s)
--- PASS: TestAccLexV2ModelsBot_type (104.00s)
--- PASS: TestAccLexV2ModelsBot_basic (104.32s)
--- PASS: TestAccLexV2ModelsBot_tags (210.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        214.070s

…pdate

Previously, explicitly configured values for the type argument were not sent
during create or update operations, resulting in the default `Bot` type in
all cases. These operations will now send the type value when set.
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lexv2models Issues and PRs that pertain to the lexv2models service. labels Nov 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 22, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Nov 22, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLexV2ModelsBot_' PKG=lexv2models ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 2  -run=TestAccLexV2ModelsBot_ -timeout 360m
=== RUN   TestAccLexV2ModelsBot_basic
=== PAUSE TestAccLexV2ModelsBot_basic
=== RUN   TestAccLexV2ModelsBot_tags
=== PAUSE TestAccLexV2ModelsBot_tags
=== RUN   TestAccLexV2ModelsBot_disappears
=== PAUSE TestAccLexV2ModelsBot_disappears
=== RUN   TestAccLexV2ModelsBot_type
=== PAUSE TestAccLexV2ModelsBot_type
=== CONT  TestAccLexV2ModelsBot_basic
=== CONT  TestAccLexV2ModelsBot_disappears
--- PASS: TestAccLexV2ModelsBot_disappears (27.35s)
=== CONT  TestAccLexV2ModelsBot_tags
--- PASS: TestAccLexV2ModelsBot_basic (30.22s)
=== CONT  TestAccLexV2ModelsBot_type
--- PASS: TestAccLexV2ModelsBot_type (30.27s)
--- PASS: TestAccLexV2ModelsBot_tags (62.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	95.052s

@jar-b jar-b merged commit 2d9d686 into main Nov 22, 2023
37 checks passed
@jar-b jar-b deleted the b-lexv2-bot-type branch November 22, 2023 20:36
@github-actions github-actions bot added this to the v5.27.0 milestone Nov 22, 2023
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Copy link

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 27, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lexv2models Issues and PRs that pertain to the lexv2models service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants