Amazon S3 Access Grants #34564

ewbankkit · 2023-11-27T11:08:31Z

Description

Initial support for Amazon S3 Access Grants.

Relations

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial' PKG=s3control         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccessGrants_serial -timeout 360m
=== RUN   TestAccS3ControlAccessGrants_serial
=== PAUSE TestAccS3ControlAccessGrants_serial
=== CONT  TestAccS3ControlAccessGrants_serial
=== RUN   TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy
=== RUN   TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/disappears
    acctest.go:847: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/basic
    acctest.go:847: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccS3ControlAccessGrants_serial/Instance
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/basic
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/disappears
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/tags
=== RUN   TestAccS3ControlAccessGrants_serial/Location
=== RUN   TestAccS3ControlAccessGrants_serial/Location/basic
=== RUN   TestAccS3ControlAccessGrants_serial/Location/disappears
=== RUN   TestAccS3ControlAccessGrants_serial/Location/tags
=== RUN   TestAccS3ControlAccessGrants_serial/Location/update
=== RUN   TestAccS3ControlAccessGrants_serial/Grant
=== RUN   TestAccS3ControlAccessGrants_serial/Grant/basic
=== RUN   TestAccS3ControlAccessGrants_serial/Grant/disappears
=== RUN   TestAccS3ControlAccessGrants_serial/Grant/tags
=== RUN   TestAccS3ControlAccessGrants_serial/Grant/locationConfiguration
--- FAIL: TestAccS3ControlAccessGrants_serial (661.68s)
    --- PASS: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy (0.39s)
        --- SKIP: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/disappears (0.39s)
        --- SKIP: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/basic (0.00s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Instance (94.69s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (23.20s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (16.86s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/tags (54.64s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Location (214.38s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/basic (32.98s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/disappears (28.97s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/tags (73.70s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/update (78.73s)
    --- FAIL: TestAccS3ControlAccessGrants_serial/Grant (352.22s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/basic (51.59s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/disappears (47.50s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/tags (91.54s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/locationConfiguration (47.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	667.429s

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy -timeout 360m
=== RUN   TestAccS3ControlAccessGrants_serial
=== PAUSE TestAccS3ControlAccessGrants_serial
=== CONT  TestAccS3ControlAccessGrants_serial
=== RUN   TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy
=== RUN   TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/basic
=== RUN   TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/disappears
--- PASS: TestAccS3ControlAccessGrants_serial (63.03s)
    --- PASS: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy (63.03s)
        --- PASS: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/basic (33.80s)
        --- PASS: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/disappears (29.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	68.371s

… because of additional account ID argument.

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial' PKG=s3control ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessGrants_serial -timeout 360m === RUN TestAccS3ControlAccessGrants_serial === PAUSE TestAccS3ControlAccessGrants_serial === CONT TestAccS3ControlAccessGrants_serial === RUN TestAccS3ControlAccessGrants_serial/Instance === RUN TestAccS3ControlAccessGrants_serial/Instance/basic --- PASS: TestAccS3ControlAccessGrants_serial (44.41s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance (44.41s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (44.41s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 56.946s

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial' PKG=s3control ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessGrants_serial -timeout 360m === RUN TestAccS3ControlAccessGrants_serial === PAUSE TestAccS3ControlAccessGrants_serial === CONT TestAccS3ControlAccessGrants_serial === RUN TestAccS3ControlAccessGrants_serial/Instance === RUN TestAccS3ControlAccessGrants_serial/Instance/basic === RUN TestAccS3ControlAccessGrants_serial/Instance/disappears --- PASS: TestAccS3ControlAccessGrants_serial (41.25s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance (41.25s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (24.32s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (16.93s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 46.927s

…w works with 'StringValuable'.

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial/Instance' PKG=s3control ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessGrants_serial/Instance -timeout 360m === RUN TestAccS3ControlAccessGrants_serial === PAUSE TestAccS3ControlAccessGrants_serial === CONT TestAccS3ControlAccessGrants_serial === RUN TestAccS3ControlAccessGrants_serial/Instance === RUN TestAccS3ControlAccessGrants_serial/Instance/basic === RUN TestAccS3ControlAccessGrants_serial/Instance/disappears --- PASS: TestAccS3ControlAccessGrants_serial (42.98s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance (42.98s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (26.17s) --- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (16.81s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 48.473s

…ARN'.

…nce tests.

…sistency error handling.

…LocationNotEmptyError'.

…y error.

internal/service/s3control/access_grant.go

…rator (',').

github-actions · 2023-11-27T15:35:19Z

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

…acceptance tests.

jar-b

LGTM 🪣

% make testacc PKG=s3control TESTS=TestAccS3ControlAccessGrants_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run='TestAccS3ControlAccessGrants_serial'  -timeout 360m

--- PASS: TestAccS3ControlAccessGrants_serial (1821.04s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Instance (143.46s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (33.90s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (26.32s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/tags (83.24s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Location (725.74s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/basic (109.99s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/disappears (102.46s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/tags (250.22s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Location/update (263.06s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Grant (951.85s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/basic (175.24s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/disappears (175.64s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/tags (425.15s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Grant/locationConfiguration (175.81s)
    --- PASS: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy (0.00s)
        --- SKIP: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/disappears (0.00s)
        --- SKIP: TestAccS3ControlAccessGrants_serial/InstanceResourcePolicy/basic (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  1824.404s

github-actions · 2023-11-27T19:43:54Z

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-12-28T02:04:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit added 30 commits October 20, 2023 15:56

Use S3 Access Grants Beta1.3 SDK.

1a64210

Add 'withMeta.RegionalARN'.

745043d

Add 'enum.FrameworkDefault'.

613bc77

framework/types: Add 'ToPtr' and 'ToSlice' methods.

990f6f3

Add 'validators.AWSAccountID'.

4ba503d

r/aws_s3control_access_grants_instance: Initial skeleton.

a7fbfe6

r/aws_s3control_access_grants_instance: Continue with implementation.

e48ee66

Add CHANGELOG entry.

388885e

r/aws_s3control_access_grants_instance: Add documentation.

05da8f2

s3control: Rename tagging functions for S3Tags.

c2c15d0

s3control: Generate tagging functions for Tags.

b500a11

r/aws_s3control_access_grants_instance: Can't use transparent tagging…

9a7cf57

… because of additional account ID argument.

r/aws_s3control_access_grants_instance: Add tagging functionality.

3bd49e9

r/aws_s3control_access_grants_instance: Initial acceptance test.

987f59b

r/aws_s3control_access_grants_instance: Additional acceptance test.

987c302

Comment out tagging tests for now.

9945e1f

Tweak error message.

a0aad95

r/aws_s3control_access_grants_instance: Tweak Delete.

11b9d58

Add 'StringValuable' assetions for custom string types.

34453fc

Remove 'flex.ARNStringFromFramework' -- 'flex.StringFromFramework' no…

9170bbe

…w works with 'StringValuable'.

r/aws_s3control_access_grants_instance: Tweak resource model.

d0fdeb9

d/aws_globalaccelerator_accelerator: Use 'flex.flex.StringToFramework…

9088bb1

…ARN'.

Document 'flex.StringToFrameworkARN'.

7b76b1a

framework/flex: Use 'Valuable' interfaces.

d39fd05

r/aws_s3control_access_grants_location: Initial implementation.

8b33806

r/aws_s3control_access_grants_location: Add documentation.

3951300

r/aws_s3control_access_grants_location: Add acceptance tests.

1359a97

ewbankkit added 12 commits November 27, 2023 07:58

s3control: Standardize tagging code generation.

efd9713

r/aws_s3control_access_grants_location: Some renaming.

a1d09d1

r/aws_s3control_access_grant: Some renaming.

b4cfd1b

r/aws_s3control_access_grants_instance_resource_policy: Some renaming.

d8cbdfa

r/aws_s3control_access_grants_instance: Some renaming.

d8e89bc

Access Grants: Restore tests cases that weren't working during beta.

62e9a72

r/aws_s3control_access_grant: Remove hard-coded IAM user from accepta…

5a3bbdc

…nce tests.

r/aws_s3control_access_grants_location: Correct IAM role eventual con…

13c685c

…sistency error handling.

Remove 'testAccAccessGrantConfig_baseDefaultLocation' -- unused.

351a47c

r/aws_s3control_access_grants_location: Retry delete on 'AccessGrants…

89f73de

…LocationNotEmptyError'.

r/aws_s3control_access_grant: Retry create on IAM eventual consistenc…

c3eae80

…y error.

Access Grants: Slightly enhance documentation.

469e50b

ewbankkit added the new-resource Introduces a new resource. label Nov 27, 2023

github-actions bot added the tags Pertains to resource tagging. label Nov 27, 2023

jar-b reviewed Nov 27, 2023

View reviewed changes

internal/service/s3control/access_grant.go Outdated Show resolved Hide resolved

ewbankkit added 3 commits November 27, 2023 10:12

s3control: Standard 2 minute propagation timeout.

4e43635

r/aws_s3control_access_grant: Use standard resource ID seperator (',').

f6725dc

r/aws_s3control_access_grants_location: Use standard resource ID sepe…

bed3a83

…rator (',').

ewbankkit added 4 commits November 27, 2023 10:49

r/aws_s3control_access_grant: Use correct 'CheckDestroy' function in …

2130457

…acceptance tests.

r/aws_s3control_access_grant: Correct create retry handling.

5bcbdca

testAccAccessGrant_disappears: Fix typo.

77ffdc9

Fix golangci-lint 'gomnd'.

2365d9f

jar-b approved these changes Nov 27, 2023

View reviewed changes

ewbankkit merged commit 173cf34 into main Nov 27, 2023
44 checks passed

ewbankkit deleted the f-s3-access-grants branch November 27, 2023 18:14

github-actions bot added this to the v5.27.0 milestone Nov 27, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amazon S3 Access Grants #34564

Amazon S3 Access Grants #34564

ewbankkit commented Nov 27, 2023 •

edited

github-actions bot commented Nov 27, 2023

jar-b left a comment

github-actions bot commented Nov 27, 2023

github-actions bot commented Dec 28, 2023

Amazon S3 Access Grants #34564

Amazon S3 Access Grants #34564

Conversation

ewbankkit commented Nov 27, 2023 • edited

Description

Relations

Output from Acceptance Testing

github-actions bot commented Nov 27, 2023

jar-b left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2023

github-actions bot commented Dec 28, 2023

ewbankkit commented Nov 27, 2023 •

edited