Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_secretsmanager_secret data source doesn't provide CreatedDate #34602

Closed
paul-civitas opened this issue Nov 28, 2023 · 5 comments · Fixed by #35174
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Milestone

Comments

@paul-civitas
Copy link

paul-civitas commented Nov 28, 2023

Description

aws secretsmanager describe-secret returns a CreatedDate which is a useful field for various purposes. In addition aws secretsmanager list-secret-version-ids returns a CreatedDate for the secret versions for a secret.

Affected Resource(s) and/or Data Source(s)

aws_secretsmanager_secret
aws_secretsmanager_secret_version

Potential Terraform Configuration

resource "aws_secretsmanager_secret_version" "argocd_admin_password" {
  secret_id     = aws_secretsmanager_secret.argocd_admin_password.id
  secret_string = random_password.argocd_admin_password.result
}

resource "kubernetes_secret" "argocd_secret" {
  metadata {
    name = "argocd-secret"
    namespace = "argocd"
  }

  data = {
    "admin.password" = random_password.argocd_admin_password.bcrypt_hash
    "admin.passwordMtime" = formatdate("YYYY-MM-DD'T'hh:mm:ssZ", aws_secretsmanager_secret_version.argocd_admin_password.created_date)
    "dex.github.client-id" = data.aws_secretsmanager_secret_version.github_client_id.secret_string
    "dex.github.client-secret" = data.aws_secretsmanager_secret_version.github_client_secret.secret_string
    "server.secretkey" = data.aws_secretsmanager_secret_version.server_secret.secret_string
  }
}

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager/client/get_secret_value.html

References a CreatedDate

Would you like to implement a fix?

None

@paul-civitas paul-civitas added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 28, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/secretsmanager Issues and PRs that pertain to the secretsmanager service. label Nov 28, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 28, 2023
@Siddarthyuvaraj
Copy link
Contributor

I will work on this and submit PR later

@Siddarthyuvaraj
Copy link
Contributor

PR has been raised
#35117

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 8, 2024
@github-actions github-actions bot added this to the v5.33.0 milestone Jan 12, 2024
Copy link

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Projects
None yet
3 participants