Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource] Customer Profile domain and profile resources #34622

Merged

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Nov 29, 2023

Description

To implement the requested Amazon Connect Cases resources requested in #33934 there is a need for Customer Profile domain and profile resources.

@bschaatsbergen and me started working on #34267 but got blocked because we need the aws_customerprofiles_profile resource to create a complete test-suite.

This PR adds the following resources

  • aws_customerprofiles_domain
  • aws_customerprofiles_profile

Relations

Relates #33934
Relates #34267

References

Output from Acceptance Testing

make testacc TESTS=TestAcc  PKG=customerprofiles
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/customerprofiles/... -v -count 1 -parallel 20 -run='TestAcc'  -timeout 360m
=== RUN   TestAccCustomerProfilesDomain_basic
=== PAUSE TestAccCustomerProfilesDomain_basic
=== RUN   TestAccCustomerProfilesDomain_full
=== PAUSE TestAccCustomerProfilesDomain_full
=== RUN   TestAccCustomerProfilesDomain_tags
=== PAUSE TestAccCustomerProfilesDomain_tags
=== RUN   TestAccCustomerProfilesDomain_disappears
=== PAUSE TestAccCustomerProfilesDomain_disappears
=== RUN   TestAccCustomerProfilesProfile_full
=== PAUSE TestAccCustomerProfilesProfile_full
=== RUN   TestAccCustomerProfilesProfile_disappears
=== PAUSE TestAccCustomerProfilesProfile_disappears
=== CONT  TestAccCustomerProfilesDomain_basic
=== CONT  TestAccCustomerProfilesDomain_disappears
=== CONT  TestAccCustomerProfilesDomain_tags
=== CONT  TestAccCustomerProfilesDomain_full
=== CONT  TestAccCustomerProfilesProfile_full
=== CONT  TestAccCustomerProfilesProfile_disappears
--- PASS: TestAccCustomerProfilesDomain_disappears (22.70s)
--- PASS: TestAccCustomerProfilesProfile_disappears (28.04s)
--- PASS: TestAccCustomerProfilesDomain_basic (49.25s)
--- PASS: TestAccCustomerProfilesProfile_full (53.31s)
--- PASS: TestAccCustomerProfilesDomain_tags (66.22s)
--- PASS: TestAccCustomerProfilesDomain_full (101.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/customerprofiles   103.491s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. generators Relates to code generators. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. labels Nov 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 29, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 6, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCustomerProfilesDomain_' PKG=customerprofiles ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/customerprofiles/... -v -count 1 -parallel 2  -run=TestAccCustomerProfilesDomain_ -timeout 360m
=== RUN   TestAccCustomerProfilesDomain_basic
=== PAUSE TestAccCustomerProfilesDomain_basic
=== RUN   TestAccCustomerProfilesDomain_full
=== PAUSE TestAccCustomerProfilesDomain_full
=== RUN   TestAccCustomerProfilesDomain_tags
=== PAUSE TestAccCustomerProfilesDomain_tags
=== RUN   TestAccCustomerProfilesDomain_disappears
=== PAUSE TestAccCustomerProfilesDomain_disappears
=== CONT  TestAccCustomerProfilesDomain_basic
=== CONT  TestAccCustomerProfilesDomain_tags
--- PASS: TestAccCustomerProfilesDomain_basic (33.16s)
=== CONT  TestAccCustomerProfilesDomain_disappears
--- PASS: TestAccCustomerProfilesDomain_tags (44.60s)
=== CONT  TestAccCustomerProfilesDomain_full
--- PASS: TestAccCustomerProfilesDomain_disappears (16.75s)
--- PASS: TestAccCustomerProfilesDomain_full (82.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/customerprofiles	132.963s
% make testacc TESTARGS='-run=TestAccCustomerProfilesProfile_' PKG=customerprofiles ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/customerprofiles/... -v -count 1 -parallel 2  -run=TestAccCustomerProfilesProfile_ -timeout 360m
=== RUN   TestAccCustomerProfilesProfile_full
=== PAUSE TestAccCustomerProfilesProfile_full
=== RUN   TestAccCustomerProfilesProfile_disappears
=== PAUSE TestAccCustomerProfilesProfile_disappears
=== CONT  TestAccCustomerProfilesProfile_full
=== CONT  TestAccCustomerProfilesProfile_disappears
--- PASS: TestAccCustomerProfilesProfile_disappears (21.28s)
--- PASS: TestAccCustomerProfilesProfile_full (36.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/customerprofiles	41.679s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1f58ea8 into hashicorp:main Dec 7, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants