Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_appmesh_virtual_node limits 50 backends even if quota is raised #34658

Closed
nwsparks opened this issue Nov 30, 2023 · 3 comments · Fixed by #34774
Closed

[Bug]: aws_appmesh_virtual_node limits 50 backends even if quota is raised #34658

nwsparks opened this issue Nov 30, 2023 · 3 comments · Fixed by #34774
Labels
bug Addresses a defect in current functionality. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@nwsparks
Copy link
Contributor

nwsparks commented Nov 30, 2023

Terraform Core Version

1.6.0

AWS Provider Version

5.26.0

Affected Resource(s)

aws_appmesh_virtual_node

Expected Behavior

We were able to get AWS to raise the quota on backends via a support case. I confirmed that via the gui and api I can add new backends above 50, but via Terraform I cannot. it seems that even though our quota is 100, the Terraform resource is limiting us to 50. I think this is the relevant code? Could be wrong.

There isn't a good reason I can see to be doing this. Terraform still runs a full plan before throwing an error and if this restriction wasn't here the AWS Api still throws an error based on the quota

image

Actual Behavior

When planning we receive this error and are unable to add additional backends

│ Error: Too many backend blocks
│ 
│   on ../../modules/fargate_service/app-mesh.tf line 18, in resource "aws_appmesh_virtual_node" "node":
│   18:       content {
│ 
│ No more than 50 "backend" blocks are allowed

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

locals {
  backends = toset([
    for v in range(51) : "service${v}.local"
  ])
}

resource "aws_appmesh_mesh" "test" {
  name = "test"
}

resource "aws_appmesh_virtual_node" "test" {
  name      = "test"
  mesh_name = aws_appmesh_mesh.test.name

  spec {
    dynamic "backend" {
      for_each = local.backends
      iterator = service
      content {
        virtual_service {
          virtual_service_name = service.key
        }
      }
    }
  }
}

Steps to Reproduce

im not sure if someone else could reproduce this as you need to go through aws support to get the quota raised.

but you could run the code above and see by reducing the range to 50 it works and 51 it does not.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@nwsparks nwsparks added the bug Addresses a defect in current functionality. label Nov 30, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appmesh Issues and PRs that pertain to the appmesh service. label Nov 30, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 30, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2023
@github-actions github-actions bot added this to the v5.31.0 milestone Dec 13, 2023
Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants