f/aws_dms_endpoint: Adding PostgreSQL settings support

[dirk39]

Description

This PR supports the PostgreSQL settings for the AWS DMS endpoint resource.

Relations

Closes #20395

References

PostgreSQL source settings
PostgreSQL target settings

Output from Acceptance Testing

% make testacc PKG=dms TESTS=TestAccDMSEndpoint_PostgreSQL

TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_PostgreSQL'  -timeout 360m
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_source
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_source
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_target
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_target
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
=== CONT  TestAccDMSEndpoint_PostgreSQL_kmsKey
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_target
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_source
=== CONT  TestAccDMSEndpoint_PostgreSQL_secretID
=== CONT  TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (128.72s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (129.18s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (133.35s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_source (135.78s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_target (136.19s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (145.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        147.419s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEndpoint_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSEndpoint_ -timeout 360m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_Aurora_basic
=== PAUSE TestAccDMSEndpoint_Aurora_basic
=== RUN   TestAccDMSEndpoint_Aurora_secretID
=== PAUSE TestAccDMSEndpoint_Aurora_secretID
=== RUN   TestAccDMSEndpoint_Aurora_update
=== PAUSE TestAccDMSEndpoint_Aurora_update
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_update
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_update
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
=== RUN   TestAccDMSEndpoint_S3_key
=== PAUSE TestAccDMSEndpoint_S3_key
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyId
=== RUN   TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== RUN   TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN   TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN   TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN   TestAccDMSEndpoint_MongoDB_secretID
=== PAUSE TestAccDMSEndpoint_MongoDB_secretID
=== RUN   TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN   TestAccDMSEndpoint_MariaDB_basic
=== PAUSE TestAccDMSEndpoint_MariaDB_basic
=== RUN   TestAccDMSEndpoint_MariaDB_secretID
=== PAUSE TestAccDMSEndpoint_MariaDB_secretID
=== RUN   TestAccDMSEndpoint_MariaDB_update
=== PAUSE TestAccDMSEndpoint_MariaDB_update
=== RUN   TestAccDMSEndpoint_MySQL_basic
=== PAUSE TestAccDMSEndpoint_MySQL_basic
=== RUN   TestAccDMSEndpoint_MySQL_secretID
=== PAUSE TestAccDMSEndpoint_MySQL_secretID
=== RUN   TestAccDMSEndpoint_MySQL_update
=== PAUSE TestAccDMSEndpoint_MySQL_update
=== RUN   TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN   TestAccDMSEndpoint_Oracle_secretID
=== PAUSE TestAccDMSEndpoint_Oracle_secretID
=== RUN   TestAccDMSEndpoint_Oracle_update
=== PAUSE TestAccDMSEndpoint_Oracle_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_source
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_source
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_target
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_target
=== RUN   TestAccDMSEndpoint_SQLServer_basic
=== PAUSE TestAccDMSEndpoint_SQLServer_basic
=== RUN   TestAccDMSEndpoint_SQLServer_secretID
=== PAUSE TestAccDMSEndpoint_SQLServer_secretID
=== RUN   TestAccDMSEndpoint_SQLServer_update
=== PAUSE TestAccDMSEndpoint_SQLServer_update
=== RUN   TestAccDMSEndpoint_babelfish
=== PAUSE TestAccDMSEndpoint_babelfish
=== RUN   TestAccDMSEndpoint_SQLServer_kmsKey
=== PAUSE TestAccDMSEndpoint_SQLServer_kmsKey
=== RUN   TestAccDMSEndpoint_Sybase_basic
=== PAUSE TestAccDMSEndpoint_Sybase_basic
=== RUN   TestAccDMSEndpoint_Sybase_secretID
=== PAUSE TestAccDMSEndpoint_Sybase_secretID
=== RUN   TestAccDMSEndpoint_Sybase_update
=== PAUSE TestAccDMSEndpoint_Sybase_update
=== RUN   TestAccDMSEndpoint_Sybase_kmsKey
=== PAUSE TestAccDMSEndpoint_Sybase_kmsKey
=== RUN   TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN   TestAccDMSEndpoint_db2_basic
=== PAUSE TestAccDMSEndpoint_db2_basic
=== RUN   TestAccDMSEndpoint_db2zOS_basic
=== PAUSE TestAccDMSEndpoint_db2zOS_basic
=== RUN   TestAccDMSEndpoint_azureSQLManagedInstance
=== PAUSE TestAccDMSEndpoint_azureSQLManagedInstance
=== RUN   TestAccDMSEndpoint_db2_secretID
=== PAUSE TestAccDMSEndpoint_db2_secretID
=== RUN   TestAccDMSEndpoint_db2zOS_secretID
=== PAUSE TestAccDMSEndpoint_db2zOS_secretID
=== RUN   TestAccDMSEndpoint_redis
=== PAUSE TestAccDMSEndpoint_redis
=== RUN   TestAccDMSEndpoint_Redshift_basic
=== PAUSE TestAccDMSEndpoint_Redshift_basic
=== RUN   TestAccDMSEndpoint_Redshift_secretID
=== PAUSE TestAccDMSEndpoint_Redshift_secretID
=== RUN   TestAccDMSEndpoint_Redshift_update
=== PAUSE TestAccDMSEndpoint_Redshift_update
=== RUN   TestAccDMSEndpoint_Redshift_kmsKey
=== PAUSE TestAccDMSEndpoint_Redshift_kmsKey
=== RUN   TestAccDMSEndpoint_Redshift_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_Redshift_SSEKMSKeyARN
=== RUN   TestAccDMSEndpoint_Redshift_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_Redshift_SSEKMSKeyId
=== RUN   TestAccDMSEndpoint_pauseReplicationTasks
=== PAUSE TestAccDMSEndpoint_pauseReplicationTasks
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_pauseReplicationTasks
=== CONT  TestAccDMSEndpoint_Oracle_basic
--- PASS: TestAccDMSEndpoint_Oracle_basic (34.25s)
=== CONT  TestAccDMSEndpoint_MySQL_update
--- PASS: TestAccDMSEndpoint_basic (46.31s)
=== CONT  TestAccDMSEndpoint_MySQL_secretID
--- PASS: TestAccDMSEndpoint_MySQL_secretID (28.97s)
=== CONT  TestAccDMSEndpoint_MySQL_basic
--- PASS: TestAccDMSEndpoint_MySQL_update (44.41s)
=== CONT  TestAccDMSEndpoint_MariaDB_update
--- PASS: TestAccDMSEndpoint_MySQL_basic (32.80s)
=== CONT  TestAccDMSEndpoint_MariaDB_secretID
--- PASS: TestAccDMSEndpoint_MariaDB_update (34.44s)
=== CONT  TestAccDMSEndpoint_MariaDB_basic
--- PASS: TestAccDMSEndpoint_MariaDB_basic (20.69s)
=== CONT  TestAccDMSEndpoint_MongoDB_update
--- PASS: TestAccDMSEndpoint_MariaDB_secretID (28.12s)
=== CONT  TestAccDMSEndpoint_MongoDB_secretID
--- PASS: TestAccDMSEndpoint_MongoDB_secretID (29.07s)
=== CONT  TestAccDMSEndpoint_MongoDB_basic
--- PASS: TestAccDMSEndpoint_MongoDB_update (40.97s)
=== CONT  TestAccDMSEndpoint_kinesis
--- PASS: TestAccDMSEndpoint_MongoDB_basic (32.94s)
=== CONT  TestAccDMSEndpoint_kafka
--- PASS: TestAccDMSEndpoint_kafka (43.60s)
=== CONT  TestAccDMSEndpoint_Sybase_update
--- PASS: TestAccDMSEndpoint_kinesis (72.04s)
=== CONT  TestAccDMSEndpoint_db2zOS_secretID
--- PASS: TestAccDMSEndpoint_Sybase_update (37.74s)
=== CONT  TestAccDMSEndpoint_redis
--- PASS: TestAccDMSEndpoint_db2zOS_secretID (35.57s)
=== CONT  TestAccDMSEndpoint_Redshift_SSEKMSKeyId
--- PASS: TestAccDMSEndpoint_redis (42.81s)
=== CONT  TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (40.68s)
=== CONT  TestAccDMSEndpoint_Redshift_SSEKMSKeyARN
--- PASS: TestAccDMSEndpoint_Redshift_SSEKMSKeyId (177.08s)
=== CONT  TestAccDMSEndpoint_db2_secretID
--- PASS: TestAccDMSEndpoint_db2_secretID (29.31s)
=== CONT  TestAccDMSEndpoint_Redshift_kmsKey
--- PASS: TestAccDMSEndpoint_Redshift_SSEKMSKeyARN (221.18s)
=== CONT  TestAccDMSEndpoint_docDB
--- PASS: TestAccDMSEndpoint_docDB (36.22s)
=== CONT  TestAccDMSEndpoint_Redshift_update
--- PASS: TestAccDMSEndpoint_Redshift_kmsKey (201.44s)
=== CONT  TestAccDMSEndpoint_Sybase_kmsKey
--- PASS: TestAccDMSEndpoint_Sybase_kmsKey (29.87s)
=== CONT  TestAccDMSEndpoint_db2_basic
--- PASS: TestAccDMSEndpoint_db2_basic (50.23s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_Redshift_update (209.14s)
=== CONT  TestAccDMSEndpoint_db2zOS_basic
--- PASS: TestAccDMSEndpoint_S3_basic (67.25s)
=== CONT  TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_db2zOS_basic (49.00s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_target
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (43.63s)
=== CONT  TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_target (21.62s)
=== CONT  TestAccDMSEndpoint_Sybase_secretID
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (41.80s)
=== CONT  TestAccDMSEndpoint_Sybase_basic
--- PASS: TestAccDMSEndpoint_Sybase_secretID (34.22s)
=== CONT  TestAccDMSEndpoint_azureSQLManagedInstance
=== NAME  TestAccDMSEndpoint_pauseReplicationTasks
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: stopping DMS Replication Task (tf-acc-test-302249835080674271): InvalidResourceStateFault: Replication Task: arn:aws:dms:us-west-2:123456789012:task:HZURIDIGSHVYSJRTQTVQEDUESUL4WAAK2S72KQY is currently not running.
        
--- FAIL: TestAccDMSEndpoint_pauseReplicationTasks (948.74s)
=== CONT  TestAccDMSEndpoint_Aurora_secretID
--- PASS: TestAccDMSEndpoint_Sybase_basic (29.09s)
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
--- PASS: TestAccDMSEndpoint_azureSQLManagedInstance (40.42s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_update
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (33.75s)
=== CONT  TestAccDMSEndpoint_dynamoDB
--- PASS: TestAccDMSEndpoint_Aurora_secretID (37.95s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_update (41.93s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_basic
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_secretID (30.93s)
=== CONT  TestAccDMSEndpoint_Aurora_update
--- PASS: TestAccDMSEndpoint_dynamoDB (54.86s)
=== CONT  TestAccDMSEndpoint_SQLServer_update
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_basic (37.73s)
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyId
--- PASS: TestAccDMSEndpoint_Aurora_update (44.60s)
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyARN
--- PASS: TestAccDMSEndpoint_SQLServer_update (42.11s)
=== CONT  TestAccDMSEndpoint_babelfish
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyId (38.42s)
=== CONT  TestAccDMSEndpoint_SQLServer_kmsKey
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyARN (46.88s)
=== CONT  TestAccDMSEndpoint_SQLServer_secretID
--- PASS: TestAccDMSEndpoint_SQLServer_kmsKey (38.84s)
=== CONT  TestAccDMSEndpoint_SQLServer_basic
--- PASS: TestAccDMSEndpoint_babelfish (57.81s)
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_SQLServer_secretID (43.07s)
=== CONT  TestAccDMSEndpoint_S3_key
--- PASS: TestAccDMSEndpoint_SQLServer_basic (25.42s)
=== CONT  TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
--- PASS: TestAccDMSEndpoint_S3_key (9.62s)
=== CONT  TestAccDMSEndpoint_Redshift_secretID
--- PASS: TestAccDMSEndpoint_Redshift_secretID (29.88s)
=== CONT  TestAccDMSEndpoint_Redshift_basic
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (89.26s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet (77.71s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_source
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_source (24.54s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_kmsKey
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (30.60s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (33.33s)
=== CONT  TestAccDMSEndpoint_Aurora_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (40.16s)
=== CONT  TestAccDMSEndpoint_Oracle_update
--- PASS: TestAccDMSEndpoint_Aurora_basic (34.51s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_Oracle_update (49.82s)
=== CONT  TestAccDMSEndpoint_Oracle_secretID
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (34.78s)
--- PASS: TestAccDMSEndpoint_Oracle_secretID (27.99s)
--- PASS: TestAccDMSEndpoint_Redshift_basic (310.74s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1508.061s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

% make testacc TESTARGS='-run=TestAccDMSEndpointDataSource_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSEndpointDataSource_ -timeout 360m
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpointDataSource_basic
--- PASS: TestAccDMSEndpointDataSource_basic (27.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	33.846s

[ewbankkit]

@dirk39 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.