Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appconfig_deployment: add kms_key_identifier attribute #34739

Merged
merged 11 commits into from
Dec 5, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Dec 5, 2023

Description

Relations

Closes #34701
Closes #31999

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccAppConfigDeployment_kms" PKG=appconfig

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 20  -run=TestAccAppConfigDeployment_kms -timeout 360m
=== RUN   TestAccAppConfigDeployment_kms
=== PAUSE TestAccAppConfigDeployment_kms
=== CONT  TestAccAppConfigDeployment_kms
--- PASS: TestAccAppConfigDeployment_kms (124.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	127.583s

Copy link

github-actions bot commented Dec 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appconfig Issues and PRs that pertain to the appconfig service. labels Dec 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 5, 2023
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 5, 2023
@johnsonaj johnsonaj marked this pull request as ready for review December 5, 2023 18:42
@johnsonaj johnsonaj merged commit 10d4a2f into main Dec 5, 2023
81 checks passed
@johnsonaj johnsonaj deleted the app-config-deploy-kms branch December 5, 2023 19:17
@github-actions github-actions bot added this to the v5.30.0 milestone Dec 5, 2023
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appconfig Issues and PRs that pertain to the appconfig service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update aws_appconfig_deployment to support KmsKeyIdentifier argument
2 participants