Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolver_endpoint_type argument to aws_route53_resolver_endpoint #34798

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

alexknez
Copy link
Contributor

@alexknez alexknez commented Dec 7, 2023

Description

aws_route53_resolver_endpoint: Adds a new attribute resolver_endpoint_type.

Relations

Closes #33476

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ResolverEndpoint_ PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpoint_'  -timeout 360m
=== RUN   TestAccRoute53ResolverEndpoint_serial
=== PAUSE TestAccRoute53ResolverEndpoint_serial
=== CONT  TestAccRoute53ResolverEndpoint_serial
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/basic
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/disappears
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/tags
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/updateOutbound
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/updateResolverEndpointType
=== RUN   TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/ipv6
--- PASS: TestAccRoute53ResolverEndpoint_serial (1022.45s)
    --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint (1022.45s)
        --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/basic (117.90s)
        --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/disappears (112.51s)
        --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/tags (152.38s)
        --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/updateOutbound (392.72s)
        --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/updateResolverEndpointType (141.06s)
        --- PASS: TestAccRoute53ResolverEndpoint_serial/ResolverEndpoint/ipv6 (105.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	1025.631s
% make testacc TESTS=TestAccRoute53ResolverEndpointDataSource_ PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpointDataSource_'  -timeout 360m
=== RUN   TestAccRoute53ResolverEndpointDataSource_basic
=== PAUSE TestAccRoute53ResolverEndpointDataSource_basic
=== RUN   TestAccRoute53ResolverEndpointDataSource_filter
=== PAUSE TestAccRoute53ResolverEndpointDataSource_filter
=== CONT  TestAccRoute53ResolverEndpointDataSource_basic
=== CONT  TestAccRoute53ResolverEndpointDataSource_filter
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (113.46s)
--- PASS: TestAccRoute53ResolverEndpointDataSource_filter (256.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	260.156s

Copy link

github-actions bot commented Dec 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/L Managed by automation to categorize the size of a PR. labels Dec 7, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 7, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @alexknez 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@alexknez alexknez changed the title Adds a new attribute resolver_endpoint_type for aws_route53_resolver_endpoint Add resolver_endpoint_type for aws_route53_resolver_endpoint Dec 8, 2023
@alexknez alexknez changed the title Add resolver_endpoint_type for aws_route53_resolver_endpoint Add resolver_endpoint_type argument to aws_route53_resolver_endpoint Dec 8, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2023
# Conflicts:
#	internal/service/route53resolver/endpoint.go
#	website/docs/d/route53_resolver_endpoint.html.markdown
#	website/docs/r/route53_resolver_endpoint.html.markdown
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverEndpoint_\|TestAccRoute53ResolverEndpointDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverEndpoint_\|TestAccRoute53ResolverEndpointDataSource_ -timeout 360m
=== RUN   TestAccRoute53ResolverEndpointDataSource_basic
=== PAUSE TestAccRoute53ResolverEndpointDataSource_basic
=== RUN   TestAccRoute53ResolverEndpointDataSource_filter
=== PAUSE TestAccRoute53ResolverEndpointDataSource_filter
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== RUN   TestAccRoute53ResolverEndpoint_resolverEndpointType
=== PAUSE TestAccRoute53ResolverEndpoint_resolverEndpointType
=== CONT  TestAccRoute53ResolverEndpointDataSource_basic
=== CONT  TestAccRoute53ResolverEndpoint_tags
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (87.80s)
=== CONT  TestAccRoute53ResolverEndpoint_basic
--- PASS: TestAccRoute53ResolverEndpoint_tags (121.38s)
=== CONT  TestAccRoute53ResolverEndpoint_disappears
--- PASS: TestAccRoute53ResolverEndpoint_basic (98.97s)
=== CONT  TestAccRoute53ResolverEndpoint_resolverEndpointType
--- PASS: TestAccRoute53ResolverEndpoint_disappears (95.64s)
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverEndpoint_resolverEndpointType (134.68s)
=== CONT  TestAccRoute53ResolverEndpointDataSource_filter
--- PASS: TestAccRoute53ResolverEndpointDataSource_filter (218.68s)
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (365.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	588.160s

@ewbankkit
Copy link
Contributor

@alexknez Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0841790 into hashicorp:main Jan 3, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 3, 2024
@alexknez alexknez deleted the feature/resolver_endpoint_type branch January 3, 2024 18:29
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_route53_resolver_endpoint does not support DualStack deployment
3 participants