r/aws_cloudwatch_log_group: Remove default value (`STANDARD`) for `log_group_class` argument and mark as Computed #34812

ewbankkit · 2023-12-08T15:52:05Z

Description

Change aws_cloudwatch_log_group.log_group_class to Computed as it's not (yet) supported in AWS GovCloud (US) or AWS China.

Relations

Closes #34810.
Closes #34809.

Output from Acceptance Testing

AWS Commercial

% make testacc TESTARGS='-run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_' PKG=logs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_ -timeout 360m
=== RUN   TestAccLogsGroupDataSource_basic
=== PAUSE TestAccLogsGroupDataSource_basic
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN   TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN   TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN   TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN   TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN   TestAccLogsGroup_logGroupClass
=== PAUSE TestAccLogsGroup_logGroupClass
=== RUN   TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN   TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== CONT  TestAccLogsGroupDataSource_basic
=== CONT  TestAccLogsGroup_kmsKey
=== CONT  TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroupDataSource_basic (15.62s)
=== CONT  TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_namePrefix (25.85s)
=== CONT  TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_nameGenerate (24.97s)
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_kmsKey (62.33s)
=== CONT  TestAccLogsGroup_logGroupClass
--- PASS: TestAccLogsGroup_tags (54.93s)
=== CONT  TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_multiple (18.86s)
=== CONT  TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_logGroupClass (19.89s)
=== CONT  TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_skipDestroy (21.16s)
=== CONT  TestAccLogsGroup_basic
--- PASS: TestAccLogsGroup_disappears (23.18s)
--- PASS: TestAccLogsGroup_basic (24.58s)
--- PASS: TestAccLogsGroup_retentionPolicy (50.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	138.605s

AWS GovCloud (US)

% make testacc TESTARGS='-run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_' PKG=logs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_ -timeout 360m
=== RUN   TestAccLogsGroupDataSource_basic
=== PAUSE TestAccLogsGroupDataSource_basic
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN   TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN   TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN   TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN   TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN   TestAccLogsGroup_logGroupClass
=== PAUSE TestAccLogsGroup_logGroupClass
=== RUN   TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN   TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== CONT  TestAccLogsGroupDataSource_basic
=== CONT  TestAccLogsGroup_kmsKey
=== CONT  TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroupDataSource_basic (18.43s)
=== CONT  TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_namePrefix (22.45s)
=== CONT  TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_disappears (18.45s)
=== CONT  TestAccLogsGroup_basic
--- PASS: TestAccLogsGroup_nameGenerate (21.73s)
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_kmsKey (57.87s)
=== CONT  TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_basic (22.51s)
=== CONT  TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_multiple (19.95s)
=== CONT  TestAccLogsGroup_logGroupClass
    acctest.go:943: skipping tests; current partition (aws-us-gov) does not equal aws
--- SKIP: TestAccLogsGroup_logGroupClass (0.00s)
=== CONT  TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_skipDestroy (24.48s)
--- PASS: TestAccLogsGroup_retentionPolicy (57.80s)
--- PASS: TestAccLogsGroup_tags (56.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	126.358s

…g_group_class` argument and mark as Computed. This fixes `InvalidParameterException: Only Standard log class is supported` errors in AWS Regions other than AWS Commercial.

github-actions · 2023-12-08T15:52:22Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

jar-b

LGTM 🎉

% make testacc TESTARGS='-run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_' PKG=logs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 20  -run=TestAccLogsGroup_\|TestAccLogsGroupDataSource_ -timeout 360m

--- PASS: TestAccLogsGroup_skipDestroy (53.28s)
--- PASS: TestAccLogsGroup_logGroupClass (55.78s)
--- PASS: TestAccLogsGroup_disappears (57.11s)
--- PASS: TestAccLogsGroup_basic (59.83s)
--- PASS: TestAccLogsGroup_nameGenerate (60.35s)
--- PASS: TestAccLogsGroup_namePrefix (60.49s)
--- PASS: TestAccLogsGroup_multiple (61.68s)
--- PASS: TestAccLogsGroupDataSource_basic (71.37s)
--- PASS: TestAccLogsGroup_tags (96.51s)
--- PASS: TestAccLogsGroup_retentionPolicy (96.67s)
--- PASS: TestAccLogsGroup_kmsKey (122.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/logs       126.177s

raisullip · 2023-12-09T20:57:31Z

👍

jlmolinyawe · 2023-12-11T15:24:20Z

👍🏽

An issue was discovered in the AWS terraform provider v5.30.0: hashicorp/terraform-provider-aws#34812 This reverts commit 0336066.

gabrielmattern · 2023-12-11T19:03:29Z

We really need this fixed ASAP. 👍

karolytanczos-govcio · 2023-12-11T20:17:13Z

Yesterday and today we tried to deploy an ECS service on GovCloud and it failed with the following message:
- InvalidParameterException: Only Standard log class is supported.

Prior to fail creating the service the following message was printed about the CloudWatch:

# module.xxx-xxx-xxx.aws_cloudwatch_log_group.log-group will be created
  + resource "aws_cloudwatch_log_group" "log-group" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + log_group_class   = "STANDARD"
      + name              = "/ecs/xxxx-xxxx-xxxx"
      + name_prefix       = (known after apply)
      + retention_in_days = 0
      + skip_destroy      = false

I'm confused, should it be Standard or Computed?

An issue was discovered in the AWS terraform provider v5.30.0: hashicorp/terraform-provider-aws#34812 This reverts commit 0336066.

michael-miara · 2023-12-14T19:21:37Z

Yesterday and today we tried to deploy an ECS service on GovCloud and it failed with the following message: - InvalidParameterException: Only Standard log class is supported.

Prior to fail creating the service the following message was printed about the CloudWatch:
# module.xxx-xxx-xxx.aws_cloudwatch_log_group.log-group will be created
  + resource "aws_cloudwatch_log_group" "log-group" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + log_group_class   = "STANDARD"
      + name              = "/ecs/xxxx-xxxx-xxxx"
      + name_prefix       = (known after apply)
      + retention_in_days = 0
      + skip_destroy      = false
I'm confused, should it be Standard or Computed?

i am still seeing this as well

karolytanczos-govcio · 2023-12-14T22:13:56Z

Yesterday and today we tried to deploy an ECS service on GovCloud and it failed with the following message: - InvalidParameterException: Only Standard log class is supported.
Prior to fail creating the service the following message was printed about the CloudWatch:
# module.xxx-xxx-xxx.aws_cloudwatch_log_group.log-group will be created
  + resource "aws_cloudwatch_log_group" "log-group" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + log_group_class   = "STANDARD"
      + name              = "/ecs/xxxx-xxxx-xxxx"
      + name_prefix       = (known after apply)
      + retention_in_days = 0
      + skip_destroy      = false
I'm confused, should it be Standard or Computed?
i am still seeing this as well

We implemented a workaround for this bug. We hardcoded the Terraform version under the required_provider section. The last known stable version was 5.26.0:

  required_providers {
    aws = {
      source = "hashicorp/aws"
      version = "5.26.0"
    }

Version 5.30.0 is still failing.

github-actions · 2023-12-15T02:37:50Z

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-01-15T02:10:34Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit added 2 commits December 8, 2023 10:44

Add CHANGELOG entry.

d86e9fc

r/aws_cloudwatch_log_group: Remove default value (STANDARD) for `lo…

2aa69cd

…g_group_class` argument and mark as Computed. This fixes `InvalidParameterException: Only Standard log class is supported` errors in AWS Regions other than AWS Commercial.

github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Dec 8, 2023

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 8, 2023

Correct CHANGELOG entry file name.

9425dad

d/aws_cloudwatch_log_group: Add log_group_class attribute.

ec7025f

ewbankkit force-pushed the b-aws_cloudwatch_log_group.log_group_class branch from 547ade5 to ec7025f Compare December 8, 2023 16:04

github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 8, 2023

jar-b approved these changes Dec 8, 2023

View reviewed changes

ewbankkit merged commit 1532419 into main Dec 8, 2023
60 of 62 checks passed

ewbankkit deleted the b-aws_cloudwatch_log_group.log_group_class branch December 8, 2023 18:13

github-actions bot added this to the v5.31.0 milestone Dec 8, 2023

github-actions bot pushed a commit that referenced this pull request Dec 8, 2023

Update CHANGELOG.md for #34812

8dc5194

blgm added a commit to cloudfoundry/csb-brokerpak-aws that referenced this pull request Dec 11, 2023

revert: "build(deps): bump terraform providers"

67e49c3

An issue was discovered in the AWS terraform provider v5.30.0: hashicorp/terraform-provider-aws#34812 This reverts commit 0336066.

blgm mentioned this pull request Dec 11, 2023

revert: "build(deps): bump terraform providers" cloudfoundry/csb-brokerpak-aws#1402

Merged

ewbankkit mentioned this pull request Dec 14, 2023

[Bug]: aws_cloudwatch_log_group new property log_group_class forces replacement #34924

Closed

github-actions bot removed the bug Addresses a defect in current functionality. label Dec 15, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024

justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_cloudwatch_log_group: Remove default value (`STANDARD`) for `log_group_class` argument and mark as Computed #34812

r/aws_cloudwatch_log_group: Remove default value (`STANDARD`) for `log_group_class` argument and mark as Computed #34812

ewbankkit commented Dec 8, 2023 •

edited

Loading

github-actions bot commented Dec 8, 2023

jar-b left a comment

raisullip commented Dec 9, 2023

jlmolinyawe commented Dec 11, 2023

gabrielmattern commented Dec 11, 2023 •

edited

Loading

karolytanczos-govcio commented Dec 11, 2023

michael-miara commented Dec 14, 2023

karolytanczos-govcio commented Dec 14, 2023

github-actions bot commented Dec 15, 2023

github-actions bot commented Jan 15, 2024

r/aws_cloudwatch_log_group: Remove default value (STANDARD) for log_group_class argument and mark as Computed #34812

r/aws_cloudwatch_log_group: Remove default value (STANDARD) for log_group_class argument and mark as Computed #34812

Conversation

ewbankkit commented Dec 8, 2023 • edited Loading

Description

Relations

Output from Acceptance Testing

AWS Commercial

AWS GovCloud (US)

github-actions bot commented Dec 8, 2023

Community Note

jar-b left a comment

Choose a reason for hiding this comment

raisullip commented Dec 9, 2023

jlmolinyawe commented Dec 11, 2023

gabrielmattern commented Dec 11, 2023 • edited Loading

karolytanczos-govcio commented Dec 11, 2023

michael-miara commented Dec 14, 2023

karolytanczos-govcio commented Dec 14, 2023

github-actions bot commented Dec 15, 2023

github-actions bot commented Jan 15, 2024

r/aws_cloudwatch_log_group: Remove default value (`STANDARD`) for `log_group_class` argument and mark as Computed #34812

r/aws_cloudwatch_log_group: Remove default value (`STANDARD`) for `log_group_class` argument and mark as Computed #34812

ewbankkit commented Dec 8, 2023 •

edited

Loading

gabrielmattern commented Dec 11, 2023 •

edited

Loading