feat(r/aws_autoscaling_group): add max_healthy_percentage arg

[rafaelleonardocruz]

Description

The aws_autoscaling_group resource doesn't supports the attribute max_healthy_percentage at instance_refresh.preferences, which restricts the sensibility of instance-refresh operations.

Relations

References

• (StartInstanceRefresh API spec) describes the expected behaviour for this field.

Output from Acceptance Testing

make testacc TESTS=TestAccAutoScalingGroup_InstanceRefresh PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroup_InstanceRefresh'  -timeout 360m
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_autoRollback
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (139.94s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_autoRollback (148.68s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (157.52s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (218.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        220.709s
...

Comments:

• My organization policy doesn't allow me to grant write access to external users in this PR

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @rafaelleonardocruz 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[github-actions]

Welcome @rafaelleonardocruz 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[andrewradamis-paay]

Comments:

• The test case TestAccAutoScalingGroup_InstanceRefresh_autoRollback was failing for me BEFORE my editions, I didn't figure out why.

@rafaelleonardocruz I think your the IAM role you are using is blocking Launch Templates. I'd guess a condition key for autoscaling:UpdateAutoScalingGroup. All tests pass for me:

TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingGroup_InstanceRefresh'  -timeout 360m
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== RUN   TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_basic
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_start
=== CONT  TestAccAutoScalingGroup_InstanceRefresh_autoRollback
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (139.94s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_autoRollback (148.68s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (157.52s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (218.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        220.709s

Would love to see this feature added, it will save me dozens of seconds a month. Thanks!

[ewbankkit]

This work has been rolled into #34792.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.