Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ssoadmin_application: send application_url only when set #34967

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Dec 18, 2023

Description

This fix prevents the portal_options.sign_in_options.application_url argument from being sent on all create and update requests. Now, a value will only be sent when set to a non-nil value.

Relations

Closes #34836

References

Output from Acceptance Testing

% make testacc PKG=ssoadmin TESTS=TestAccSSOAdminApplication_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 20 -run='TestAccSSOAdminApplication_'  -timeout 360m

--- PASS: TestAccSSOAdminApplication_disappears (11.18s)
--- PASS: TestAccSSOAdminApplication_basic (13.04s)
--- PASS: TestAccSSOAdminApplication_portalOptions (18.73s)
--- PASS: TestAccSSOAdminApplication_description (19.34s)
--- PASS: TestAccSSOAdminApplication_tags (25.20s)
--- PASS: TestAccSSOAdminApplication_status (25.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   28.411s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. labels Dec 18, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 18, 2023
This fix prevents the portal_options.sign_in_options.application_url argument from being sent on all create and update requests. Now, a value will only be sent when set to a non-nil value.
@jar-b jar-b force-pushed the b-ssoadmin_application-sign_in_options branch from 00de654 to 7d4f240 Compare December 18, 2023 14:53
@jar-b jar-b merged commit 20e5b7f into main Dec 19, 2023
34 checks passed
@jar-b jar-b deleted the b-ssoadmin_application-sign_in_options branch December 19, 2023 15:22
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 19, 2023
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_ssoadmin_application fails due to missing app url
2 participants