fix!: require cloud9 image_id to align with AWS breaking change

[JonZeolla]

Description

The goal of this PR was to add support for Cloud9 and Amazon Linux 2023, which was added on Dec 18, 2023.

In doing so, I noticed a few things, primarily that there was an upstream breaking change and this fixes cloud9_environment_ec2 resource provisioning:

1. imageId changed to required as of December 4, 2023 per the docs. This PR includes that BREAKING change as well.
2. imageId is not returned by any of the Cloud9 API endpoints, so we need to exclude it from state importing.
3. On January 22, 2024, Amazon Linux (AL1) will be removed from the list of available image IDs for Cloud9, per the same docs. I didn't make that change in this PR, since it hasn't happened yet.

Relations

Closes #34995

Output from Acceptance Testing

➜ make testacc TESTS=TestAccCloud9EnvironmentEC2 PKG=cloud9
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloud9/... -v -count 1 -parallel 20 -run='TestAccCloud9EnvironmentEC2'  -timeout 360m
=== RUN   TestAccCloud9EnvironmentEC2_basic
=== PAUSE TestAccCloud9EnvironmentEC2_basic
=== RUN   TestAccCloud9EnvironmentEC2_allFields
=== PAUSE TestAccCloud9EnvironmentEC2_allFields
=== RUN   TestAccCloud9EnvironmentEC2_tags
=== PAUSE TestAccCloud9EnvironmentEC2_tags
=== RUN   TestAccCloud9EnvironmentEC2_disappears
=== PAUSE TestAccCloud9EnvironmentEC2_disappears
=== CONT  TestAccCloud9EnvironmentEC2_basic
=== CONT  TestAccCloud9EnvironmentEC2_tags
=== CONT  TestAccCloud9EnvironmentEC2_allFields
=== CONT  TestAccCloud9EnvironmentEC2_disappears
--- PASS: TestAccCloud9EnvironmentEC2_disappears (159.70s)
--- PASS: TestAccCloud9EnvironmentEC2_basic (160.50s)
--- PASS: TestAccCloud9EnvironmentEC2_allFields (187.30s)
--- PASS: TestAccCloud9EnvironmentEC2_tags (194.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloud9     197.170s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @JonZeolla 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloud9EnvironmentEC2_' PKG=cloud9 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloud9/... -v -count 1 -parallel 2  -run=TestAccCloud9EnvironmentEC2_ -timeout 360m
=== RUN   TestAccCloud9EnvironmentEC2_basic
=== PAUSE TestAccCloud9EnvironmentEC2_basic
=== RUN   TestAccCloud9EnvironmentEC2_allFields
=== PAUSE TestAccCloud9EnvironmentEC2_allFields
=== RUN   TestAccCloud9EnvironmentEC2_tags
=== PAUSE TestAccCloud9EnvironmentEC2_tags
=== RUN   TestAccCloud9EnvironmentEC2_disappears
=== PAUSE TestAccCloud9EnvironmentEC2_disappears
=== CONT  TestAccCloud9EnvironmentEC2_basic
=== CONT  TestAccCloud9EnvironmentEC2_tags
--- PASS: TestAccCloud9EnvironmentEC2_basic (135.74s)
=== CONT  TestAccCloud9EnvironmentEC2_disappears
--- PASS: TestAccCloud9EnvironmentEC2_tags (165.17s)
=== CONT  TestAccCloud9EnvironmentEC2_allFields
--- PASS: TestAccCloud9EnvironmentEC2_allFields (162.25s)
--- PASS: TestAccCloud9EnvironmentEC2_disappears (173.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloud9	317.057s

[ewbankkit]

@JonZeolla Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.