-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KMS key ARN in AMP Workspace resource #35062
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Add AWS KMS Customer Managed Keys (CMK) support
4415380
to
8d82bf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAMPWorkspaceDataSource_\|TestAccAMPWorkspace_' PKG=amp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 2 -run=TestAccAMPWorkspaceDataSource_\|TestAccAMPWorkspace_ -timeout 360m
=== RUN TestAccAMPWorkspaceDataSource_basic
--- PASS: TestAccAMPWorkspaceDataSource_basic (17.29s)
=== RUN TestAccAMPWorkspace_basic
=== PAUSE TestAccAMPWorkspace_basic
=== RUN TestAccAMPWorkspace_disappears
=== PAUSE TestAccAMPWorkspace_disappears
=== RUN TestAccAMPWorkspace_kms
=== PAUSE TestAccAMPWorkspace_kms
=== RUN TestAccAMPWorkspace_tags
=== PAUSE TestAccAMPWorkspace_tags
=== RUN TestAccAMPWorkspace_alias
=== PAUSE TestAccAMPWorkspace_alias
=== RUN TestAccAMPWorkspace_loggingConfiguration
=== PAUSE TestAccAMPWorkspace_loggingConfiguration
=== CONT TestAccAMPWorkspace_basic
=== CONT TestAccAMPWorkspace_tags
--- PASS: TestAccAMPWorkspace_basic (21.60s)
=== CONT TestAccAMPWorkspace_loggingConfiguration
--- PASS: TestAccAMPWorkspace_tags (47.51s)
=== CONT TestAccAMPWorkspace_kms
--- PASS: TestAccAMPWorkspace_kms (20.71s)
=== CONT TestAccAMPWorkspace_disappears
--- PASS: TestAccAMPWorkspace_disappears (17.81s)
=== CONT TestAccAMPWorkspace_alias
--- PASS: TestAccAMPWorkspace_loggingConfiguration (66.63s)
--- PASS: TestAccAMPWorkspace_alias (55.80s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 164.957s
@obounaim Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Implements AWS Key Management Service encryption for Amazon Managed Service for Prometheus Workspace
Relations
Closes #35048
References
Encryption at rest
Output from Acceptance Testing