f-aws_networkfirewall_firewall_policy-tlsinspectionpolicyarn-add

[bsaurusrex]

Description

Relations

Closes #35078.
Relates #31154.

References

Output from Acceptance Testing

make testacc TESTS=TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationArn PKG=networkfirewall P=19
make testacc TESTS="TestAccNetworkFirewallFirewallPolicyDataSource_*" PKG=networkfirewall P=1

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bsaurusrex]

make testacc TESTS="TestAccNetworkFirewallFirewallPolicyDataSource_" PKG=networkfirewall P=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 1 -run='TestAccNetworkFirewallFirewallPolicyDataSource_' -timeout 360m
=== RUN TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== RUN TestAccNetworkFirewallFirewallPolicyDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_name
=== RUN TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
=== RUN TestAccNetworkFirewallFirewallPolicyDataSource_withOverriddenManagedRuleGroup
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_withOverriddenManagedRuleGroup
=== CONT TestAccNetworkFirewallFirewallPolicyDataSource_arn
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_arn (139.91s)
=== CONT TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN (137.97s)
=== CONT TestAccNetworkFirewallFirewallPolicyDataSource_withOverriddenManagedRuleGroup
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_withOverriddenManagedRuleGroup (128.26s)
=== CONT TestAccNetworkFirewallFirewallPolicyDataSource_name
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_name (138.80s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 548.279s

[bsaurusrex]

make testacc TESTS=TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationArn PKG=networkfirewall P=19
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 19 -run='TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationArn' -timeout 360m
=== RUN TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationArn
--- PASS: TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationArn (159.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 163.334s

[github-actions]

Welcome @bsaurusrex 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallPolicyDataSource_arn\|TestAccNetworkFirewallFirewallPolicyDataSource_name\|TestAccNetworkFirewallFirewallPolicy_basic\|TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationARN' PKG=networkfirewall ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 2  -run=TestAccNetworkFirewallFirewallPolicyDataSource_arn\|TestAccNetworkFirewallFirewallPolicyDataSource_name\|TestAccNetworkFirewallFirewallPolicy_basic\|TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationARN -timeout 360m
=== RUN   TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== RUN   TestAccNetworkFirewallFirewallPolicyDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_name
=== RUN   TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
=== RUN   TestAccNetworkFirewallFirewallPolicy_basic
=== PAUSE TestAccNetworkFirewallFirewallPolicy_basic
=== RUN   TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationARN
    acctest.go:2479: Environment variable AWS_NETWORKFIREWALL_TLS_INSPECTION_CONFIGURATION_ARN_1 is not set, skipping test
--- SKIP: TestAccNetworkFirewallFirewallPolicy_tlsInspectionConfigurationARN (0.00s)
=== CONT  TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== CONT  TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_arn (141.27s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN (142.52s)
=== CONT  TestAccNetworkFirewallFirewallPolicyDataSource_name
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_name (142.75s)
--- PASS: TestAccNetworkFirewallFirewallPolicy_basic (166.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	321.944s

[ewbankkit]

@bsaurusrex Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.