Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/tranfer_server - Add security_policy_name enum values #35129

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Jan 3, 2024

Description

Extra post-quantum key options for the security_policy_name argument

Relations

Closes #35122

References

https://docs.aws.amazon.com/transfer/latest/userguide/security-policies.html#pq-policies

Output from Acceptance Testing

% make testacc TESTS=TestAccServer_securityPolicy PKG=transfer
# I changed the test name (TestAccServer instead of testAccServer) temporarily to run this test separately 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccServer_securityPolicy'  -timeout 360m
=== RUN   TestAccServer_securityPolicy
--- PASS: TestAccServer_securityPolicy (233.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   235.388s

@aristosvo aristosvo changed the title r/tranfer_server - Add security_policy_name enum values [WIP] r/tranfer_server - Add security_policy_name enum values Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. labels Jan 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2024
@aristosvo aristosvo changed the title [WIP] r/tranfer_server - Add security_policy_name enum values r/tranfer_server - Add security_policy_name enum values Jan 3, 2024
@aristosvo aristosvo marked this pull request as ready for review January 3, 2024 21:47
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^SecurityPolicy$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/^SecurityPolicy$ -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
--- PASS: TestAccTransfer_serial (237.36s)
    --- PASS: TestAccTransfer_serial/Server (237.36s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (237.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	243.229s

@ewbankkit
Copy link
Contributor

@aristosvo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit df95181 into hashicorp:main Jan 10, 2024
62 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 10, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow post quantum security policies for AWS Transfer Family servers
3 participants