Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the appstream fleet idle timeout per aws docs #35173

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

Jgeissler14
Copy link
Contributor

Description

Updated the max idle timeout for appstream fleet to be 360000, from 3600, to match aws documentation. See below

Relations

Closes #34453

References

https://docs.aws.amazon.com/appstream2/latest/APIReference/API_Fleet.html See DisconnectTimeoutInSeconds

Copy link

github-actions bot commented Jan 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appstream Issues and PRs that pertain to the appstream service. labels Jan 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 7, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@Jgeissler14 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit cfead05 into hashicorp:main Jan 10, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 10, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Jgeissler14 Jgeissler14 deleted the f-appstream-fleet-timeout branch January 13, 2024 11:51
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/appstream Issues and PRs that pertain to the appstream service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants