Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cognito_user_pool - add pre_token_generation_config to lambda_config #35236

Conversation

AndresMorelos
Copy link
Contributor

@AndresMorelos AndresMorelos commented Jan 11, 2024

Description

Amazon now provides the ability to customize access tokens when advanced security is ON and we set up a pre-token generation lambda trigger, also, they added a new configuration to set the trigger and support legacy version V1_0 and new version V2_0 that has the customize access capabilities.

This PR introduces a new schema type object to the lambda_config in order to support the Amazon User Pool Changes

CleanShot 2024-01-10 at 21 34 00

Relations

Closes #35007.
Closes #36311.
Closes #35588.

References

Output from Acceptance Testing

Hey guys, right now I can't run the acceptance tests, could you please run them for me?

$ make testacc TESTS=TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig PKG=cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig'  -timeout 360m
=== RUN   TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (63.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 65.660s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. examples Introduces or discusses updates to examples. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Jan 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 11, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @AndresMorelos 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@AndresMorelos AndresMorelos marked this pull request as draft January 11, 2024 04:33
@AndresMorelos AndresMorelos marked this pull request as ready for review January 11, 2024 05:25
@AndresMorelos AndresMorelos marked this pull request as draft January 11, 2024 05:28
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2024
@AndresMorelos
Copy link
Contributor Author

$ make testacc TESTS=TestAccCognitoIDPUserPool_ PKG=cognitoidp
==> Fixing source code with gofmt...
gofmt -s -w ./internal ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPool_'  -timeout 360m
=== RUN   TestAccCognitoIDPUserPool_basic
=== PAUSE TestAccCognitoIDPUserPool_basic
=== RUN   TestAccCognitoIDPUserPool_deletionProtection
=== PAUSE TestAccCognitoIDPUserPool_deletionProtection
=== RUN   TestAccCognitoIDPUserPool_recovery
=== PAUSE TestAccCognitoIDPUserPool_recovery
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUser
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUser
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== PAUSE TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== RUN   TestAccCognitoIDPUserPool_withDevice
=== PAUSE TestAccCognitoIDPUserPool_withDevice
=== RUN   TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_MFA_sms
=== PAUSE TestAccCognitoIDPUserPool_MFA_sms
=== RUN   TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== RUN   TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== RUN   TestAccCognitoIDPUserPool_sms
=== PAUSE TestAccCognitoIDPUserPool_sms
=== RUN   TestAccCognitoIDPUserPool_SMS_snsRegion
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsRegion
=== RUN   TestAccCognitoIDPUserPool_SMS_externalID
=== PAUSE TestAccCognitoIDPUserPool_SMS_externalID
=== RUN   TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== RUN   TestAccCognitoIDPUserPool_smsVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_withEmail
=== PAUSE TestAccCognitoIDPUserPool_withEmail
=== RUN   TestAccCognitoIDPUserPool_withEmailSource
    user_pool_test.go:856: 'TEST_AWS_SES_VERIFIED_EMAIL_ARN' not set, skipping test.
--- SKIP: TestAccCognitoIDPUserPool_withEmailSource (0.00s)
=== RUN   TestAccCognitoIDPUserPool_withTags
=== PAUSE TestAccCognitoIDPUserPool_withTags
=== RUN   TestAccCognitoIDPUserPool_withAliasAttributes
=== PAUSE TestAccCognitoIDPUserPool_withAliasAttributes
=== RUN   TestAccCognitoIDPUserPool_withUsernameAttributes
=== PAUSE TestAccCognitoIDPUserPool_withUsernameAttributes
=== RUN   TestAccCognitoIDPUserPool_withPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withUsername
=== PAUSE TestAccCognitoIDPUserPool_withUsername
=== RUN   TestAccCognitoIDPUserPool_withLambda
=== PAUSE TestAccCognitoIDPUserPool_withLambda
=== RUN   TestAccCognitoIDPUserPool_WithLambda_email
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_email
=== RUN   TestAccCognitoIDPUserPool_WithLambda_sms
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_sms
=== RUN   TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== RUN   TestAccCognitoIDPUserPool_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributes
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesModified
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesModified
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== RUN   TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== PAUSE TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== RUN   TestAccCognitoIDPUserPool_update
=== PAUSE TestAccCognitoIDPUserPool_update
=== RUN   TestAccCognitoIDPUserPool_disappears
=== PAUSE TestAccCognitoIDPUserPool_disappears
=== RUN   TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== PAUSE TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== CONT  TestAccCognitoIDPUserPool_basic
=== CONT  TestAccCognitoIDPUserPool_withEmail
=== CONT  TestAccCognitoIDPUserPool_smsVerificationMessage
=== CONT  TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUser
=== CONT  TestAccCognitoIDPUserPool_recovery
=== CONT  TestAccCognitoIDPUserPool_sms
=== CONT  TestAccCognitoIDPUserPool_withUsername
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== CONT  TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== CONT  TestAccCognitoIDPUserPool_disappears
=== CONT  TestAccCognitoIDPUserPool_update
=== CONT  TestAccCognitoIDPUserPool_WithLambda_email
=== CONT  TestAccCognitoIDPUserPool_WithLambda_sms
=== CONT  TestAccCognitoIDPUserPool_MFA_sms
=== CONT  TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== CONT  TestAccCognitoIDPUserPool_deletionProtection
=== CONT  TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_disappears (30.03s)
=== CONT  TestAccCognitoIDPUserPool_withUsernameAttributes
--- PASS: TestAccCognitoIDPUserPool_withEmail (32.23s)
=== CONT  TestAccCognitoIDPUserPool_withPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_basic (34.09s)
=== CONT  TestAccCognitoIDPUserPool_withLambda
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy (36.97s)
=== CONT  TestAccCognitoIDPUserPool_SMS_externalID
--- PASS: TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings (45.73s)
=== CONT  TestAccCognitoIDPUserPool_withAliasAttributes
--- PASS: TestAccCognitoIDPUserPool_deletionProtection (51.99s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsCallerARN
--- PASS: TestAccCognitoIDPUserPool_smsVerificationMessage (52.59s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUser (53.65s)
=== CONT  TestAccCognitoIDPUserPool_smsAuthenticationMessage
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplate (57.60s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsRegion
--- PASS: TestAccCognitoIDPUserPool_withUsername (59.00s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesModified
--- PASS: TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA (68.63s)
=== CONT  TestAccCognitoIDPUserPool_withTags
--- PASS: TestAccCognitoIDPUserPool_recovery (70.88s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityMode (75.01s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesRemoved
--- PASS: TestAccCognitoIDPUserPool_withUsernameAttributes (52.80s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributes
--- PASS: TestAccCognitoIDPUserPool_sms (83.19s)
=== CONT  TestAccCognitoIDPUserPool_withEmailVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_withPasswordPolicy (52.61s)
=== CONT  TestAccCognitoIDPUserPool_withDevice
--- PASS: TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA (87.04s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesModified (30.66s)
--- PASS: TestAccCognitoIDPUserPool_update (92.48s)
--- PASS: TestAccCognitoIDPUserPool_MFA_sms (95.33s)
--- PASS: TestAccCognitoIDPUserPool_withAliasAttributes (50.90s)
--- PASS: TestAccCognitoIDPUserPool_SMS_snsRegion (43.58s)
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints (30.32s)
--- PASS: TestAccCognitoIDPUserPool_smsAuthenticationMessage (49.86s)
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesRemoved (28.70s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_email (103.85s)
--- PASS: TestAccCognitoIDPUserPool_SMS_externalID (71.09s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS (56.78s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (109.52s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_sms (112.12s)
--- PASS: TestAccCognitoIDPUserPool_SMS_snsCallerARN (63.06s)
--- PASS: TestAccCognitoIDPUserPool_withEmailVerificationMessage (35.74s)
--- PASS: TestAccCognitoIDPUserPool_schemaAttributes (36.11s)
--- PASS: TestAccCognitoIDPUserPool_withDevice (34.53s)
--- PASS: TestAccCognitoIDPUserPool_withLambda (85.31s)
--- PASS: TestAccCognitoIDPUserPool_withTags (52.47s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFA (41.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 131.133s

@AndresMorelos AndresMorelos marked this pull request as ready for review January 12, 2024 01:36
@AndresMorelos
Copy link
Contributor Author

@justinretzolk Sorry to bother you, but I just saw you make changes to the PR labels, could you please take a look at my contribution?

Thank you so much

@justinretzolk
Copy link
Member

Hey @AndresMorelos 👋 Thanks for checking in here, and thank you very much for the contribution! I'm the community manager for the provider, so I won't be the one doing the actual PR review here (I was triaging when I adjusted the labels). With that in mind, I can't speak to when this will be prioritized just yet. We base our prioritization on the count of 👍 reactions and a few other things (for more information on that, check out our prioritization guide).

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 13, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPIdentityProvider_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPIdentityProvider_ -timeout 360m
=== RUN   TestAccCognitoIDPIdentityProvider_basic
=== PAUSE TestAccCognitoIDPIdentityProvider_basic
=== RUN   TestAccCognitoIDPIdentityProvider_idpIdentifiers
=== PAUSE TestAccCognitoIDPIdentityProvider_idpIdentifiers
=== RUN   TestAccCognitoIDPIdentityProvider_saml
=== PAUSE TestAccCognitoIDPIdentityProvider_saml
=== RUN   TestAccCognitoIDPIdentityProvider_disappears
=== PAUSE TestAccCognitoIDPIdentityProvider_disappears
=== RUN   TestAccCognitoIDPIdentityProvider_Disappears_userPool
=== PAUSE TestAccCognitoIDPIdentityProvider_Disappears_userPool
=== CONT  TestAccCognitoIDPIdentityProvider_basic
=== CONT  TestAccCognitoIDPIdentityProvider_disappears
--- PASS: TestAccCognitoIDPIdentityProvider_disappears (18.92s)
=== CONT  TestAccCognitoIDPIdentityProvider_Disappears_userPool
--- PASS: TestAccCognitoIDPIdentityProvider_basic (33.89s)
=== CONT  TestAccCognitoIDPIdentityProvider_saml
--- PASS: TestAccCognitoIDPIdentityProvider_Disappears_userPool (17.30s)
=== CONT  TestAccCognitoIDPIdentityProvider_idpIdentifiers
--- PASS: TestAccCognitoIDPIdentityProvider_saml (32.28s)
--- PASS: TestAccCognitoIDPIdentityProvider_idpIdentifiers (32.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	75.259s
% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolUICustomization_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPUserPoolUICustomization_ -timeout 360m
=== RUN   TestAccCognitoIDPUserPoolUICustomization_AllClients_CSS
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_AllClients_CSS
=== RUN   TestAccCognitoIDPUserPoolUICustomization_AllClients_disappears
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_AllClients_disappears
=== RUN   TestAccCognitoIDPUserPoolUICustomization_AllClients_imageFile
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_AllClients_imageFile
=== RUN   TestAccCognitoIDPUserPoolUICustomization_AllClients_CSSAndImageFile
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_AllClients_CSSAndImageFile
=== RUN   TestAccCognitoIDPUserPoolUICustomization_Client_CSS
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_Client_CSS
=== RUN   TestAccCognitoIDPUserPoolUICustomization_Client_disappears
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_Client_disappears
=== RUN   TestAccCognitoIDPUserPoolUICustomization_Client_image
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_Client_image
=== RUN   TestAccCognitoIDPUserPoolUICustomization_ClientAndAll_cSS
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_ClientAndAll_cSS
=== RUN   TestAccCognitoIDPUserPoolUICustomization_UpdateClientToAll_cSS
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_UpdateClientToAll_cSS
=== RUN   TestAccCognitoIDPUserPoolUICustomization_UpdateAllToClient_cSS
=== PAUSE TestAccCognitoIDPUserPoolUICustomization_UpdateAllToClient_cSS
=== CONT  TestAccCognitoIDPUserPoolUICustomization_AllClients_CSS
=== CONT  TestAccCognitoIDPUserPoolUICustomization_Client_disappears
--- PASS: TestAccCognitoIDPUserPoolUICustomization_Client_disappears (21.97s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_UpdateClientToAll_cSS
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_CSS (40.86s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_UpdateAllToClient_cSS
--- PASS: TestAccCognitoIDPUserPoolUICustomization_UpdateClientToAll_cSS (36.61s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_ClientAndAll_cSS
--- PASS: TestAccCognitoIDPUserPoolUICustomization_UpdateAllToClient_cSS (37.26s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_Client_image
--- PASS: TestAccCognitoIDPUserPoolUICustomization_ClientAndAll_cSS (53.74s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_AllClients_CSSAndImageFile
--- PASS: TestAccCognitoIDPUserPoolUICustomization_Client_image (52.95s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_Client_CSS
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_CSSAndImageFile (59.98s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_AllClients_imageFile
--- PASS: TestAccCognitoIDPUserPoolUICustomization_Client_CSS (41.25s)
=== CONT  TestAccCognitoIDPUserPoolUICustomization_AllClients_disappears
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_disappears (21.47s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_imageFile (39.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	218.816s
% make testacc TESTARGS='-run=TestAccCognitoIDPUserPool_\|TestAccCognitoIDPUser_disappears\|TestAccCognitoIDPRiskConfiguration_disappears_userPool' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPUserPool_\|TestAccCognitoIDPUser_disappears\|TestAccCognitoIDPRiskConfiguration_disappears_userPool -timeout 360m
=== RUN   TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== RUN   TestAccCognitoIDPUserPool_basic
=== PAUSE TestAccCognitoIDPUserPool_basic
=== RUN   TestAccCognitoIDPUserPool_deletionProtection
=== PAUSE TestAccCognitoIDPUserPool_deletionProtection
=== RUN   TestAccCognitoIDPUserPool_recovery
=== PAUSE TestAccCognitoIDPUserPool_recovery
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUser
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUser
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== PAUSE TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== RUN   TestAccCognitoIDPUserPool_withDevice
=== PAUSE TestAccCognitoIDPUserPool_withDevice
=== RUN   TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_MFA_sms
=== PAUSE TestAccCognitoIDPUserPool_MFA_sms
=== RUN   TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== RUN   TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== RUN   TestAccCognitoIDPUserPool_sms
=== PAUSE TestAccCognitoIDPUserPool_sms
=== RUN   TestAccCognitoIDPUserPool_SMS_snsRegion
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsRegion
=== RUN   TestAccCognitoIDPUserPool_SMS_externalID
=== PAUSE TestAccCognitoIDPUserPool_SMS_externalID
=== RUN   TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== RUN   TestAccCognitoIDPUserPool_smsVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_withEmail
=== PAUSE TestAccCognitoIDPUserPool_withEmail
=== RUN   TestAccCognitoIDPUserPool_withEmailSource
    user_pool_test.go:885: Environment variable TEST_AWS_SES_VERIFIED_EMAIL_ARN is not set, skipping test
--- SKIP: TestAccCognitoIDPUserPool_withEmailSource (0.00s)
=== RUN   TestAccCognitoIDPUserPool_tags
=== PAUSE TestAccCognitoIDPUserPool_tags
=== RUN   TestAccCognitoIDPUserPool_withAliasAttributes
=== PAUSE TestAccCognitoIDPUserPool_withAliasAttributes
=== RUN   TestAccCognitoIDPUserPool_withUsernameAttributes
=== PAUSE TestAccCognitoIDPUserPool_withUsernameAttributes
=== RUN   TestAccCognitoIDPUserPool_withPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withUsername
=== PAUSE TestAccCognitoIDPUserPool_withUsername
=== RUN   TestAccCognitoIDPUserPool_withLambda
=== PAUSE TestAccCognitoIDPUserPool_withLambda
=== RUN   TestAccCognitoIDPUserPool_WithLambda_email
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_email
=== RUN   TestAccCognitoIDPUserPool_WithLambda_sms
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_sms
=== RUN   TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== RUN   TestAccCognitoIDPUserPool_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributes
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesModified
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesModified
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== RUN   TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== PAUSE TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== RUN   TestAccCognitoIDPUserPool_update
=== PAUSE TestAccCognitoIDPUserPool_update
=== RUN   TestAccCognitoIDPUserPool_disappears
=== PAUSE TestAccCognitoIDPUserPool_disappears
=== RUN   TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== PAUSE TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== RUN   TestAccCognitoIDPUser_disappears
=== PAUSE TestAccCognitoIDPUser_disappears
=== CONT  TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== CONT  TestAccCognitoIDPUserPool_withEmail
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (20.29s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributes
--- PASS: TestAccCognitoIDPUserPool_withEmail (23.28s)
=== CONT  TestAccCognitoIDPUser_disappears
--- PASS: TestAccCognitoIDPUser_disappears (18.49s)
=== CONT  TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
--- PASS: TestAccCognitoIDPUserPool_schemaAttributes (36.65s)
=== CONT  TestAccCognitoIDPUserPool_disappears
--- PASS: TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings (33.16s)
=== CONT  TestAccCognitoIDPUserPool_update
--- PASS: TestAccCognitoIDPUserPool_disappears (19.43s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplate
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplate (35.37s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints (23.49s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesModified
--- PASS: TestAccCognitoIDPUserPool_update (61.33s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesRemoved
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesModified (23.07s)
=== CONT  TestAccCognitoIDPUserPool_withUsername
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesRemoved (23.33s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
--- PASS: TestAccCognitoIDPUserPool_withUsername (35.28s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_sms
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (84.89s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_email
--- PASS: TestAccCognitoIDPUserPool_WithLambda_sms (71.30s)
=== CONT  TestAccCognitoIDPUserPool_withLambda
--- PASS: TestAccCognitoIDPUserPool_WithLambda_email (72.25s)
=== CONT  TestAccCognitoIDPUserPool_withUsernameAttributes
--- PASS: TestAccCognitoIDPUserPool_withLambda (70.56s)
=== CONT  TestAccCognitoIDPUserPool_withPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_withUsernameAttributes (35.77s)
=== CONT  TestAccCognitoIDPUserPool_withAliasAttributes
--- PASS: TestAccCognitoIDPUserPool_withPasswordPolicy (35.36s)
=== CONT  TestAccCognitoIDPUserPool_tags
--- PASS: TestAccCognitoIDPUserPool_withAliasAttributes (35.80s)
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy (22.39s)
=== CONT  TestAccCognitoIDPUserPool_MFA_sms
--- PASS: TestAccCognitoIDPUserPool_tags (49.00s)
=== CONT  TestAccCognitoIDPUserPool_withEmailVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_withEmailVerificationMessage (34.48s)
=== CONT  TestAccCognitoIDPUserPool_withDevice
--- PASS: TestAccCognitoIDPUserPool_MFA_sms (68.94s)
=== CONT  TestAccCognitoIDPUserPool_withAdvancedSecurityMode
--- PASS: TestAccCognitoIDPUserPool_withDevice (34.38s)
=== CONT  TestAccCognitoIDPUserPool_sms
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityMode (48.00s)
=== CONT  TestAccCognitoIDPUserPool_smsVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_sms (58.70s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsCallerARN
--- PASS: TestAccCognitoIDPUserPool_smsVerificationMessage (34.69s)
=== CONT  TestAccCognitoIDPUserPool_SMS_externalID
--- PASS: TestAccCognitoIDPUserPool_SMS_snsCallerARN (54.59s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsRegion
--- PASS: TestAccCognitoIDPUserPool_SMS_externalID (53.37s)
=== CONT  TestAccCognitoIDPUserPool_recovery
--- PASS: TestAccCognitoIDPUserPool_SMS_snsRegion (33.79s)
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUser
--- PASS: TestAccCognitoIDPUserPool_recovery (62.27s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUser (48.20s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFA (61.23s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA (76.30s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
--- PASS: TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA (57.25s)
=== CONT  TestAccCognitoIDPUserPool_smsAuthenticationMessage
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS (56.57s)
=== CONT  TestAccCognitoIDPUserPool_basic
--- PASS: TestAccCognitoIDPUserPool_basic (30.29s)
=== CONT  TestAccCognitoIDPUserPool_deletionProtection
--- PASS: TestAccCognitoIDPUserPool_smsAuthenticationMessage (48.24s)
--- PASS: TestAccCognitoIDPUserPool_deletionProtection (41.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	891.217s

@ewbankkit
Copy link
Contributor

@AndresMorelos Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3250460 into hashicorp:main Mar 13, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.41.0 milestone Mar 13, 2024
@AndresMorelos AndresMorelos deleted the r-cognito_user_pool_config_pre_token_generation_config branch March 14, 2024 15:22
Copy link

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. examples Introduces or discusses updates to examples. generators Relates to code generators. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Enhancement]: aws_cognito_user_pool: enable lambda_version for pre_token_generation
4 participants