Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for additional owner value #35286

Merged

Conversation

cbhoffman
Copy link

Description

I have added the "ThirdParty" option for both ImageBuilder "components" and "recipes" data sources.

Relations

Closes #35229

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. labels Jan 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 12, 2024
@cbhoffman cbhoffman closed this Jan 12, 2024
@cbhoffman cbhoffman deleted the adding-support-for-additional-owner-value branch January 12, 2024 23:28
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label Jan 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cbhoffman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@cbhoffman cbhoffman restored the adding-support-for-additional-owner-value branch January 12, 2024 23:40
@cbhoffman cbhoffman reopened this Jan 12, 2024
@cbhoffman cbhoffman marked this pull request as ready for review January 12, 2024 23:41
@cbhoffman
Copy link
Author

Hi @ewbankkit this goes slightly beyond the original issue but if you want me to change anything please let me know 👍.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 25, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccImageBuilderContainerRecipesDataSource_\|TestAccImageBuilderComponentsDataSource_\|TestAccImageBuilderImageRecipesDataSource_' PKG=imagebuilder ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 2  -run=TestAccImageBuilderContainerRecipesDataSource_\|TestAccImageBuilderComponentsDataSource_\|TestAccImageBuilderImageRecipesDataSource_ -timeout 360m
=== RUN   TestAccImageBuilderComponentsDataSource_filter
=== PAUSE TestAccImageBuilderComponentsDataSource_filter
=== RUN   TestAccImageBuilderContainerRecipesDataSource_filter
=== PAUSE TestAccImageBuilderContainerRecipesDataSource_filter
=== RUN   TestAccImageBuilderImageRecipesDataSource_owner
=== PAUSE TestAccImageBuilderImageRecipesDataSource_owner
=== RUN   TestAccImageBuilderImageRecipesDataSource_filter
=== PAUSE TestAccImageBuilderImageRecipesDataSource_filter
=== CONT  TestAccImageBuilderComponentsDataSource_filter
=== CONT  TestAccImageBuilderImageRecipesDataSource_owner
--- PASS: TestAccImageBuilderImageRecipesDataSource_owner (22.19s)
=== CONT  TestAccImageBuilderImageRecipesDataSource_filter
--- PASS: TestAccImageBuilderComponentsDataSource_filter (31.24s)
=== CONT  TestAccImageBuilderContainerRecipesDataSource_filter
--- PASS: TestAccImageBuilderImageRecipesDataSource_filter (21.83s)
--- PASS: TestAccImageBuilderContainerRecipesDataSource_filter (22.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	64.531s

@ewbankkit
Copy link
Contributor

@cbhoffman Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 73d6d60 into hashicorp:main Jan 25, 2024
49 of 50 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 25, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_imagebuilder_components (data source): Add support for owner of "ThirdParty"
2 participants