AWS Mainframe Modernisation Service Deployment Resource #35408

drewtul · 2024-01-19T21:37:31Z

Description

Add resource to manage AWS Mainframe Modernisation Service Deployment resources.

Relations

Closes #35311.
Closes #35399.
Closes #35324.
Closes #35379.

Output from Acceptance Testing

 % make testacc TESTS=TestAccM2Deployment_ PKG=m2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/m2/... -v -count 1 -parallel 20 -run='TestAccM2Deployment_'  -timeout 360m
=== RUN   TestAccM2Deployment_basic
=== PAUSE TestAccM2Deployment_basic
=== RUN   TestAccM2Deployment_nostart
=== PAUSE TestAccM2Deployment_nostart
=== RUN   TestAccM2Deployment_update
=== PAUSE TestAccM2Deployment_update
=== RUN   TestAccM2Deployment_disappears
=== PAUSE TestAccM2Deployment_disappears
=== CONT  TestAccM2Deployment_basic
=== CONT  TestAccM2Deployment_disappears
=== CONT  TestAccM2Deployment_update
=== CONT  TestAccM2Deployment_nostart
--- PASS: TestAccM2Deployment_disappears (2646.15s)
--- PASS: TestAccM2Deployment_nostart (2837.60s)
--- PASS: TestAccM2Deployment_update (2839.85s)
--- PASS: TestAccM2Deployment_basic (3021.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/m2 3027.652s

...

…t-resource

…to f-mainframe-environment-resource

…com/m2/latest/userguide/tutorial-runtime-ba.html'.

% make testacc TESTARGS='-run=TestAccM2Application_' PKG=m2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 2 -run=TestAccM2Application_ -timeout 360m === RUN TestAccM2Application_basic === PAUSE TestAccM2Application_basic === RUN TestAccM2Application_disappears === PAUSE TestAccM2Application_disappears === RUN TestAccM2Application_tags === PAUSE TestAccM2Application_tags === RUN TestAccM2Application_full === PAUSE TestAccM2Application_full === RUN TestAccM2Application_update === PAUSE TestAccM2Application_update === CONT TestAccM2Application_basic === CONT TestAccM2Application_full --- PASS: TestAccM2Application_basic (35.77s) === CONT TestAccM2Application_update --- PASS: TestAccM2Application_full (37.77s) === CONT TestAccM2Application_tags --- PASS: TestAccM2Application_update (73.73s) === CONT TestAccM2Application_disappears --- PASS: TestAccM2Application_tags (103.42s) --- PASS: TestAccM2Application_disappears (50.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/m2 171.607s

# Conflicts: # internal/service/m2/application.go # internal/service/m2/application_test.go # internal/service/m2/export_test.go # internal/service/m2/service_package_gen.go

% make testacc TESTARGS='-run=TestAccM2Deployment_basic' PKG=m2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 20 -run=TestAccM2Deployment_basic -timeout 360m === RUN TestAccM2Deployment_basic === PAUSE TestAccM2Deployment_basic === CONT TestAccM2Deployment_basic --- PASS: TestAccM2Deployment_basic (2728.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/m2 2739.670s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccM2Environment_basic' PKG=m2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 2  -run=TestAccM2Environment_basic -timeout 360m
=== RUN   TestAccM2Environment_basic
=== PAUSE TestAccM2Environment_basic
=== CONT  TestAccM2Environment_basic
--- PASS: TestAccM2Environment_basic (393.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/m2	404.690s

% make testacc TESTARGS='-run=TestAccM2Environment_disappears\|TestAccM2Environment_tags' PKG=m2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 2  -run=TestAccM2Environment_disappears\|TestAccM2Environment_tags -timeout 360m
=== RUN   TestAccM2Environment_disappears
=== PAUSE TestAccM2Environment_disappears
=== RUN   TestAccM2Environment_tags
=== PAUSE TestAccM2Environment_tags
=== CONT  TestAccM2Environment_disappears
=== CONT  TestAccM2Environment_tags
--- PASS: TestAccM2Environment_disappears (420.21s)
--- PASS: TestAccM2Environment_tags (617.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/m2	628.780s

% make testacc TESTARGS='-run=TestAccM2Environment_fsx\|TestAccM2Environment_efs' PKG=m2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 2  -run=TestAccM2Environment_fsx\|TestAccM2Environment_efs -timeout 360m
=== RUN   TestAccM2Environment_efs
=== PAUSE TestAccM2Environment_efs
=== RUN   TestAccM2Environment_fsx
=== PAUSE TestAccM2Environment_fsx
=== CONT  TestAccM2Environment_efs
=== CONT  TestAccM2Environment_fsx
--- PASS: TestAccM2Environment_efs (522.91s)
--- PASS: TestAccM2Environment_fsx (1162.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/m2	930.301s

% make testacc TESTARGS='-run=TestAccM2Application_' PKG=m2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 2  -run=TestAccM2Application_ -timeout 360m
=== RUN   TestAccM2Application_basic
=== PAUSE TestAccM2Application_basic
=== RUN   TestAccM2Application_disappears
=== PAUSE TestAccM2Application_disappears
=== RUN   TestAccM2Application_tags
=== PAUSE TestAccM2Application_tags
=== RUN   TestAccM2Application_full
=== PAUSE TestAccM2Application_full
=== RUN   TestAccM2Application_update
=== PAUSE TestAccM2Application_update
=== CONT  TestAccM2Application_basic
=== CONT  TestAccM2Application_full
--- PASS: TestAccM2Application_basic (35.77s)
=== CONT  TestAccM2Application_update
--- PASS: TestAccM2Application_full (37.77s)
=== CONT  TestAccM2Application_tags
--- PASS: TestAccM2Application_update (73.73s)
=== CONT  TestAccM2Application_disappears
--- PASS: TestAccM2Application_tags (103.42s)
--- PASS: TestAccM2Application_disappears (50.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/m2	171.607s

% make testacc TESTARGS='-run=TestAccM2Deployment_basic' PKG=m2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 20  -run=TestAccM2Deployment_basic -timeout 360m
=== RUN   TestAccM2Deployment_basic
=== PAUSE TestAccM2Deployment_basic
=== CONT  TestAccM2Deployment_basic
--- PASS: TestAccM2Deployment_basic (2728.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/m2	2739.670s

% make testacc TESTARGS='-run=TestAccM2Deployment_disappears\|TestAccM2Deployment_nostart\|TestAccM2Deployment_update' PKG=m2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/m2/... -v -count 1 -parallel 2  -run=TestAccM2Deployment_disappears\|TestAccM2Deployment_nostart\|TestAccM2Deployment_update -timeout 360m
=== RUN   TestAccM2Deployment_disappears
=== PAUSE TestAccM2Deployment_disappears
=== RUN   TestAccM2Deployment_nostart
=== PAUSE TestAccM2Deployment_nostart
=== RUN   TestAccM2Deployment_update
=== PAUSE TestAccM2Deployment_update
=== CONT  TestAccM2Deployment_disappears
=== CONT  TestAccM2Deployment_update
--- PASS: TestAccM2Deployment_disappears (2688.06s)
=== CONT  TestAccM2Deployment_nostart
--- PASS: TestAccM2Deployment_update (3382.17s)
--- PASS: TestAccM2Deployment_nostart (3186.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/m2	5886.489s

ewbankkit · 2024-03-25T19:21:12Z

@drewtul @meetreks Thanks for the contribution 🎉 👏.

github-actions · 2024-03-28T21:50:18Z

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-04-28T02:10:22Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

drewtul and others added 30 commits January 10, 2024 22:53

Initial pass at m2 service environment resource

0b34fbf

Initial pass on docs

c515493

Fix doc issues, break tests up so basic test is minimal as possible

2061c98

Missing example param in docs

2a29453

Merge branch 'f-mainframe-service-client' into f-mainframe-environmen…

2183b89

…t-resource

Test update and fixes

587b7cd

Add force_update

58ec004

Merge branch 'f-mainframe-service-client' into f-mainframe-environmen…

220924b

…t-resource

Add changelog entry

2cc3aac

Fix formatting of terraform in tests

ed51d73

Fix blank lines in docs

05280d3

Fix hcl formatting in docs

715efc3

Fix hcl formatting in docs

0c4066d

Fix test resource formatting

cf27fd8

Remove trailing spaces in test hcl

3014e15

Fix more formatting in tests now it parses

3864f04

Remove trailing spaces in test hcl

f66e119

Remove trailing spaces in test hcl

872cc3b

Fix import check failing

8018f1a

Fix linting warnings

adda841

Remove trailing empty lines

e1404da

Fix naming and adjust default timeouts in docs to match code.

f618bea

Merge branch 'main' of github.com:hashicorp/terraform-provider-aws in…

76082c6

…to f-mainframe-environment-resource

Iniitial Commit

95a6a88

Migrate to framework from old SDK.

5eaade5

Actually send desired capacity in update if changed.

d9ae753

Merge branch 'main' of github.com:hashicorp/terraform-provider-aws in…

8f5b244

…to f-mainframe-environment-resource

Fix imports

6ca4f77

Fix caps on FSX/EFS

491780d

Missing blank line

0d9d774

ewbankkit added 14 commits March 24, 2024 16:49

r/aws_m2_application: Some renaming.

1201017

r/aws_m2_application: Use AutoFlEx.

92aed5a

Simplify.

031974e

r/aws_m2_application: Demo application from 'https://docs.aws.amazon.…

d8ef0f9

…com/m2/latest/userguide/tutorial-runtime-ba.html'.

r/aws_m2_application: Tidy up acceptance tests.

da938b4

r/aws_m2_application: Corrections.

b8b1a2b

r/aws_m2_application: Tidy up acceptance tests.

ef871a5

Merge commit '42fefc1b795af621091b335baef6c0477e5bf00c' into HEAD

8e414e1

# Conflicts: # internal/service/m2/application.go # internal/service/m2/application_test.go # internal/service/m2/export_test.go # internal/service/m2/service_package_gen.go

Merge branch 'main' into HEAD

cd81508

r/aws_m2_deployment: Tidy up.

837e491

r/aws_m2_deployment: Tidy up acceptance tests.

93a973c

r/aws_m2_deployment: Tidy up acceptance tests.

bd8bdf4

github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. service/mediapackage Issues and PRs that pertain to the mediapackage service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. labels Mar 25, 2024

Fix terrafmt error.

73641d5

ewbankkit approved these changes Mar 25, 2024

View reviewed changes

ewbankkit added 3 commits March 25, 2024 14:42

Run 'make gen'.

5aae6b8

Fix golangci-lint 'unparam'.

8fd8ea4

Fix 'TestOnceAWeekWindowStringSemanticEquals'.

b4288be

ewbankkit merged commit f17e58a into hashicorp:main Mar 25, 2024
44 checks passed

github-actions bot added this to the v5.43.0 milestone Mar 25, 2024

drewtul deleted the f-mainframe-deployment-resource branch March 27, 2024 21:01

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AWS Mainframe Modernisation Service Deployment Resource #35408

AWS Mainframe Modernisation Service Deployment Resource #35408

drewtul commented Jan 19, 2024 •

edited by ewbankkit

Loading

ewbankkit left a comment

ewbankkit commented Mar 25, 2024

github-actions bot commented Mar 28, 2024

github-actions bot commented Apr 28, 2024

AWS Mainframe Modernisation Service Deployment Resource #35408

AWS Mainframe Modernisation Service Deployment Resource #35408

Conversation

drewtul commented Jan 19, 2024 • edited by ewbankkit Loading

Description

Relations

Output from Acceptance Testing

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Mar 25, 2024

github-actions bot commented Mar 28, 2024

github-actions bot commented Apr 28, 2024

drewtul commented Jan 19, 2024 •

edited by ewbankkit

Loading