Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpc/eni_sg_attach: Add configurable timeouts #35435

Merged
merged 4 commits into from Jan 22, 2024
Merged

vpc/eni_sg_attach: Add configurable timeouts #35435

merged 4 commits into from Jan 22, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 22, 2024

Description

Add configurable timeouts to aws_network_interface_sg_attachment.

Relations

Closes #35436

References

Output from Acceptance Testing

% make t T=TestAccVPCNetworkInterfaceSGAttachment_ K=vpc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCNetworkInterfaceSGAttachment_'  -timeout 360m
=== RUN   TestAccVPCNetworkInterfaceSGAttachment_basic
=== PAUSE TestAccVPCNetworkInterfaceSGAttachment_basic
=== RUN   TestAccVPCNetworkInterfaceSGAttachment_disappears
=== PAUSE TestAccVPCNetworkInterfaceSGAttachment_disappears
=== RUN   TestAccVPCNetworkInterfaceSGAttachment_instance
=== PAUSE TestAccVPCNetworkInterfaceSGAttachment_instance
=== RUN   TestAccVPCNetworkInterfaceSGAttachment_multiple
=== PAUSE TestAccVPCNetworkInterfaceSGAttachment_multiple
=== CONT  TestAccVPCNetworkInterfaceSGAttachment_basic
=== CONT  TestAccVPCNetworkInterfaceSGAttachment_instance
=== CONT  TestAccVPCNetworkInterfaceSGAttachment_multiple
=== CONT  TestAccVPCNetworkInterfaceSGAttachment_disappears
--- PASS: TestAccVPCNetworkInterfaceSGAttachment_disappears (26.57s)
--- PASS: TestAccVPCNetworkInterfaceSGAttachment_basic (28.68s)
--- PASS: TestAccVPCNetworkInterfaceSGAttachment_multiple (31.72s)
--- PASS: TestAccVPCNetworkInterfaceSGAttachment_instance (324.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	326.588s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jan 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 22, 2024
@github-actions github-actions bot added the service/vpc Issues and PRs that pertain to the vpc service. label Jan 22, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 22, 2024
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jan 22, 2024
@YakDriver YakDriver merged commit 2eabc1a into main Jan 22, 2024
53 checks passed
@YakDriver YakDriver deleted the eni_sg_attach_to branch January 22, 2024 21:39
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 22, 2024
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/vpc Issues and PRs that pertain to the vpc service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_network_interface_sg_attachment: Add configurable timeouts
1 participant