Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: CodePipeline V2: Add support for pipeline triggers #35475

Closed
ribeiroh opened this issue Jan 25, 2024 · 6 comments · Fixed by #35973
Closed

[Enhancement]: CodePipeline V2: Add support for pipeline triggers #35475

ribeiroh opened this issue Jan 25, 2024 · 6 comments · Fixed by #35973
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Milestone

Comments

@ribeiroh
Copy link

Description

CodePipeline V2 has added support for pipeline triggers on git tags. At the moment, the aws_codepipeline does not support configuring this functionality.

Affected Resource(s) and/or Data Source(s)

  • aws_codepipeline

Potential Terraform Configuration

resource "aws_codepipeline" "codepipeline" {
  name     = "tf-test-pipeline"

  triggers {
    provider_type = "CodeStarSourceConnection"
    git_configuration = {
      source_action_name = "GitHub"
      tags = {
        include = ["good_tag"]
        exclude = ["bad_tag"]
      }
    }
  }
}

References

Would you like to implement a fix?

No

@ribeiroh ribeiroh added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 25, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/codepipeline Issues and PRs that pertain to the codepipeline service. label Jan 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 25, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 25, 2024
@pasolovey
Copy link

V2 new features list includes much more then just a tag trigger AWS CodePipeline adds support for Branch-based development and Monorepos. There are features like:

  • Trigger filtering by branch name and file path
  • Queued/parallel execution modes

I believe these features worth to be added to this ticket as well

@neruneruo
Copy link

@ribeiroh
Does the following HCL meet your expectations?
Since I have written the source code with this content, if you are happy with proceeding, I will create a PR.

  trigger {
    provider_type = "CodeStarSourceConnection"
    git_configuration {
      source_action_name = "Source"
      push {
        branches {
          includes = ["main", "foobar"]
          excludes = ["feature/*", "issue/*"]
        }
        file_paths {
          includes = ["src/production1", "src/production2"]
          excludes = ["test/production1", "test/production2"]
        }
        tags {
          includes = ["tag1", "tag2"]
          excludes = ["tag11", "tag12"]
        }
      }
      pull_request {
        events = ["OPEN","CLOSED"]
        branches {
          includes = ["main", "foobar"]
          excludes = ["feature/*", "issue/*"]
        }
        file_paths {
          includes = ["src/production1", "src/production2"]
          excludes = ["test/production1", "test/production2"]
        }
      }
    }
  }

@ribeiroh
Copy link
Author

@neruneruo this exceeds my expectations :) Thanks a lot!

Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants