redshift/cluster: Add multi_az configuration #35508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/M
terraform-aws-provider
bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @Giaco9 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
github-actions
bot
added
size/L
Giaco9
changed the title
justinretzolk
added
enhancement
…ti_az validation logic to 'CustomizeDiff'.
ewbankkit
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftCluster_' PKG=redshift ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 3 -run=TestAccRedshiftCluster_ -timeout 360m
=== RUN TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== RUN TestAccRedshiftCluster_aqua
=== PAUSE TestAccRedshiftCluster_aqua
=== RUN TestAccRedshiftCluster_disappears
=== PAUSE TestAccRedshiftCluster_disappears
=== RUN TestAccRedshiftCluster_withFinalSnapshot
=== PAUSE TestAccRedshiftCluster_withFinalSnapshot
=== RUN TestAccRedshiftCluster_kmsKey
=== PAUSE TestAccRedshiftCluster_kmsKey
=== RUN TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== PAUSE TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== RUN TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== RUN TestAccRedshiftCluster_snapshotCopy
=== PAUSE TestAccRedshiftCluster_snapshotCopy
=== RUN TestAccRedshiftCluster_iamRoles
=== PAUSE TestAccRedshiftCluster_iamRoles
=== RUN TestAccRedshiftCluster_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_publiclyAccessible
=== RUN TestAccRedshiftCluster_updateNodeCount
=== PAUSE TestAccRedshiftCluster_updateNodeCount
=== RUN TestAccRedshiftCluster_updateNodeType
=== PAUSE TestAccRedshiftCluster_updateNodeType
=== RUN TestAccRedshiftCluster_tags
=== PAUSE TestAccRedshiftCluster_tags
=== RUN TestAccRedshiftCluster_forceNewUsername
=== PAUSE TestAccRedshiftCluster_forceNewUsername
=== RUN TestAccRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone
=== RUN TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== RUN TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== RUN TestAccRedshiftCluster_changeEncryption1
=== PAUSE TestAccRedshiftCluster_changeEncryption1
=== RUN TestAccRedshiftCluster_changeEncryption2
=== PAUSE TestAccRedshiftCluster_changeEncryption2
=== RUN TestAccRedshiftCluster_availabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation
=== RUN TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== RUN TestAccRedshiftCluster_restoreFromSnapshot
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshot
=== RUN TestAccRedshiftCluster_restoreFromSnapshotARN
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshotARN
=== RUN TestAccRedshiftCluster_manageMasterPassword
=== PAUSE TestAccRedshiftCluster_manageMasterPassword
=== RUN TestAccRedshiftCluster_multiAZ
=== PAUSE TestAccRedshiftCluster_multiAZ
=== CONT TestAccRedshiftCluster_basic
=== CONT TestAccRedshiftCluster_forceNewUsername
=== CONT TestAccRedshiftCluster_availabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_basic (155.64s)
=== CONT TestAccRedshiftCluster_snapshotCopy
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (210.42s)
=== CONT TestAccRedshiftCluster_tags
--- PASS: TestAccRedshiftCluster_forceNewUsername (310.30s)
=== CONT TestAccRedshiftCluster_updateNodeType
--- PASS: TestAccRedshiftCluster_snapshotCopy (197.80s)
=== CONT TestAccRedshiftCluster_updateNodeCount
--- PASS: TestAccRedshiftCluster_tags (180.61s)
=== CONT TestAccRedshiftCluster_publiclyAccessible
--- PASS: TestAccRedshiftCluster_publiclyAccessible (238.66s)
=== CONT TestAccRedshiftCluster_iamRoles
--- PASS: TestAccRedshiftCluster_iamRoles (231.84s)
=== CONT TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
--- PASS: TestAccRedshiftCluster_updateNodeCount (685.02s)
=== CONT TestAccRedshiftCluster_changeEncryption2
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (204.65s)
=== CONT TestAccRedshiftCluster_changeEncryption1
--- PASS: TestAccRedshiftCluster_updateNodeType (1141.24s)
=== CONT TestAccRedshiftCluster_kmsKey
--- PASS: TestAccRedshiftCluster_kmsKey (159.11s)
=== CONT TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_changeEncryption1 (698.91s)
=== CONT TestAccRedshiftCluster_enhancedVPCRoutingEnabled
--- PASS: TestAccRedshiftCluster_loggingEnabled (263.68s)
=== CONT TestAccRedshiftCluster_restoreFromSnapshotARN
--- PASS: TestAccRedshiftCluster_changeEncryption2 (910.45s)
=== CONT TestAccRedshiftCluster_multiAZ
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (266.38s)
=== CONT TestAccRedshiftCluster_manageMasterPassword
--- PASS: TestAccRedshiftCluster_manageMasterPassword (154.30s)
=== CONT TestAccRedshiftCluster_restoreFromSnapshot
--- PASS: TestAccRedshiftCluster_restoreFromSnapshotARN (401.37s)
=== CONT TestAccRedshiftCluster_disappears
--- PASS: TestAccRedshiftCluster_multiAZ (527.02s)
=== CONT TestAccRedshiftCluster_withFinalSnapshot
--- PASS: TestAccRedshiftCluster_disappears (264.75s)
=== CONT TestAccRedshiftCluster_aqua
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (431.22s)
=== CONT TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (215.84s)
=== CONT TestAccRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccRedshiftCluster_aqua (187.70s)
=== CONT TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (179.77s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (314.13s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (595.35s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 3222.974s% make testacc TESTARGS='-run=TestAccRedshiftClusterDataSource_' PKG=redshift ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 3 -run=TestAccRedshiftClusterDataSource_ -timeout 360m
=== RUN TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== RUN TestAccRedshiftClusterDataSource_vpc
=== PAUSE TestAccRedshiftClusterDataSource_vpc
=== RUN TestAccRedshiftClusterDataSource_logging
=== PAUSE TestAccRedshiftClusterDataSource_logging
=== RUN TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== PAUSE TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== RUN TestAccRedshiftClusterDataSource_multiAZEnabled
=== PAUSE TestAccRedshiftClusterDataSource_multiAZEnabled
=== CONT TestAccRedshiftClusterDataSource_basic
=== CONT TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== CONT TestAccRedshiftClusterDataSource_logging
--- PASS: TestAccRedshiftClusterDataSource_basic (162.72s)
=== CONT TestAccRedshiftClusterDataSource_multiAZEnabled
--- PASS: TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled (213.00s)
=== CONT TestAccRedshiftClusterDataSource_vpc
--- PASS: TestAccRedshiftClusterDataSource_logging (305.63s)
--- PASS: TestAccRedshiftClusterDataSource_vpc (189.46s)
--- PASS: TestAccRedshiftClusterDataSource_multiAZEnabled (324.61s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 498.168s
|
@Giaco9 Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add supports for the multi_az configuration for Redshift cluster.
Relations
Closes #34926
Closes #32180
References
https://docs.aws.amazon.com/redshift/latest/mgmt/using-multi-az.html
Output from Acceptance Testing