Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'timeout' attribute to Glue Trigger create, update and delete #35542

Merged

Conversation

MSilva98
Copy link

@MSilva98 MSilva98 commented Jan 29, 2024

Description

Add timeout attribute to glue triggers according to the documentation
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/glue_trigger#timeouts

Output from Acceptance Testing

I cannot run the acceptance tests on my side. Please let me know if there are any changes I can/need to make.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. labels Jan 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 29, 2024
@MSilva98 MSilva98 marked this pull request as ready for review January 29, 2024 16:04
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @MSilva98 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. timeouts Pertains to timeout increases. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 29, 2024
@Pimenta14
Copy link

Hello. I am working in the same project as this PR Author.
I executed the acceptance tests for all trigger tests, but I got some failures due to some dependencies, which I assume it's because I cannot execute all the trigger tests without executing other acc tests from other services?

Here is the execution of only the basic test - TestAccGlueTrigger_basic:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueTrigger_basic' -timeout 360m
=== RUN TestAccGlueTrigger_basic
=== PAUSE TestAccGlueTrigger_basic
=== CONT TestAccGlueTrigger_basic
--- PASS: TestAccGlueTrigger_basic (22.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 23.062s

Please tell us if we need to run acc tests for something else.

@johnsonaj johnsonaj self-assigned this Feb 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 9, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccGlueTrigger_' PKG=glue

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueTrigger_ -timeout 360m
--- PASS: TestAccGlueTrigger_tags (56.85s)
--- PASS: TestAccGlueTrigger_onDemandDisable (70.56s)
--- PASS: TestAccGlueTrigger_Actions_notify (79.78s)
--- PASS: TestAccGlueTrigger_Actions_security (80.01s)
--- PASS: TestAccGlueTrigger_basic (84.37s)
--- PASS: TestAccGlueTrigger_startOnCreate (90.30s)
--- PASS: TestAccGlueTrigger_workflowName (96.81s)
--- PASS: TestAccGlueTrigger_disappears (115.06s)
--- PASS: TestAccGlueTrigger_predicate (138.70s)
--- PASS: TestAccGlueTrigger_eventBatchingCondition (151.48s)
--- PASS: TestAccGlueTrigger_schedule (152.96s)
--- PASS: TestAccGlueTrigger_crawler (177.99s)
--- PASS: TestAccGlueTrigger_enabled (190.28s)
--- PASS: TestAccGlueTrigger_description (238.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	246.158s

@johnsonaj
Copy link
Contributor

@MSilva98 thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit b3fcecf into hashicorp:main Feb 9, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants