Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add introspection and limit args to aws_appsync_graphql_api #35631

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: Add introspection and limit args to aws_appsync_graphql_api #35631

merged 2 commits into from
Feb 14, 2024

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 3, 2024

Description

This PR introduces the introspection_config, query_depth_limit, and resolver_count_limit arguments to the aws_appsync_graphql_api resource to support the GraphQL run complexity, query depth, and introspection features.

Relations

Closes #35550

References

Referred to https://docs.aws.amazon.com/appsync/latest/devguide/configuration-limits.html to understand the settings and CreatGraphqlApi API doc for spec.

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppSync_serial/GraphQLAPI PKG=appsync
==> Checking that code complies with gofmt requirements...

TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/GraphQLAPI'  -timeout 360m
=== RUN   TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT  TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/GraphQLAPI
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple
=== RUN   TestAccAppSync_serial/GraphQLAPI/xrayEnabled
=== RUN   TestAccAppSync_serial/GraphQLAPI/authenticationType
=== RUN   TestAccAppSync_serial/GraphQLAPI/log
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri
=== RUN   TestAccAppSync_serial/GraphQLAPI/queryDepthLimit
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect
=== RUN   TestAccAppSync_serial/GraphQLAPI/resolverCountLimit
=== RUN   TestAccAppSync_serial/GraphQLAPI/schema
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID
=== RUN   TestAccAppSync_serial/GraphQLAPI/name
=== RUN   TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM
=== RUN   TestAccAppSync_serial/GraphQLAPI/disappears
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer
=== RUN   TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction
=== RUN   TestAccAppSync_serial/GraphQLAPI/tags
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey
=== RUN   TestAccAppSync_serial/GraphQLAPI/visibility
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools
=== RUN   TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel
=== RUN   TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey
=== RUN   TestAccAppSync_serial/GraphQLAPI/introspectionConfig
=== RUN   TestAccAppSync_serial/GraphQLAPI/basic
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression
--- PASS: TestAccAppSync_serial (2399.43s)
    --- PASS: TestAccAppSync_serial/GraphQLAPI (2399.43s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple (127.92s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/xrayEnabled (47.54s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/authenticationType (50.40s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/log (69.45s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri (171.82s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/queryDepthLimit (30.54s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM (30.51s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect (30.49s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/resolverCountLimit (30.40s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/schema (53.21s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL (49.20s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL (49.02s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID (49.85s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/name (46.06s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion (71.81s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds (292.70s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM (30.96s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/disappears (38.88s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools (48.43s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect (30.97s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda (109.85s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer (49.51s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction (77.89s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/tags (67.54s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey (32.16s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/visibility (31.14s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda (110.85s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools (47.70s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel (149.86s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent (108.80s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey (30.57s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/introspectionConfig (30.85s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/basic (31.58s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression (170.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appsync    2399.611s

$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appsync Issues and PRs that pertain to the appsync service. labels Feb 3, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2024
@acwwat acwwat force-pushed the f-aws_appsync_graphql_api-add_config_limit_attrs branch from fad4a3b to c168c1e Compare February 3, 2024 21:11
@acwwat acwwat changed the title [WIP] feat: Add introspection and limit args to aws_appsync_graphql_api feat: Add introspection and limit args to aws_appsync_graphql_api Feb 3, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2024
ewbankkit
ewbankkit approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppSync_serial' PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20  -run=TestAccAppSync_serial -timeout 360m
=== RUN   TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT  TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/GraphQLAPI
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID
=== RUN   TestAccAppSync_serial/GraphQLAPI/name
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer
=== RUN   TestAccAppSync_serial/GraphQLAPI/basic
=== RUN   TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect
=== RUN   TestAccAppSync_serial/GraphQLAPI/visibility
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey
=== RUN   TestAccAppSync_serial/GraphQLAPI/log
=== RUN   TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools
=== RUN   TestAccAppSync_serial/GraphQLAPI/authenticationType
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda
=== RUN   TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel
=== RUN   TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent
=== RUN   TestAccAppSync_serial/GraphQLAPI/introspectionConfig
=== RUN   TestAccAppSync_serial/GraphQLAPI/resolverCountLimit
=== RUN   TestAccAppSync_serial/GraphQLAPI/disappears
=== RUN   TestAccAppSync_serial/GraphQLAPI/xrayEnabled
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL
=== RUN   TestAccAppSync_serial/GraphQLAPI/schema
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds
=== RUN   TestAccAppSync_serial/GraphQLAPI/queryDepthLimit
=== RUN   TestAccAppSync_serial/GraphQLAPI/tags
=== RUN   TestAccAppSync_serial/Function
=== RUN   TestAccAppSync_serial/Function/basic
=== RUN   TestAccAppSync_serial/Function/code
=== RUN   TestAccAppSync_serial/Function/disappears
=== RUN   TestAccAppSync_serial/Function/description
=== RUN   TestAccAppSync_serial/Function/responseMappingTemplate
=== RUN   TestAccAppSync_serial/Function/sync
=== RUN   TestAccAppSync_serial/Resolver
=== RUN   TestAccAppSync_serial/Resolver/caching
=== RUN   TestAccAppSync_serial/Resolver/sync
=== RUN   TestAccAppSync_serial/Resolver/basic
=== RUN   TestAccAppSync_serial/Resolver/disappears
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting AppSync Resolver (7ix5ps5imjfhbcyt7mlr55tqym-Query-singlePost): NotFoundException: No resolver found.
        
=== RUN   TestAccAppSync_serial/Resolver/DataSource_lambda
=== RUN   TestAccAppSync_serial/Resolver/requestTemplate
=== RUN   TestAccAppSync_serial/Resolver/multipleResolvers
=== RUN   TestAccAppSync_serial/Resolver/pipeline
=== RUN   TestAccAppSync_serial/Resolver/code
=== RUN   TestAccAppSync_serial/Resolver/dataSource
=== RUN   TestAccAppSync_serial/Resolver/responseTemplate
=== RUN   TestAccAppSync_serial/Type
=== RUN   TestAccAppSync_serial/Type/basic
=== RUN   TestAccAppSync_serial/Type/disappears
=== RUN   TestAccAppSync_serial/DomainNameAssociation
=== RUN   TestAccAppSync_serial/DomainNameAssociation/disappears
    appsync_test.go:120: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set. This environment variable must be set to any non-empty value to enable the test.
=== RUN   TestAccAppSync_serial/DomainNameAssociation/basic
    appsync_test.go:120: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set. This environment variable must be set to any non-empty value to enable the test.
=== RUN   TestAccAppSync_serial/APIKey
=== RUN   TestAccAppSync_serial/APIKey/expires
=== RUN   TestAccAppSync_serial/APIKey/basic
=== RUN   TestAccAppSync_serial/APIKey/description
=== RUN   TestAccAppSync_serial/DataSource
=== RUN   TestAccAppSync_serial/DataSource/description
=== RUN   TestAccAppSync_serial/DataSource/Type_eventBridge
=== RUN   TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials
=== RUN   TestAccAppSync_serial/DataSource/Type_http
=== RUN   TestAccAppSync_serial/DataSource/Type_http_auth
=== RUN   TestAccAppSync_serial/DataSource/Type_rdbms_options
    datasource_test.go:502: Step 1/2 error: Error running pre-apply plan: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 26, in resource "aws_rds_cluster" "test":
          26: resource "aws_rds_cluster" "test" {
        
        The argument "engine" is required, but no definition was found.
=== RUN   TestAccAppSync_serial/DataSource/basic
=== RUN   TestAccAppSync_serial/DataSource/HTTP_endpoint
=== RUN   TestAccAppSync_serial/DataSource/type
=== RUN   TestAccAppSync_serial/DataSource/Type_lambda
=== RUN   TestAccAppSync_serial/DataSource/DynamoDB_region
=== RUN   TestAccAppSync_serial/DataSource/Type_dynamoDB
=== RUN   TestAccAppSync_serial/DataSource/Type_none
=== RUN   TestAccAppSync_serial/DataSource/Type_rdbms
    datasource_test.go:473: Step 1/2 error: Error running pre-apply plan: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 26, in resource "aws_rds_cluster" "test":
          26: resource "aws_rds_cluster" "test" {
        
        The argument "engine" is required, but no definition was found.
=== RUN   TestAccAppSync_serial/ApiCache
=== RUN   TestAccAppSync_serial/ApiCache/basic
=== RUN   TestAccAppSync_serial/ApiCache/disappears
=== RUN   TestAccAppSync_serial/DomainName
=== RUN   TestAccAppSync_serial/DomainName/basic
    appsync_test.go:120: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set. This environment variable must be set to any non-empty value to enable the test.
=== RUN   TestAccAppSync_serial/DomainName/disappears
    appsync_test.go:120: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set. This environment variable must be set to any non-empty value to enable the test.
=== RUN   TestAccAppSync_serial/DomainName/description
    appsync_test.go:120: Environment variable AWS_APPSYNC_DOMAIN_NAME_CERTIFICATE_DOMAIN is not set. This environment variable must be set to any non-empty value to enable the test.
--- FAIL: TestAccAppSync_serial (3678.67s)
    --- PASS: TestAccAppSync_serial/GraphQLAPI (1027.73s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect (21.14s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID (30.28s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/name (28.77s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda (38.12s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple (40.81s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM (20.05s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey (19.77s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL (29.54s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer (32.87s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/basic (18.25s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction (33.96s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression (47.60s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect (19.13s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/visibility (18.61s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools (22.20s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM (19.12s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey (18.54s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/log (20.24s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion (31.48s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri (49.83s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools (21.27s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/authenticationType (32.25s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda (35.35s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel (43.63s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent (30.02s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/introspectionConfig (18.29s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/resolverCountLimit (19.26s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/disappears (16.12s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/xrayEnabled (27.30s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL (29.24s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/schema (33.91s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds (89.57s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/queryDepthLimit (20.71s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/tags (50.50s)
    --- PASS: TestAccAppSync_serial/Function (342.11s)
        --- PASS: TestAccAppSync_serial/Function/basic (74.30s)
        --- PASS: TestAccAppSync_serial/Function/code (62.11s)
        --- PASS: TestAccAppSync_serial/Function/disappears (42.55s)
        --- PASS: TestAccAppSync_serial/Function/description (72.65s)
        --- PASS: TestAccAppSync_serial/Function/responseMappingTemplate (51.68s)
        --- PASS: TestAccAppSync_serial/Function/sync (38.81s)
    --- FAIL: TestAccAppSync_serial/Resolver (339.93s)
        --- PASS: TestAccAppSync_serial/Resolver/caching (23.15s)
        --- PASS: TestAccAppSync_serial/Resolver/sync (33.63s)
        --- PASS: TestAccAppSync_serial/Resolver/basic (27.03s)
        --- FAIL: TestAccAppSync_serial/Resolver/disappears (22.54s)
        --- PASS: TestAccAppSync_serial/Resolver/DataSource_lambda (36.60s)
        --- PASS: TestAccAppSync_serial/Resolver/requestTemplate (35.52s)
        --- PASS: TestAccAppSync_serial/Resolver/multipleResolvers (32.77s)
        --- PASS: TestAccAppSync_serial/Resolver/pipeline (24.00s)
        --- PASS: TestAccAppSync_serial/Resolver/code (25.57s)
        --- PASS: TestAccAppSync_serial/Resolver/dataSource (39.39s)
        --- PASS: TestAccAppSync_serial/Resolver/responseTemplate (39.73s)
    --- PASS: TestAccAppSync_serial/Type (44.96s)
        --- PASS: TestAccAppSync_serial/Type/basic (25.07s)
        --- PASS: TestAccAppSync_serial/Type/disappears (19.89s)
    --- PASS: TestAccAppSync_serial/DomainNameAssociation (0.00s)
        --- SKIP: TestAccAppSync_serial/DomainNameAssociation/disappears (0.00s)
        --- SKIP: TestAccAppSync_serial/DomainNameAssociation/basic (0.00s)
    --- PASS: TestAccAppSync_serial/APIKey (92.80s)
        --- PASS: TestAccAppSync_serial/APIKey/expires (32.78s)
        --- PASS: TestAccAppSync_serial/APIKey/basic (22.94s)
        --- PASS: TestAccAppSync_serial/APIKey/description (37.08s)
    --- FAIL: TestAccAppSync_serial/DataSource (364.60s)
        --- PASS: TestAccAppSync_serial/DataSource/description (33.87s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_eventBridge (21.05s)
        --- PASS: TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials (46.23s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_http (21.15s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_http_auth (21.47s)
        --- FAIL: TestAccAppSync_serial/DataSource/Type_rdbms_options (2.02s)
        --- PASS: TestAccAppSync_serial/DataSource/basic (21.04s)
        --- PASS: TestAccAppSync_serial/DataSource/HTTP_endpoint (33.96s)
        --- PASS: TestAccAppSync_serial/DataSource/type (28.90s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_lambda (34.14s)
        --- PASS: TestAccAppSync_serial/DataSource/DynamoDB_region (47.97s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_dynamoDB (30.15s)
        --- PASS: TestAccAppSync_serial/DataSource/Type_none (20.65s)
        --- FAIL: TestAccAppSync_serial/DataSource/Type_rdbms (2.00s)
    --- PASS: TestAccAppSync_serial/ApiCache (1466.53s)
        --- PASS: TestAccAppSync_serial/ApiCache/basic (729.36s)
        --- PASS: TestAccAppSync_serial/ApiCache/disappears (737.17s)
    --- PASS: TestAccAppSync_serial/DomainName (0.00s)
        --- SKIP: TestAccAppSync_serial/DomainName/basic (0.00s)
        --- SKIP: TestAccAppSync_serial/DomainName/disappears (0.00s)
        --- SKIP: TestAccAppSync_serial/DomainName/description (0.00s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	3689.686s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bb8ccd4 into hashicorp:main Feb 14, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 14, 2024
ewbankkit added a commit that referenced this pull request Feb 14, 2024
@ewbankkit
r/aws_appsync_resolver: Fix 'NotFoundException: No resolver found' er…
d38a743 
…ror on Delete (#35631).
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the f-aws_appsync_graphql_api-add_config_limit_attrs branch February 22, 2024 08:02
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.37.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for introspectionConfig, queryDepthLimit, and resolverCountLimit
3 participants
@acwwat @ewbankkit @justinretzolk