Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshiftserverless_workgroup: Add max_capacity argument #35720

Conversation

marcinbelczewski
Copy link

@marcinbelczewski marcinbelczewski commented Feb 8, 2024

Description

Adds max_capacity argument to aws_redshiftserverless_workgroup resource allowing for better control of workgroup scale-out hence costs.

Relations

Closes #35719
Closes #34440

References

Maximum capacity setting is described in AWS docs here

Output from Acceptance Testing

% make testacc TESTS=TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible PKG=redshiftserverless

Copy link

github-actions bot commented Feb 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/S Managed by automation to categorize the size of a PR. label Feb 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 8, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. labels Feb 8, 2024
@marcinbelczewski marcinbelczewski force-pushed the f-aws_redshiftserverless_workgroup-add-max-capacity-argument branch from f182f31 to 3186468 Compare February 8, 2024 11:02
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @marcinbelczewski 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@marcinbelczewski marcinbelczewski marked this pull request as ready for review February 8, 2024 13:25
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=redshiftserverless TESTS=TestAccRedshiftServerlessWorkgroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20 -run='TestAccRedshiftServerlessWorkgroup_'  -timeout 360m

--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (237.95s)
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (291.33s)
--- PASS: TestAccRedshiftServerlessWorkgroup_port (291.34s)
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (296.67s)
--- PASS: TestAccRedshiftServerlessWorkgroup_configParameters (302.82s)
--- PASS: TestAccRedshiftServerlessWorkgroup_baseAndMaxCapacityAndPubliclyAccessible (434.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 441.178s

@jar-b
Copy link
Member

jar-b commented Feb 16, 2024

Thanks for your contribution, @marcinbelczewski! 👍

@jar-b jar-b merged commit e8a049f into hashicorp:main Feb 16, 2024
80 checks passed
@github-actions github-actions bot added this to the v5.38.0 milestone Feb 16, 2024
@marcinbelczewski marcinbelczewski deleted the f-aws_redshiftserverless_workgroup-add-max-capacity-argument branch February 16, 2024 19:18
Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants