Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_access_policy_association: Retry Create on IAM eventual consistency errors #35736

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 9, 2024

Description

Retries IAM eventual consistency errors on Create.

Relations

Closes #35728.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEKSAccessPolicyAssociation_basic' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAccessPolicyAssociation_basic -timeout 360m
=== RUN   TestAccEKSAccessPolicyAssociation_basic
=== PAUSE TestAccEKSAccessPolicyAssociation_basic
=== CONT  TestAccEKSAccessPolicyAssociation_basic
--- PASS: TestAccEKSAccessPolicyAssociation_basic (624.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	645.892s

Copy link

github-actions bot commented Feb 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. labels Feb 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 9, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. eventual-consistency Pertains to eventual consistency issues. labels Feb 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccEKSAccessPolicyAssociation_basic' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAccessPolicyAssociation_basic -timeout 360m
=== RUN   TestAccEKSAccessPolicyAssociation_basic
=== PAUSE TestAccEKSAccessPolicyAssociation_basic
=== CONT  TestAccEKSAccessPolicyAssociation_basic
--- PASS: TestAccEKSAccessPolicyAssociation_basic (715.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        721.901s

@ewbankkit ewbankkit merged commit cee2213 into main Feb 9, 2024
63 checks passed
@ewbankkit ewbankkit deleted the b-aws_eks_access_policy_association-iam-eventual-consistency branch February 9, 2024 16:43
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 9, 2024
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. eventual-consistency Pertains to eventual consistency issues. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sporadic errors in aws_eks_access_policy_association
2 participants