Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_account_region #35739

Merged
merged 21 commits into from Mar 6, 2024

Conversation

AliAllomani
Copy link
Contributor

@AliAllomani AliAllomani commented Feb 9, 2024

Description

New resource aws_account_region to manage enabling/disabling optional regions for an AWS account.

Relations

Closes #31300

References

Output from Acceptance Testing

% make testacc TESTS=TestAccAccountRegion_ PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run='TestAccAccountRegion_'  -timeout 360m
=== RUN   TestAccAccountRegion_basic
--- PASS: TestAccAccountRegion_basic (17.44s)
=== RUN   TestAccAccountRegion_enabledByDefault
--- PASS: TestAccAccountRegion_enabledByDefault (15.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    77.269s

...

Copy link

github-actions bot commented Feb 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/account Issues and PRs that pertain to the account service. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 9, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. labels Feb 12, 2024
@AliAllomani AliAllomani marked this pull request as ready for review February 12, 2024 11:24
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2024
% make testacc TESTARGS='-run=TestAccAccount_serial/Region/basic' PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/Region/basic -timeout 360m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/Region
=== RUN   TestAccAccount_serial/Region/basic
--- PASS: TestAccAccount_serial (478.82s)
    --- PASS: TestAccAccount_serial/Region (478.82s)
        --- PASS: TestAccAccount_serial/Region/basic (478.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	485.498s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAccount_serial/Region/basic' PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/Region/basic -timeout 360m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/Region
=== RUN   TestAccAccount_serial/Region/basic
--- PASS: TestAccAccount_serial (478.82s)
    --- PASS: TestAccAccount_serial/Region (478.82s)
        --- PASS: TestAccAccount_serial/Region/basic (478.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	485.498s
% make testacc TESTARGS='-run=TestAccAccount_serial/Region/AccountID' PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/Region/AccountID -timeout 360m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/Region
=== RUN   TestAccAccount_serial/Region/AccountID
--- PASS: TestAccAccount_serial (525.56s)
    --- PASS: TestAccAccount_serial/Region (525.56s)
        --- PASS: TestAccAccount_serial/Region/AccountID (525.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	532.240s

@ewbankkit
Copy link
Contributor

@AliAllomani Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit cfc45bb into hashicorp:main Mar 6, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 6, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/account Issues and PRs that pertain to the account service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for enabling/disabling optional regions
3 participants