Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3_bucket_arn to codeartifact domain resource #35760

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Jebaseelanravi
Copy link
Contributor

Description

The DescribeDomain API returns a value, s3BucketArn, which contains (surprise!) the ARN of the S3 bucket that is used to store package assets for that domain. It would be useful to be able to reference that value in order to allow access to it in various policies (IAM, VPCE, etc.), but right now as far as I can tell it’s not exposed as an attribute of the resource.

Relations

Closes #35302

References

https://docs.aws.amazon.com/codeartifact/latest/APIReference/API_DomainDescription.html

Output from Acceptance Testing

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codeartifact Issues and PRs that pertain to the codeartifact service. labels Feb 11, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2024
@Jebaseelanravi Jebaseelanravi changed the title add s3 bucket arn to codeartifact domain Add s3_bucket_arn to codeartifact domain resource Feb 11, 2024
@Jebaseelanravi Jebaseelanravi marked this pull request as ready for review February 11, 2024 22:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Jebaseelanravi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeArtifact_serial/Domain/basic' PKG=codeartifact
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codeartifact/... -v -count 1 -parallel 20  -run=TestAccCodeArtifact_serial/Domain/basic -timeout 360m
=== RUN   TestAccCodeArtifact_serial
=== PAUSE TestAccCodeArtifact_serial
=== CONT  TestAccCodeArtifact_serial
=== RUN   TestAccCodeArtifact_serial/Domain
=== RUN   TestAccCodeArtifact_serial/Domain/basic
=== RUN   TestAccCodeArtifact_serial/DomainPermissionsPolicy
=== RUN   TestAccCodeArtifact_serial/DomainPermissionsPolicy/basic
--- PASS: TestAccCodeArtifact_serial (57.28s)
    --- PASS: TestAccCodeArtifact_serial/Domain (21.74s)
        --- PASS: TestAccCodeArtifact_serial/Domain/basic (21.74s)
    --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy (35.54s)
        --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy/basic (35.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact	69.215s

@ewbankkit
Copy link
Contributor

@Jebaseelanravi Thanks for the contribution 🎉 👏.

@Jebaseelanravi
Copy link
Contributor Author

@Jebaseelanravi Thanks for the contribution 🎉 👏.

It was a pleasure working on it 🚀

@ewbankkit ewbankkit merged commit 6969230 into hashicorp:main Feb 12, 2024
71 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 12, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Jebaseelanravi Jebaseelanravi deleted the b-add-s3arn-attr branch February 16, 2024 09:08
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_codeartifact_domain: add s3 bucket ARN attribute
2 participants