Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update operation for authorizer id on apigatewayv2 route #35821

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

vubogovich
Copy link
Contributor

@vubogovich vubogovich commented Feb 14, 2024

Description

The change from

resource "aws_apigatewayv2_route" "some_route" {
  api_id = ...
  route_key = ...
  target = "integrations/..."
  authorization_type = "JWT"
  authorizer_id = first_authorizer.id
}

to

resource "aws_apigatewayv2_route" "some_route" {
  api_id = ...
  route_key = ...
  target = "integrations/..."
  authorization_type = "JWT"
  authorizer_id = second_authorizer.id
}

results in the following error:

Error: updating API Gateway v2 route (*****): BadRequestException: Unable to update route. Authorizer type is invalid or null.

which can be reproduced using AWS CLI

aws apigatewayv2 update-route --api-id **** --route-id **** --authorizer-id <second-authorizer-id>

while the following is working

aws apigatewayv2 update-route --api-id **** --route-id **** --authorization-type JWT --authorizer-id <second-authorizer-id>

So the solution is to include authorization_type on the change of authorizer_id when aws provider updates aws_apigatewayv2_route resource.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. labels Feb 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 14, 2024
@vubogovich vubogovich marked this pull request as ready for review February 14, 2024 21:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @vubogovich 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayV2Route_' PKG=apigatewayv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 2  -run=TestAccAPIGatewayV2Route_ -timeout 360m
=== RUN   TestAccAPIGatewayV2Route_basic
=== PAUSE TestAccAPIGatewayV2Route_basic
=== RUN   TestAccAPIGatewayV2Route_disappears
=== PAUSE TestAccAPIGatewayV2Route_disappears
=== RUN   TestAccAPIGatewayV2Route_authorizer
=== PAUSE TestAccAPIGatewayV2Route_authorizer
=== RUN   TestAccAPIGatewayV2Route_jwtAuthorization
=== PAUSE TestAccAPIGatewayV2Route_jwtAuthorization
=== RUN   TestAccAPIGatewayV2Route_model
=== PAUSE TestAccAPIGatewayV2Route_model
=== RUN   TestAccAPIGatewayV2Route_requestParameters
=== PAUSE TestAccAPIGatewayV2Route_requestParameters
=== RUN   TestAccAPIGatewayV2Route_simpleAttributes
=== PAUSE TestAccAPIGatewayV2Route_simpleAttributes
=== RUN   TestAccAPIGatewayV2Route_target
=== PAUSE TestAccAPIGatewayV2Route_target
=== RUN   TestAccAPIGatewayV2Route_updateRouteKey
=== PAUSE TestAccAPIGatewayV2Route_updateRouteKey
=== CONT  TestAccAPIGatewayV2Route_basic
=== CONT  TestAccAPIGatewayV2Route_requestParameters
=== CONT  TestAccAPIGatewayV2Route_target
--- PASS: TestAccAPIGatewayV2Route_basic (42.25s)
--- PASS: TestAccAPIGatewayV2Route_target (42.76s)
=== CONT  TestAccAPIGatewayV2Route_updateRouteKey
--- PASS: TestAccAPIGatewayV2Route_requestParameters (90.08s)
=== CONT  TestAccAPIGatewayV2Route_jwtAuthorization
--- PASS: TestAccAPIGatewayV2Route_updateRouteKey (59.53s)
=== CONT  TestAccAPIGatewayV2Route_model
--- PASS: TestAccAPIGatewayV2Route_jwtAuthorization (91.54s)
=== CONT  TestAccAPIGatewayV2Route_authorizer
--- PASS: TestAccAPIGatewayV2Route_model (40.46s)
=== CONT  TestAccAPIGatewayV2Route_disappears
--- PASS: TestAccAPIGatewayV2Route_disappears (34.45s)
=== CONT  TestAccAPIGatewayV2Route_simpleAttributes
--- PASS: TestAccAPIGatewayV2Route_authorizer (97.45s)
--- PASS: TestAccAPIGatewayV2Route_simpleAttributes (79.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	332.541s

@ewbankkit
Copy link
Contributor

@vubogovich Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 313bcf0 into hashicorp:main Feb 15, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 15, 2024
@vubogovich vubogovich deleted the b-fix-apigatewayv2-route branch February 15, 2024 19:18
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants