Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: hash AWS SSM Secret manager sensitive data #35869

Open
Azmah-Bad opened this issue Feb 17, 2024 · 1 comment
Open

[Enhancement]: hash AWS SSM Secret manager sensitive data #35869

Azmah-Bad opened this issue Feb 17, 2024 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.

Comments

@Azmah-Bad
Copy link

Description

  • the resource used to create a secret manager version is aws_secretsmanager_secret_version which contain the following sensitive attributes secret_string and secret_binary
  • These attributes are then stored in plain text in the state file, which can be problematic
  • Since these attributes force a recreation of the resource there no point of keeping the whole JSON of aws secret version
  • This can be fixed easily by hashing sensitive data before storing it in the state file, and then when comparing the data to check for update only compare hashes

Affected Resource(s) and/or Data Source(s)

  • aws_secretsmanager_secret_version

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

Yes

@Azmah-Bad Azmah-Bad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 17, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/secretsmanager Issues and PRs that pertain to the secretsmanager service. label Feb 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 17, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Projects
None yet
Development

No branches or pull requests

2 participants