feat: Add support for 2 new security_policy_name (2024-01)

[robertgv]

Description

This PR adds 2 new Security policies for AWS Transfer Family. Additionally, it changes the default behavior when creating an AWS Transfer Family server using the console, API, or CLI.

The documentation has been updated with the TransferSecurityPolicy list ordered in the same way the official documentation is documented.

Relations

Closes #35676

References

More information can be found on the official AWS docs page: https://docs.aws.amazon.com/transfer/latest/userguide/security-policies.html

Output from Acceptance Testing

Output from test:

$  make test PKG=transfer
==> Checking that code complies with gofmt requirements...
go test ./internal/service/transfer/...  -timeout=5m
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	7.759s
...

Currently, I can't run acceptance tests.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @robertgv 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/basic\|TestAccTransfer_serial/Server/SecurityPolicy' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/basic\|TestAccTransfer_serial/Server/SecurityPolicy -timeout 360m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/SecurityPolicyFIPS
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
--- PASS: TestAccTransfer_serial (666.27s)
    --- PASS: TestAccTransfer_serial/Server (666.27s)
        --- PASS: TestAccTransfer_serial/Server/basic (202.16s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicyFIPS (227.84s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (236.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	701.713s

[ewbankkit]

@robertgv Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.