Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add vpc_id output of aws_elasticache_subnet_group data source #35887

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

Jebaseelanravi
Copy link
Contributor

Description

vpc_id attr is missing in aws_elasticache_subnet_group data source.
The vpc_id can be used for creating a security group of the ElastiCache cluster like the below.

data "aws_elasticache_subnet_group" "this" {
  name = "default"
}

resource "aws_security_group" "this" {
  name        = "example"
  description = "Example Security Group."
  vpc_id      = data.aws_elasticache_subnet_group.this.vpc_id
}

Affected Resource(s) and/or Data Source(s)

aws_elasticache_subnet_group
Potential Terraform Configuration
data "aws_elasticache_subnet_group" "this" {
  name = "default"
}

resource "aws_security_group" "this" {
  name        = "example"
  description = "Example Security Group."
  vpc_id      = data.aws_elasticache_subnet_group.this.vpc_id
}

Relations

Closes #27398

References

> aws elasticache describe-cache-subnet-groups --cache-subnet-group-name default
{
    "CacheSubnetGroups": [
        {
            "CacheSubnetGroupName": "default",
            "CacheSubnetGroupDescription": "Default CacheSubnetGroup",
            "VpcId": "vpc-xxxxxxx",
            "Subnets": [
                {
                    "SubnetIdentifier": "subnet-aaaaaaa
                    "SubnetAvailabilityZone": {
                        "Name": "ap-northeast-2d"
                    }
                },
                {
                    "SubnetIdentifier": "subnet-bbbbbbb",
                    "SubnetAvailabilityZone": {
                        "Name": "ap-northeast-2a"
                    }
                },
                {
                    "SubnetIdentifier": "subnet-ccccccc",
                    "SubnetAvailabilityZone": {
                        "Name": "ap-northeast-2c"
                    }
                },
                {
                    "SubnetIdentifier": "subnet-ddddddd",
                    "SubnetAvailabilityZone": {
                        "Name": "ap-northeast-2b"
                    }
                }
            ],
            "ARN": "arn:aws:elasticache:ap-northeast-2:xxxxxxx:subnetgroup:default"
        }
    ]
}

Output from Acceptance Testing

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. labels Feb 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2024
@Jebaseelanravi Jebaseelanravi marked this pull request as ready for review February 19, 2024 22:19
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 20, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheSubnetGroupDataSource_\|TestAccElastiCacheSubnetGroup_' PKG=elasticache ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=TestAccElastiCacheSubnetGroupDataSource_\|TestAccElastiCacheSubnetGroup_ -timeout 360m
=== RUN   TestAccElastiCacheSubnetGroupDataSource_basic
=== PAUSE TestAccElastiCacheSubnetGroupDataSource_basic
=== RUN   TestAccElastiCacheSubnetGroup_basic
=== PAUSE TestAccElastiCacheSubnetGroup_basic
=== RUN   TestAccElastiCacheSubnetGroup_disappears
=== PAUSE TestAccElastiCacheSubnetGroup_disappears
=== RUN   TestAccElastiCacheSubnetGroup_tags
=== PAUSE TestAccElastiCacheSubnetGroup_tags
=== RUN   TestAccElastiCacheSubnetGroup_update
=== PAUSE TestAccElastiCacheSubnetGroup_update
=== CONT  TestAccElastiCacheSubnetGroupDataSource_basic
=== CONT  TestAccElastiCacheSubnetGroup_tags
=== CONT  TestAccElastiCacheSubnetGroup_update
--- PASS: TestAccElastiCacheSubnetGroupDataSource_basic (38.00s)
=== CONT  TestAccElastiCacheSubnetGroup_disappears
--- PASS: TestAccElastiCacheSubnetGroup_update (63.62s)
=== CONT  TestAccElastiCacheSubnetGroup_basic
--- PASS: TestAccElastiCacheSubnetGroup_disappears (27.49s)
--- PASS: TestAccElastiCacheSubnetGroup_tags (80.22s)
--- PASS: TestAccElastiCacheSubnetGroup_basic (28.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	103.309s

@ewbankkit
Copy link
Contributor

@Jebaseelanravi Thanks for the contribution 🎉 👏.
I also added the vpc_id attribute to the corresponding resource.

@ewbankkit ewbankkit merged commit 7eb4a9c into hashicorp:main Feb 20, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.38.0 milestone Feb 20, 2024
Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add vpc_id output of aws_elasticache_subnet_group data source
2 participants