Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider token_bucket_rate_limiter_capacity parameter #35926

Merged
merged 21 commits into from Feb 21, 2024
Merged

Add provider token_bucket_rate_limiter_capacity parameter #35926

merged 21 commits into from Feb 21, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 21, 2024 •
edited

Description

Adds the token_bucket_rate_limiter_capacity parameter to the provider's configuration.

Relations

Relates hashicorp/aws-sdk-go-base#932.
Relates #34669.

Output from Acceptance Testing

Ensure that we have no regressions (using the cloudwatch service which has been migrated to AWS SDK for Go v2):

% make testacc TESTARGS='-run=TestAccCloudWatch' PKG=cloudwatch ACCTEST_PARALLELISM=6
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 6  -run=TestAccCloudWatch -timeout 360m
=== RUN   TestAccCloudWatchCompositeAlarm_basic
=== PAUSE TestAccCloudWatchCompositeAlarm_basic
=== RUN   TestAccCloudWatchCompositeAlarm_disappears
=== PAUSE TestAccCloudWatchCompositeAlarm_disappears
=== RUN   TestAccCloudWatchCompositeAlarm_tags
=== PAUSE TestAccCloudWatchCompositeAlarm_tags
=== RUN   TestAccCloudWatchCompositeAlarm_actionsEnabled
=== PAUSE TestAccCloudWatchCompositeAlarm_actionsEnabled
=== RUN   TestAccCloudWatchCompositeAlarm_alarmActions
=== PAUSE TestAccCloudWatchCompositeAlarm_alarmActions
=== RUN   TestAccCloudWatchCompositeAlarm_description
=== PAUSE TestAccCloudWatchCompositeAlarm_description
=== RUN   TestAccCloudWatchCompositeAlarm_updateAlarmRule
=== PAUSE TestAccCloudWatchCompositeAlarm_updateAlarmRule
=== RUN   TestAccCloudWatchCompositeAlarm_insufficientDataActions
=== PAUSE TestAccCloudWatchCompositeAlarm_insufficientDataActions
=== RUN   TestAccCloudWatchCompositeAlarm_okActions
=== PAUSE TestAccCloudWatchCompositeAlarm_okActions
=== RUN   TestAccCloudWatchCompositeAlarm_allActions
=== PAUSE TestAccCloudWatchCompositeAlarm_allActions
=== RUN   TestAccCloudWatchCompositeAlarm_actionsSuppressor
=== PAUSE TestAccCloudWatchCompositeAlarm_actionsSuppressor
=== RUN   TestAccCloudWatchDashboard_basic
=== PAUSE TestAccCloudWatchDashboard_basic
=== RUN   TestAccCloudWatchDashboard_disappears
=== PAUSE TestAccCloudWatchDashboard_disappears
=== RUN   TestAccCloudWatchMetricAlarm_basic
=== PAUSE TestAccCloudWatchMetricAlarm_basic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
=== RUN   TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== PAUSE TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
=== RUN   TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== PAUSE TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== RUN   TestAccCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccCloudWatchMetricAlarm_metricQuery
=== PAUSE TestAccCloudWatchMetricAlarm_metricQuery
=== RUN   TestAccCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccCloudWatchMetricAlarm_missingStatistic
=== RUN   TestAccCloudWatchMetricAlarm_tags
=== PAUSE TestAccCloudWatchMetricAlarm_tags
=== RUN   TestAccCloudWatchMetricAlarm_disappears
=== PAUSE TestAccCloudWatchMetricAlarm_disappears
=== RUN   TestAccCloudWatchMetricStream_basic
=== PAUSE TestAccCloudWatchMetricStream_basic
=== RUN   TestAccCloudWatchMetricStream_disappears
=== PAUSE TestAccCloudWatchMetricStream_disappears
=== RUN   TestAccCloudWatchMetricStream_nameGenerated
=== PAUSE TestAccCloudWatchMetricStream_nameGenerated
=== RUN   TestAccCloudWatchMetricStream_namePrefix
=== PAUSE TestAccCloudWatchMetricStream_namePrefix
=== RUN   TestAccCloudWatchMetricStream_includeFilters
=== PAUSE TestAccCloudWatchMetricStream_includeFilters
=== RUN   TestAccCloudWatchMetricStream_includeFiltersWithMetricNames
=== PAUSE TestAccCloudWatchMetricStream_includeFiltersWithMetricNames
=== RUN   TestAccCloudWatchMetricStream_excludeFilters
=== PAUSE TestAccCloudWatchMetricStream_excludeFilters
=== RUN   TestAccCloudWatchMetricStream_excludeFiltersWithMetricNames
=== PAUSE TestAccCloudWatchMetricStream_excludeFiltersWithMetricNames
=== RUN   TestAccCloudWatchMetricStream_update
=== PAUSE TestAccCloudWatchMetricStream_update
=== RUN   TestAccCloudWatchMetricStream_tags
=== PAUSE TestAccCloudWatchMetricStream_tags
=== RUN   TestAccCloudWatchMetricStream_additional_statistics
=== PAUSE TestAccCloudWatchMetricStream_additional_statistics
=== RUN   TestAccCloudWatchMetricStream_includeLinkedAccountsMetrics
=== PAUSE TestAccCloudWatchMetricStream_includeLinkedAccountsMetrics
=== CONT  TestAccCloudWatchCompositeAlarm_basic
=== CONT  TestAccCloudWatchMetricStream_update
=== CONT  TestAccCloudWatchMetricStream_includeLinkedAccountsMetrics
=== CONT  TestAccCloudWatchMetricAlarm_dataPointsToAlarm
=== CONT  TestAccCloudWatchMetricStream_basic
=== CONT  TestAccCloudWatchMetricStream_additional_statistics
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (26.54s)
=== CONT  TestAccCloudWatchCompositeAlarm_allActions
--- PASS: TestAccCloudWatchCompositeAlarm_basic (32.56s)
=== CONT  TestAccCloudWatchCompositeAlarm_description
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (47.06s)
=== CONT  TestAccCloudWatchCompositeAlarm_okActions
--- PASS: TestAccCloudWatchCompositeAlarm_description (45.44s)
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_swfAction
--- PASS: TestAccCloudWatchMetricStream_additional_statistics (93.37s)
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic
--- PASS: TestAccCloudWatchMetricStream_update (102.92s)
=== CONT  TestAccCloudWatchCompositeAlarm_insufficientDataActions
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (27.93s)
=== CONT  TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (28.62s)
=== CONT  TestAccCloudWatchCompositeAlarm_updateAlarmRule
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (65.80s)
=== CONT  TestAccCloudWatchMetricAlarm_basic
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (65.08s)
=== CONT  TestAccCloudWatchCompositeAlarm_actionsEnabled
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (48.91s)
=== CONT  TestAccCloudWatchDashboard_disappears
--- PASS: TestAccCloudWatchMetricAlarm_basic (32.48s)
=== CONT  TestAccCloudWatchCompositeAlarm_alarmActions
--- PASS: TestAccCloudWatchDashboard_disappears (26.28s)
=== CONT  TestAccCloudWatchDashboard_basic
--- PASS: TestAccCloudWatchMetricStream_basic (200.42s)
=== CONT  TestAccCloudWatchMetricAlarm_metricQuery
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (48.69s)
=== CONT  TestAccCloudWatchCompositeAlarm_actionsSuppressor
--- PASS: TestAccCloudWatchMetricStream_includeLinkedAccountsMetrics (228.27s)
=== CONT  TestAccCloudWatchMetricAlarm_disappears
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (71.24s)
=== CONT  TestAccCloudWatchCompositeAlarm_tags
--- PASS: TestAccCloudWatchDashboard_basic (53.79s)
=== CONT  TestAccCloudWatchMetricAlarm_tags
--- PASS: TestAccCloudWatchCompositeAlarm_actionsSuppressor (36.18s)
=== CONT  TestAccCloudWatchMetricAlarm_missingStatistic
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (5.43s)
=== CONT  TestAccCloudWatchMetricStream_includeFilters
--- PASS: TestAccCloudWatchMetricAlarm_disappears (30.11s)
=== CONT  TestAccCloudWatchMetricStream_tags
--- PASS: TestAccCloudWatchMetricStream_includeFilters (32.01s)
=== CONT  TestAccCloudWatchMetricStream_excludeFiltersWithMetricNames
--- PASS: TestAccCloudWatchCompositeAlarm_tags (74.30s)
=== CONT  TestAccCloudWatchMetricStream_nameGenerated
--- PASS: TestAccCloudWatchMetricAlarm_tags (69.39s)
=== CONT  TestAccCloudWatchMetricStream_excludeFilters
--- PASS: TestAccCloudWatchMetricStream_excludeFiltersWithMetricNames (31.98s)
=== CONT  TestAccCloudWatchMetricStream_namePrefix
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (225.64s)
=== CONT  TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
--- PASS: TestAccCloudWatchMetricStream_excludeFilters (25.48s)
=== CONT  TestAccCloudWatchMetricAlarm_extendedStatistic
--- PASS: TestAccCloudWatchMetricAlarm_metricQuery (154.45s)
=== CONT  TestAccCloudWatchCompositeAlarm_disappears
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (35.98s)
=== CONT  TestAccCloudWatchMetricAlarm_treatMissingData
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (26.31s)
=== CONT  TestAccCloudWatchMetricStream_disappears
--- PASS: TestAccCloudWatchMetricStream_nameGenerated (103.92s)
=== CONT  TestAccCloudWatchMetricStream_includeFiltersWithMetricNames
--- PASS: TestAccCloudWatchMetricStream_namePrefix (103.77s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (67.07s)
--- PASS: TestAccCloudWatchMetricStream_includeFiltersWithMetricNames (25.37s)
--- PASS: TestAccCloudWatchMetricStream_tags (230.86s)
--- PASS: TestAccCloudWatchMetricStream_disappears (124.30s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (223.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	581.315s

@ewbankkit
Add 'token_bucket_rate_limiter_capacity' configuration parameter.
b0b6d5d
@ewbankkit
Add CHANGELOG entry.
81fdd0b
@ewbankkit
Run 'go get github.com/hashicorp/aws-sdk-go-base/v2@7f2a917ddfa4169f8…
6a21558 
…b78303737d5bd9fb540b037 && go mod tidy'.
@ewbankkit
Set 'awsbase.Config.TokenBucketRateLimiterCapacity'.
c908828
@ewbankkit
'AWSClient.CredentialsProvider' pass Context.
f7a0c6e
@ewbankkit
'AWSClient.AwsConfig' pass Context.
ac0aa79
@ewbankkit
'AWSClient.PartitionHostname' pass Context.
6057afa
@ewbankkit
'AWSClient.RegionalHostname' pass Context.
15bedce
@ewbankkit
'AWSClient.CloudFrontDistributionHostedZoneID' pass Context.
2680ff5
@ewbankkit
'AWSClient.DefaultKMSKeyPolicy' pass Context.
36a0b22
@ewbankkit
'AWSClient.GlobalAcceleratorHostedZoneID' pass Context.
2c2efd9
@ewbankkit
'AWSClient.S3UsePathStyle' pass Context.
bdde2dd
@ewbankkit
'AWSClient.SetHTTPClient' pass Context.
03fc479
@ewbankkit
'AWSClient.HTTPClient' pass Context.
ca4f55c
@ewbankkit
'AWSClient.ReverseDNSPrefix' convert to getter.
e73cadf
@ewbankkit
'AWSClient.DNSSuffix' convert to getter.
9019c8b
@ewbankkit
Acceptance test output:
14ea6b1 
% make testacc TESTARGS='-run=TestAccMeta' PKG=meta ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 3  -run=TestAccMeta -timeout 360m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== RUN   TestAccMetaBillingServiceAccountDataSource_basic
=== PAUSE TestAccMetaBillingServiceAccountDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_basic
=== PAUSE TestAccMetaDefaultTagsDataSource_basic
=== RUN   TestAccMetaDefaultTagsDataSource_empty
=== PAUSE TestAccMetaDefaultTagsDataSource_empty
=== RUN   TestAccMetaDefaultTagsDataSource_multiple
=== PAUSE TestAccMetaDefaultTagsDataSource_multiple
=== RUN   TestAccMetaDefaultTagsDataSource_ignore
=== PAUSE TestAccMetaDefaultTagsDataSource_ignore
=== RUN   TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN   TestAccMetaIPRangesDataSource_none
=== PAUSE TestAccMetaIPRangesDataSource_none
=== RUN   TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== RUN   TestAccMetaIPRangesDataSource_uppercase
=== PAUSE TestAccMetaIPRangesDataSource_uppercase
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== RUN   TestAccMetaRegionDataSource_name
=== PAUSE TestAccMetaRegionDataSource_name
=== RUN   TestAccMetaRegionsDataSource_basic
=== PAUSE TestAccMetaRegionsDataSource_basic
=== RUN   TestAccMetaRegionsDataSource_filter
=== PAUSE TestAccMetaRegionsDataSource_filter
=== RUN   TestAccMetaRegionsDataSource_allRegions
=== PAUSE TestAccMetaRegionsDataSource_allRegions
=== RUN   TestAccMetaRegionsDataSource_nonExistentRegion
=== PAUSE TestAccMetaRegionsDataSource_nonExistentRegion
=== RUN   TestAccMetaService_basic
=== PAUSE TestAccMetaService_basic
=== RUN   TestAccMetaService_byReverseDNSName
=== PAUSE TestAccMetaService_byReverseDNSName
=== RUN   TestAccMetaService_byDNSName
=== PAUSE TestAccMetaService_byDNSName
=== RUN   TestAccMetaService_byParts
=== PAUSE TestAccMetaService_byParts
=== RUN   TestAccMetaService_unsupported
=== PAUSE TestAccMetaService_unsupported
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaRegionsDataSource_nonExistentRegion
=== CONT  TestAccMetaRegionDataSource_endpoint
--- PASS: TestAccMetaARNDataSource_basic (20.78s)
=== CONT  TestAccMetaRegionDataSource_name
--- PASS: TestAccMetaRegionsDataSource_nonExistentRegion (22.41s)
=== CONT  TestAccMetaRegionDataSource_endpointAndName
--- PASS: TestAccMetaRegionDataSource_endpoint (22.61s)
=== CONT  TestAccMetaIPRangesDataSource_basic
--- PASS: TestAccMetaRegionDataSource_name (17.88s)
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_basic (17.64s)
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaRegionDataSource_endpointAndName (19.21s)
=== CONT  TestAccMetaIPRangesDataSource_uppercase
--- PASS: TestAccMetaRegionDataSource_basic (25.67s)
=== CONT  TestAccMetaIPRangesDataSource_url
--- PASS: TestAccMetaPartitionDataSource_basic (25.58s)
=== CONT  TestAccMetaRegionsDataSource_basic
--- PASS: TestAccMetaIPRangesDataSource_uppercase (25.87s)
=== CONT  TestAccMetaRegionsDataSource_allRegions
--- PASS: TestAccMetaIPRangesDataSource_url (17.29s)
=== CONT  TestAccMetaRegionsDataSource_filter
--- PASS: TestAccMetaRegionsDataSource_basic (16.91s)
=== CONT  TestAccMetaIPRangesDataSource_none
--- PASS: TestAccMetaRegionsDataSource_allRegions (16.36s)
=== CONT  TestAccMetaDefaultTagsDataSource_empty
--- PASS: TestAccMetaRegionsDataSource_filter (15.42s)
=== CONT  TestAccMetaDefaultTagsDataSource_ignore
--- PASS: TestAccMetaDefaultTagsDataSource_empty (13.47s)
=== CONT  TestAccMetaDefaultTagsDataSource_multiple
--- PASS: TestAccMetaIPRangesDataSource_none (14.62s)
=== CONT  TestAccMetaBillingServiceAccountDataSource_basic
--- PASS: TestAccMetaDefaultTagsDataSource_multiple (13.52s)
=== CONT  TestAccMetaService_byDNSName
--- PASS: TestAccMetaBillingServiceAccountDataSource_basic (13.57s)
=== CONT  TestAccMetaService_unsupported
--- PASS: TestAccMetaDefaultTagsDataSource_ignore (25.12s)
=== CONT  TestAccMetaService_byParts
--- PASS: TestAccMetaService_unsupported (13.85s)
=== CONT  TestAccMetaDefaultTagsDataSource_basic
--- PASS: TestAccMetaService_byDNSName (14.07s)
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaService_byParts (16.24s)
=== CONT  TestAccMetaService_byReverseDNSName
--- PASS: TestAccMetaDefaultTagsDataSource_basic (15.88s)
=== CONT  TestAccMetaService_basic
--- PASS: TestAccMetaARNDataSource_s3Bucket (16.16s)
--- PASS: TestAccMetaService_byReverseDNSName (14.92s)
--- PASS: TestAccMetaService_basic (13.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	168.329s
@ewbankkit
Use 'names'.
b5fb26c
@ewbankkit
Merge branch 'main' into f-token_bucket_rate_limiter_capacity
9fab229 
# Conflicts:
#	go.mod
#	go.sum
@ewbankkit ewbankkit changed the title Add provider token_bucket_rate_limiter_capacity parameter [WIP] Add provider token_bucket_rate_limiter_capacity parameter Feb 21, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. service/s3 Issues and PRs that pertain to the s3 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/sagemaker Issues and PRs that pertain to the sagemaker service. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 21, 2024
@github-actions github-actions bot added service/efs Issues and PRs that pertain to the efs service. service/kms Issues and PRs that pertain to the kms service. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. service/transfer Issues and PRs that pertain to the transfer service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. sweeper Pertains to changes to or issues with the sweeper. client-connections Pertains to the AWS Client and service connections. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/meta Issues and PRs that pertain to the meta service. labels Feb 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 21, 2024
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Feb 21, 2024
@ewbankkit ewbankkit changed the title [WIP] Add provider token_bucket_rate_limiter_capacity parameter Add provider token_bucket_rate_limiter_capacity parameter Feb 21, 2024
@ewbankkit ewbankkit merged commit 6a9a929 into main Feb 21, 2024
62 checks passed
@ewbankkit ewbankkit deleted the f-token_bucket_rate_limiter_capacity branch February 21, 2024 22:12
@github-actions github-actions bot added this to the v5.38.0 milestone Feb 21, 2024
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
Update CHANGELOG.md for #35926
d9e501f
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 23, 2024
@ewbankkit ewbankkit mentioned this pull request Feb 29, 2024
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/kms Issues and PRs that pertain to the kms service. service/meta Issues and PRs that pertain to the meta service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.38.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit