Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Forcenew for data_type in SSM parameter #35960

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

dchittibala
Copy link

Description

When an SSM parameter is created with a data_type: text and is changed to data_type: aws:ec2:image and vice versa, the provider tries to perform an in-place replacement instead of force replacement where it needs to destroy the SSM parameter and recreate it with correct data_type

Relations

Closes #35959

Output from Acceptance Testing

➜ make testacc TESTS=TestParameterShouldUpdate PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestParameterShouldUpdate'  -timeout 360m
=== RUN   TestParameterShouldUpdate
=== PAUSE TestParameterShouldUpdate
=== CONT  TestParameterShouldUpdate
--- PASS: TestParameterShouldUpdate (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	6.602s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. and removed service/ssm Issues and PRs that pertain to the ssm service. labels Feb 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dchittibala 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2024
@nam054
Copy link
Contributor

nam054 commented Mar 26, 2024

LGTM! 🚀 Thank you so much for your contribution!

> make testacc TESTARGS="-run=TestAccSSMParameter_DataType_" PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSMParameter_DataType_ -timeout 360m
=== RUN   TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN   TestAccSSMParameter_DataType_ssmIntegration
=== PAUSE TestAccSSMParameter_DataType_ssmIntegration
=== RUN   TestAccSSMParameter_DataType_update
=== PAUSE TestAccSSMParameter_DataType_update
=== CONT  TestAccSSMParameter_DataType_ec2Image
=== CONT  TestAccSSMParameter_DataType_update
=== CONT  TestAccSSMParameter_DataType_ssmIntegration
--- PASS: TestAccSSMParameter_DataType_ssmIntegration (14.44s)
--- PASS: TestAccSSMParameter_DataType_ec2Image (16.47s)
--- PASS: TestAccSSMParameter_DataType_update (25.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        31.337s

@nam054 nam054 merged commit 7e31a73 into hashicorp:main Mar 26, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 26, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants