Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_iot_role_alias: Add tagging support #36255

Merged
merged 2 commits into from Mar 7, 2024

Conversation

fatbasstard
Copy link
Contributor

@fatbasstard fatbasstard commented Mar 7, 2024

Description

Add tags to aws_iot_role_alias

Relations

Closes #31415.
Relates #36102.

Output from Acceptance Testing

% make testacc TESTS=TestAccIoTRoleAlias_ PKG=iot

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTRoleAlias_'  -timeout 360m
=== RUN   TestAccIoTRoleAlias_basic
=== PAUSE TestAccIoTRoleAlias_basic
=== RUN   TestAccIoTRoleAlias_tags
=== PAUSE TestAccIoTRoleAlias_tags
=== CONT  TestAccIoTRoleAlias_basic
=== CONT  TestAccIoTRoleAlias_tags
--- PASS: TestAccIoTRoleAlias_tags (22.99s)
--- PASS: TestAccIoTRoleAlias_basic (38.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	42.145s

Copy link

github-actions bot commented Mar 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iot Issues and PRs that pertain to the iot service. generators Relates to code generators. labels Mar 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 7, 2024
@fatbasstard fatbasstard changed the title r/aws_iot_role_alias Add tagging support r/aws_iot_role_alias: Add tagging support Mar 7, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIoTRoleAlias_' PKG=iot ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 3  -run=TestAccIoTRoleAlias_ -timeout 360m
=== RUN   TestAccIoTRoleAlias_basic
=== PAUSE TestAccIoTRoleAlias_basic
=== RUN   TestAccIoTRoleAlias_tags
=== PAUSE TestAccIoTRoleAlias_tags
=== CONT  TestAccIoTRoleAlias_basic
=== CONT  TestAccIoTRoleAlias_tags
--- PASS: TestAccIoTRoleAlias_tags (48.90s)
--- PASS: TestAccIoTRoleAlias_basic (76.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	83.475s

@ewbankkit
Copy link
Contributor

@fatbasstard Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c8cabe3 into hashicorp:main Mar 7, 2024
71 checks passed
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for tags on AWS IOT RoleAlias and Policy
2 participants