b-aws_ecs-fix-service-connect-bug-when-empty-block-supplied

[dgr237]

Description

A bug exists in the ECS Service Connect configuration if one of the blocks:

issuer_cert_authority is configured as:

issuer_cert_authority {
    aws_pca_authority_arn = null
}

This case should be handled nicely and the plan fail (setting isser_cert_authority or aws_private_authority_arn throws an error).

or:

timeout is configured as:

timeout {}

or

timeout {
  idle_timeout_seconds = null
  per_request_timeout_seconds = null
}

This case should be handled by setting timeout to null

Relations

Closes #35868

Output from Acceptance Testing

% make testacc TESTS=TestAccECSService_ServiceConnect_tls_with_empty_timeout PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_ServiceConnect_tls_with_empty_timeout'  -timeout 360m
=== RUN   TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== PAUSE TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== CONT  TestAccECSService_ServiceConnect_tls_with_empty_timeout
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (178.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        182.091s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSService_ServiceConnect_' PKG=ecs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSService_ServiceConnect_ -timeout 360m
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== PAUSE TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== CONT  TestAccECSService_ServiceConnect_basic
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
=== CONT  TestAccECSService_ServiceConnect_tls_with_empty_timeout
--- PASS: TestAccECSService_ServiceConnect_basic (166.23s)
=== CONT  TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (173.92s)
=== CONT  TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (173.98s)
--- PASS: TestAccECSService_ServiceConnect_full (173.83s)
--- PASS: TestAccECSService_ServiceConnect_remove (176.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	357.649s

[ewbankkit]

@dgr237 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.