Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the new aws_servicecatalogappregistry_application is not working as expected #36697

Closed
kevindesao opened this issue Apr 2, 2024 · 6 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service.
Milestone

Comments

@kevindesao
Copy link

kevindesao commented Apr 2, 2024

Hello,
I was really excited to try this out but it turns out I'm not able to make it work smoothly.

The creation of the resource worked fine but the implementation of the ARN as a tag fails to link the resource to the app.

The doc is mentioning the following:

resource "aws_servicecatalogappregistry_application" "example" {
  name = "example-app"
}

resource "aws_s3_bucket" "bucket" {
  bucket = "example-bucket"

  tags = {
    awsApplication = aws_servicecatalogappregistry_application.example.arn
  }
}

But by looking into the created myApp in the console the tags is not simply the ARN of the myApplication resources.

  • ARN myApplication : arn:aws:servicecatalog:<region>:<account-id>:/applications/<ramdom_ARN_ID>
  • Application tag value: arn:aws:resource-groups:<region>:<account-id>:group/<myApplication_name>/<ramdom_ARN_ID>

Tag Value tried unsuccessfully:

  • simply the myApplication id : <ramdom_ARN_ID>
  • The ARN arn:aws:servicecatalog:<region>:<account-id>:/applications/<ramdom_ARN_ID>

So to resume, I think a new attribute is required (and the doc updated):

SOLUTION: In the meantime the ARN can be reconstructed like this: (Tested)

  common_tags = {
    awsApplication = "arn:aws:resource-groups:${data.aws_region.myApplication.name}:${data.aws_caller_identity.myApplication.id}:group/${aws_servicecatalogappregistry_application.this.name}/${aws_servicecatalogappregistry_application.this.id}"
  }

Originally posted by @kevindesao in #36277 (comment)

Copy link

github-actions bot commented Apr 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. labels Apr 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 2, 2024
@jar-b jar-b added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. service/s3 Issues and PRs that pertain to the s3 service. labels Apr 3, 2024
@jar-b
Copy link
Member

jar-b commented Apr 3, 2024

This was addressed by #36647, which added the application_tag attribute and will be released in v5.44.0 later this week.

@jar-b
Copy link
Member

jar-b commented Apr 3, 2024

Closed by #36647

@jar-b jar-b closed this as completed Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@jar-b jar-b added this to the v5.44.0 milestone Apr 3, 2024
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented May 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service.
Projects
None yet
Development

No branches or pull requests

2 participants