Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_devopsguru_notification_channel reordering on each deployment even without change #36731

Closed
xnick123 opened this issue Apr 4, 2024 · 4 comments · Fixed by #36804
Closed
Assignees
Labels
bug Addresses a defect in current functionality. service/devopsguru Issues and PRs that pertain to the devopsguru service.
Milestone

Comments

@xnick123
Copy link

xnick123 commented Apr 4, 2024

Terraform Core Version

1.7.5

AWS Provider Version

5.43

Affected Resource(s)

aws_devopsguru_notification_channel

Expected Behavior

After initially adding filters, no change should be detected if there is no change applied.

Actual Behavior

A replacement is forced on every deploy even without change. For both severities and message_types

Relevant Error/Panic Output Snippet

-/+ resource "aws_devopsguru_notification_channel" "devops_guru_rds" {
      ~ id = "************" -> (known after apply)
      ~ filters {
          ~ message_types = [ # forces replacement
              + "NEW_INSIGHT",
                "CLOSED_INSIGHT",
                "NEW_ASSOCIATION",
              - "NEW_INSIGHT",
              - "NEW_RECOMMENDATION",
                "SEVERITY_UPGRADED",
              + "NEW_RECOMMENDATION",
            ]
          ~ severities    = [ # forces replacement
              - "HIGH",
                "LOW",
                "MEDIUM",
              + "HIGH",
            ]
        }
        # (1 unchanged block hidden)
    }

Terraform Configuration Files

resource "aws_devopsguru_notification_channel" "devops_guru_rds" {
  sns {
    topic_arn = aws_sns_topic.evaluate_aws_feature.arn
  }

  filters {
    message_types = ["CLOSED_INSIGHT", "NEW_ASSOCIATION", "NEW_INSIGHT", "NEW_RECOMMENDATION", "SEVERITY_UPGRADED"]
    severities    = ["LOW", "MEDIUM", "HIGH"]
  }
}

Steps to Reproduce

  1. add filters and deploy tf
  2. redeploy without tf change

Debug Output

No response

Panic Output

No response

Important Factoids

I have noticed similar ordering behaviour with the awscc provider for awscc_codeguruprofiler_profiling_group. I dont know enough Go yet to identify whether it is a GO, AWS GO SDK or AWS API issue.

References

No response

Would you like to implement a fix?

No

@xnick123 xnick123 added the bug Addresses a defect in current functionality. label Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/devopsguru Issues and PRs that pertain to the devopsguru service. label Apr 4, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 4, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Apr 8, 2024
@jar-b jar-b self-assigned this Apr 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 8, 2024
Copy link

github-actions bot commented Apr 9, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.45.0 milestone Apr 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
Copy link

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/devopsguru Issues and PRs that pertain to the devopsguru service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants