Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-aws_transfer_connector-support security policies #36893

Merged
merged 8 commits into from
Apr 18, 2024
Merged

f-aws_transfer_connector-support security policies #36893

merged 8 commits into from
Apr 18, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 12, 2024 •
edited
Loading

Description

Relations

Closes #36829

References

Output from Acceptance Testing

% make testacc TESTS=TestAccTransferConnector_securityPolicyName PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnector_securityPolicyName'  -timeout 360m
=== RUN   TestAccTransferConnector_securityPolicyName
--- PASS: TestAccTransferConnector_securityPolicyName (24.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	41.167s
% make testacc TESTS=TestAccTransferConnector PKG=transfer           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnector'  -timeout 360m
=== RUN   TestAccTransferConnector_basic
--- PASS: TestAccTransferConnector_basic (36.15s)
=== RUN   TestAccTransferConnector_sftpConfig
--- PASS: TestAccTransferConnector_sftpConfig (20.82s)
=== RUN   TestAccTransferConnector_securityPolicyName
--- PASS: TestAccTransferConnector_securityPolicyName (20.70s)
=== RUN   TestAccTransferConnector_disappears
--- PASS: TestAccTransferConnector_disappears (17.66s)
=== RUN   TestAccTransferConnector_tags
--- PASS: TestAccTransferConnector_tags (44.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	152.597s
...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. size/M Managed by automation to categorize the size of a PR. labels Apr 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
@jar-b
Merge branch 'main' into f-aws_transfer_connector-security-policy
f3e76fb
@jar-b
r/aws_transfer_connector(doc): tweak security_policy_name description
0a6a3e3
@jar-b
r/aws_transfer_connector(test): tweak _securityPolicyName config args
732fb4e 
The security_policy_name argument is now set to a provided argument value, rather than hardcoded. In the future we should consider a data source to remove the dependency on the hardcoded policy name altogether.

```console
% make testacc PKG=transfer TESTS=TestAccTransferConnector_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnector_'  -timeout 360m
=== RUN   TestAccTransferConnector_basic
--- PASS: TestAccTransferConnector_basic (19.12s)
=== RUN   TestAccTransferConnector_sftpConfig
--- PASS: TestAccTransferConnector_sftpConfig (11.95s)
=== RUN   TestAccTransferConnector_securityPolicyName
--- PASS: TestAccTransferConnector_securityPolicyName (11.71s)
=== RUN   TestAccTransferConnector_disappears
--- PASS: TestAccTransferConnector_disappears (9.65s)
=== RUN   TestAccTransferConnector_tags
--- PASS: TestAccTransferConnector_tags (24.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   82.493s
```
jar-b
jar-b approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=transfer TESTS=TestAccTransferConnector_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnector_'  -timeout 360m
=== RUN   TestAccTransferConnector_basic
--- PASS: TestAccTransferConnector_basic (19.12s)
=== RUN   TestAccTransferConnector_sftpConfig
--- PASS: TestAccTransferConnector_sftpConfig (11.95s)
=== RUN   TestAccTransferConnector_securityPolicyName
--- PASS: TestAccTransferConnector_securityPolicyName (11.71s)
=== RUN   TestAccTransferConnector_disappears
--- PASS: TestAccTransferConnector_disappears (9.65s)
=== RUN   TestAccTransferConnector_tags
--- PASS: TestAccTransferConnector_tags (24.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   82.493s

@jar-b
Copy link
Member

jar-b commented Apr 17, 2024

Thanks for your contribution, @nikhil-goenka! 👍

@jar-b jar-b merged commit 546cb9b into hashicorp:main Apr 18, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 18, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jar-b jar-b mentioned this pull request Apr 24, 2024
Open
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the f-aws_transfer_connector-security-policy branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.46.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Security policies for AWS Transfer SFTP connectors
3 participants
@nikhil-goenka @jar-b @justinretzolk