Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_vpc_ipam_pool support for cascade #36898

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 13, 2024

Description

Relations

Closes #36245

References

Output from Acceptance Testing

% make testacc TESTS=TestAccIPAM_cascade PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAM_cascade'  -timeout 360m
=== RUN   TestAccIPAM_cascade
=== PAUSE TestAccIPAM_cascade
=== CONT  TestAccIPAM_cascade
--- PASS: TestAccIPAM_cascade (73.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	92.230s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ipam Issues and PRs that pertain to the ipam service. labels Apr 13, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 13, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ec2 TESTS="TestAccIPAMPool_" ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccIPAMPool_'  -timeout 360m
=== RUN   TestAccIPAMPool_basic
=== PAUSE TestAccIPAMPool_basic
=== RUN   TestAccIPAMPool_disappears
=== PAUSE TestAccIPAMPool_disappears
=== RUN   TestAccIPAMPool_ipv6Basic
=== PAUSE TestAccIPAMPool_ipv6Basic
=== RUN   TestAccIPAMPool_ipv6Contiguous
=== PAUSE TestAccIPAMPool_ipv6Contiguous
=== RUN   TestAccIPAMPool_cascade
=== PAUSE TestAccIPAMPool_cascade
=== RUN   TestAccIPAMPool_tags
=== PAUSE TestAccIPAMPool_tags
=== CONT  TestAccIPAMPool_basic
--- PASS: TestAccIPAMPool_basic (56.32s)
=== CONT  TestAccIPAMPool_ipv6Contiguous
--- PASS: TestAccIPAMPool_ipv6Contiguous (50.17s)
=== CONT  TestAccIPAMPool_tags
--- PASS: TestAccIPAMPool_tags (61.07s)
=== CONT  TestAccIPAMPool_cascade
--- PASS: TestAccIPAMPool_cascade (83.87s)
=== CONT  TestAccIPAMPool_ipv6Basic
--- PASS: TestAccIPAMPool_ipv6Basic (67.03s)
=== CONT  TestAccIPAMPool_disappears
--- PASS: TestAccIPAMPool_disappears (39.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        364.138s

@jar-b
Copy link
Member

jar-b commented Apr 16, 2024

Thanks for your contribution, @nikhil-goenka! 👍

@jar-b jar-b merged commit a44a6b9 into hashicorp:main Apr 16, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 16, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the f-aws_vpc_ipam_pool branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ipam Issues and PRs that pertain to the ipam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add resource aws_vpc_ipam_pool cascade argument
3 participants