Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_mwaa_environment: added endpoint service as output #36903

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 14, 2024

Description

Relations

Closes #36085

References

Output from Acceptance Testing

% make testacc TESTS=TestAccMWAAEnvironment_basic PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment_basic'  -timeout 360m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_basic
--- PASS: TestAccMWAAEnvironment_basic (3022.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	3041.255s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mwaa Issues and PRs that pertain to the mwaa service. labels Apr 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 14, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2024
@ewbankkit ewbankkit self-assigned this Apr 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMWAAEnvironment_basic' PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_basic -timeout 360m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_basic
--- PASS: TestAccMWAAEnvironment_basic (3020.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	3034.436s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ca36702 into hashicorp:main Apr 15, 2024
62 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 15, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the f-aws_mwaa_environment branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/mwaa Issues and PRs that pertain to the mwaa service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_mwaa_environment output webserver_vpc_endpoint_service and database_vpc_endpoint_service
2 participants